[PATCH] powerpc/fadump: trivial fix of spelling mistake, clean up message

[PATCH] powerpc/fadump: trivial fix of spelling mistake, clean up message

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

trivial fix to spelling mistake "rgistration" and minor clean up
of the printk error message

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 arch/powerpc/kernel/fadump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
index 3cb3b02a..0358f5b 100644
--- a/arch/powerpc/kernel/fadump.c
+++ b/arch/powerpc/kernel/fadump.c
@@ -1010,7 +1010,7 @@ static int fadump_invalidate_dump(struct fadump_mem_struct *fdm)
 
 	if (rc) {
 		printk(KERN_ERR "Failed to invalidate firmware-assisted dump "
-			"rgistration. unexpected error(%d).\n", rc);
+			"registration. Unexpected error (%d).\n", rc);
 		return rc;
 	}
 	fw_dump.dump_active = 0;
-- 
2.8.1

Re: powerpc/fadump: trivial fix of spelling mistake, clean up message

[Michael Ellerman]

On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> trivial fix to spelling mistake "rgistration" and minor clean up
> of the printk error message

Can you also:
 - use pr_err()
 - unsplit the message, ie. keep the string all on one line.

cheers

Re: powerpc/fadump: trivial fix of spelling mistake, clean up message

[Colin Ian King]

On 26/06/16 05:19, Michael Ellerman wrote:
> On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> trivial fix to spelling mistake "rgistration" and minor clean up
>> of the printk error message
> 
> Can you also:
>  - use pr_err()
>  - unsplit the message, ie. keep the string all on one line.

I can unsplit the string, but checkpatch will complain about that, so
I'm not sure if that's preferred or not.

WARNING: line over 80 characters

Colin

Re: powerpc/fadump: trivial fix of spelling mistake, clean up message

[Joe Perches]

On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote:
> On 26/06/16 05:19, Michael Ellerman wrote:
> > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote:
[]
> > > trivial fix to spelling mistake "rgistration" and minor clean up
> > > of the printk error message
> > Can you also:
> >  - use pr_err()
> >  - unsplit the message, ie. keep the string all on one line.
> I can unsplit the string, but checkpatch will complain about that, so
> I'm not sure if that's preferred or not.
> 
> WARNING: line over 80 characters

If the statement is wrapped after the format,
then checkpatch shouldn't complain.

	pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n",
	       rc);

Re: powerpc/fadump: trivial fix of spelling mistake, clean up message

[Michael Ellerman]

On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote:
> On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote:
> > On 26/06/16 05:19, Michael Ellerman wrote:
> > > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote:
> > > > trivial fix to spelling mistake "rgistration" and minor clean up
> > > > of the printk error message
> > > Can you also:
> > >  - use pr_err()
> > >  - unsplit the message, ie. keep the string all on one line.
> > I can unsplit the string, but checkpatch will complain about that, so
> > I'm not sure if that's preferred or not.
> > 
> > WARNING: line over 80 characters
> 
> If the statement is wrapped after the format,
> then checkpatch shouldn't complain.
> 
> 	pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n",
> 	       rc);

But that's not actually any more readable, so just ignore checkpatch in this
case IMHO. It's a guide, not the gospel.

cheers

Re: powerpc/fadump: trivial fix of spelling mistake, clean up message

[Joe Perches]

On Mon, 2016-06-27 at 21:20 +1000, Michael Ellerman wrote:
> On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote:
> > 
> > On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote:
> > > 
> > > On 26/06/16 05:19, Michael Ellerman wrote:
> > > > 
> > > > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote:
> > > > > 
> > > > > trivial fix to spelling mistake "rgistration" and minor clean up
> > > > > of the printk error message
> > > > Can you also:
> > > >  - use pr_err()
> > > >  - unsplit the message, ie. keep the string all on one line.
> > > I can unsplit the string, but checkpatch will complain about that, so
> > > I'm not sure if that's preferred or not.
> > > 
> > > WARNING: line over 80 characters
> > If the statement is wrapped after the format,
> > then checkpatch shouldn't complain.
> > 
> > 	pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n",
> > 	       rc);
> But that's not actually any more readable, so just ignore checkpatch in this
> case IMHO. It's a guide, not the gospel.

Absolutely.  Ignore checkpatch whenever appropriate.

There are relatively few lines in kernel source that
have printk arguments post format that extend beyond
80 columns though and standardization is also good.

cheers back.

Re: powerpc/fadump: trivial fix of spelling mistake, clean up message

[Colin Ian King]

On 27/06/16 12:20, Michael Ellerman wrote:
> On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote:
>> On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote:
>>> On 26/06/16 05:19, Michael Ellerman wrote:
>>>> On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote:
>>>>> trivial fix to spelling mistake "rgistration" and minor clean up
>>>>> of the printk error message
>>>> Can you also:
>>>>  - use pr_err()
>>>>  - unsplit the message, ie. keep the string all on one line.
>>> I can unsplit the string, but checkpatch will complain about that, so
>>> I'm not sure if that's preferred or not.
>>>
>>> WARNING: line over 80 characters
>>
>> If the statement is wrapped after the format,
>> then checkpatch shouldn't complain.
>>
>> 	pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n",
>> 	       rc);
> 
> But that's not actually any more readable, so just ignore checkpatch in this
> case IMHO. It's a guide, not the gospel.
> 
> cheers
> 
OK, so shall I'll send a V3 w/o the spit and the pr_err fix?

Re: powerpc/fadump: trivial fix of spelling mistake, clean up message

[Michael Ellerman]

On Mon, 2016-06-27 at 12:34 +0100, Colin Ian King wrote:
> On 27/06/16 12:20, Michael Ellerman wrote:
> > On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote:
> > > On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote:
> > > > On 26/06/16 05:19, Michael Ellerman wrote:
> > > > > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote:
> > > > > > trivial fix to spelling mistake "rgistration" and minor clean up
> > > > > > of the printk error message
> > > > > Can you also:
> > > > >  - use pr_err()
> > > > >  - unsplit the message, ie. keep the string all on one line.
> > > > I can unsplit the string, but checkpatch will complain about that, so
> > > > I'm not sure if that's preferred or not.
> > > > 
> > > > WARNING: line over 80 characters
> > > 
> > > If the statement is wrapped after the format,
> > > then checkpatch shouldn't complain.
> > > 
> > > 	pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n",
> > > 	       rc);
> > 
> > But that's not actually any more readable, so just ignore checkpatch in this
> > case IMHO. It's a guide, not the gospel.
>
> OK, so shall I'll send a V3 w/o the spit and the pr_err fix?

Nah that's fine, I already grabbed v2.

cheers