From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drm: rcar-du: Update Gen3 output limitations
Date: Fri, 14 Sep 2018 14:05:44 +0300 [thread overview]
Message-ID: <4037354.l5ltzbp0ev@avalon> (raw)
In-Reply-To: <20180831181259.29529-2-kieran.bingham+renesas@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Friday, 31 August 2018 21:12:57 EEST Kieran Bingham wrote:
> The R-Car Gen3 DU utilises the VSP1 hardware for memory access. The
> limits on the RPF and WPF in this pipeline are 8190x8190.
>
> Update the supported maximum sizes accordingly.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index ed7fa3204892..7c7aff8cdf77
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -512,12 +512,22 @@ int rcar_du_modeset_init(struct rcar_du_device *rcdu)
>
> dev->mode_config.min_width = 0;
> dev->mode_config.min_height = 0;
> - dev->mode_config.max_width = 4095;
> - dev->mode_config.max_height = 2047;
> dev->mode_config.normalize_zpos = true;
> dev->mode_config.funcs = &rcar_du_mode_config_funcs;
> dev->mode_config.helper_private = &rcar_du_mode_config_helper;
>
> + if (rcdu->info->gen < 3) {
> + dev->mode_config.max_width = 4095;
> + dev->mode_config.max_height = 2047;
> + } else {
> + /*
> + * The Gen3 DU uses the VSP1 for memory access, and is limited
> + * to frame sizes of 8190x8190.
> + */
> + dev->mode_config.max_width = 8190;
> + dev->mode_config.max_height = 8190;
> + }
> +
> rcdu->num_crtcs = hweight8(rcdu->info->channels_mask);
>
> ret = rcar_du_properties_init(rcdu);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-09-14 11:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 18:12 [PATCH 0/3] drm: rcar-du: Update DU support Kieran Bingham
2018-08-31 18:12 ` [PATCH 1/3] drm: rcar-du: Update Gen3 output limitations Kieran Bingham
2018-09-14 11:05 ` Laurent Pinchart [this message]
2018-08-31 18:12 ` [PATCH 2/3] drm: rcar-du: Add pixel format support Kieran Bingham
2018-09-14 11:11 ` Laurent Pinchart
2018-09-14 13:02 ` Kieran Bingham
2018-09-14 11:17 ` Laurent Pinchart
2018-09-14 13:20 ` Kieran Bingham
2018-08-31 18:12 ` [PATCH 3/3] drm: rcar-du: Update framebuffer pitch and alignment limits for Gen3 Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4037354.l5ltzbp0ev@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).