From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Subject: Re: [PATCH 2/3] drm: rcar-du: Add pixel format support
Date: Fri, 14 Sep 2018 14:02:09 +0100 [thread overview]
Message-ID: <e9a443fa-729b-fad9-cb06-9a8d2d65b408@ideasonboard.com> (raw)
In-Reply-To: <9318122.8LJjaKzHaP@avalon>
Hi Laurent,
On 14/09/18 12:11, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> How about renaming the subject line to "Add support for missing pixel formats"
> ?
>
Ack.
> On Friday, 31 August 2018 21:12:58 EEST Kieran Bingham wrote:
>> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>>
>> This patch supports pixel format of RGB332, ARGB4444, XRGB4444,
>> BGR888, RGB888, BGRA8888, BGRX8888 and YVYU.
>> VYUY pixel format is not supported by H/W specification.
>>
>> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>
>> ---
>>
>> This patch does not remove existing support for multiplanar YVUY, even
>> though the hardware does not explicitly provide it, because we support
>> it through software by swapping the plane buffers.
>>
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 32 +++++++++++++++++++++++++++
>> 1 file changed, 32 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
>> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index 7c7aff8cdf77..d1bd174ec893
>> 100644
>> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
>> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
>> @@ -124,6 +124,38 @@ static const struct rcar_du_format_info
>> rcar_du_format_infos[] = { .fourcc = DRM_FORMAT_YVU444,
>> .bpp = 24,
>> .planes = 3,
>> + }, {
>> + .fourcc = DRM_FORMAT_RGB332,
>> + .bpp = 8,
>> + .planes = 1,
>> + }, {
>> + .fourcc = DRM_FORMAT_ARGB4444,
>> + .bpp = 16,
>> + .planes = 1,
>> + }, {
>> + .fourcc = DRM_FORMAT_XRGB4444,
>> + .bpp = 16,
>> + .planes = 1,
>> + }, {
>> + .fourcc = DRM_FORMAT_BGR888,
>> + .bpp = 24,
>> + .planes = 1,
>> + }, {
>> + .fourcc = DRM_FORMAT_RGB888,
>> + .bpp = 24,
>> + .planes = 1,
>> + }, {
>> + .fourcc = DRM_FORMAT_BGRA8888,
>> + .bpp = 32,
>> + .planes = 1,
>> + }, {
>> + .fourcc = DRM_FORMAT_BGRX8888,
>> + .bpp = 32,
>> + .planes = 1,
>> + }, {
>> + .fourcc = DRM_FORMAT_YVYU,
>> + .bpp = 16,
>> + .planes = 1,
>> },
>> };
>
> I would list the RGB formats first, followed by the packed YUV format, and
> then the multiplanar YUV formats. With this changed,
>
Ack.
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> If you're fine with the changes there's no need to resubmit.
That's fine by me.
Thanks
--
Kieran
next prev parent reply other threads:[~2018-09-14 13:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 18:12 [PATCH 0/3] drm: rcar-du: Update DU support Kieran Bingham
2018-08-31 18:12 ` [PATCH 1/3] drm: rcar-du: Update Gen3 output limitations Kieran Bingham
2018-09-14 11:05 ` Laurent Pinchart
2018-08-31 18:12 ` [PATCH 2/3] drm: rcar-du: Add pixel format support Kieran Bingham
2018-09-14 11:11 ` Laurent Pinchart
2018-09-14 13:02 ` Kieran Bingham [this message]
2018-09-14 11:17 ` Laurent Pinchart
2018-09-14 13:20 ` Kieran Bingham
2018-08-31 18:12 ` [PATCH 3/3] drm: rcar-du: Update framebuffer pitch and alignment limits for Gen3 Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9a443fa-729b-fad9-cb06-9a8d2d65b408@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=koji.matsuoka.xm@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).