linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: BUG: scripts/kconfig/merge_config.sh: typo in variable name
Date: Wed, 22 Mar 2023 09:57:36 +0100	[thread overview]
Message-ID: <40379213-6283-4ac7-b761-244df5537e56@alu.unizg.hr> (raw)
In-Reply-To: <CAK7LNARxu0hjOp6N7jnLWvqWb0h3LPPSAgF7+7+c-eB7Fmc9dA@mail.gmail.com>

On 3/22/23 04:40, Masahiro Yamada wrote:
> On Wed, Mar 22, 2023 at 5:14 AM Mirsad Goran Todorovac
> <mirsad.todorovac@alu.unizg.hr> wrote:
>>
>> On 3/21/2023 2:04 PM, Mirsad Goran Todorovac wrote:
>>> Hi all,
>>>
>>> There is a typo in variable name in scripts/kconfig/merge_config.sh, with the
>>> script returning:
>>>
>>> $ ./scripts/kconfig/merge_config.sh -y -m ../.config tools/testing/selftests/net/config
>>> ./scripts/kconfig/merge_config.sh: 148: ./scripts/kconfig/merge_config.sh: Previous: not found
>>>
>>> Problem is probably best explained by this diff:
>>>
>>> ---
>>> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
>>> index 32620de473ad..902eb429b9db 100755
>>> --- a/scripts/kconfig/merge_config.sh
>>> +++ b/scripts/kconfig/merge_config.sh
>>> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
>>>                   NEW_VAL=$(grep -w $CFG $MERGE_FILE)
>>>                   BUILTIN_FLAG=false
>>>                   if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
>>> -                       ${WARNOVVERIDE} Previous  value: $PREV_VAL
>>> +                       ${WARNOVERRIDE} Previous  value: $PREV_VAL
>>>                           ${WARNOVERRIDE} New value:       $NEW_VAL
>>>                           ${WARNOVERRIDE} -y passed, will not demote y to m
>>>                           ${WARNOVERRIDE}
>>>
>>> Hope this helps.
>>
>> P.S.
>>
>> Later I thought of searching the committer of the patch that introduced the change,
>> so I Cc:ed Mark.
>>
>> Best regards,
>> Mirsad
> 
> Good catch.

Thanks.

> Will you please send a patch with your signed-off?

Submitted. I hope I did it right this time.

Best regards,
Mirsad

-- 
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia

      reply	other threads:[~2023-03-22  8:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 13:04 BUG: scripts/kconfig/merge_config.sh: typo in variable name Mirsad Goran Todorovac
2023-03-21 20:13 ` Mirsad Goran Todorovac
2023-03-22  3:40   ` Masahiro Yamada
2023-03-22  8:57     ` Mirsad Todorovac [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40379213-6283-4ac7-b761-244df5537e56@alu.unizg.hr \
    --to=mirsad.todorovac@alu.unizg.hr \
    --cc=broonie@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).