From: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
To: linux-kbuild@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: BUG: scripts/kconfig/merge_config.sh: typo in variable name
Date: Tue, 21 Mar 2023 21:13:49 +0100 [thread overview]
Message-ID: <7349a16f-6e7e-51d4-4686-ec7e688d891b@alu.unizg.hr> (raw)
In-Reply-To: <17ab5a21-5512-5388-f9fa-c462b2ebd351@alu.unizg.hr>
On 3/21/2023 2:04 PM, Mirsad Goran Todorovac wrote:
> Hi all,
>
> There is a typo in variable name in scripts/kconfig/merge_config.sh, with the
> script returning:
>
> $ ./scripts/kconfig/merge_config.sh -y -m ../.config tools/testing/selftests/net/config
> ./scripts/kconfig/merge_config.sh: 148: ./scripts/kconfig/merge_config.sh: Previous: not found
>
> Problem is probably best explained by this diff:
>
> ---
> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
> index 32620de473ad..902eb429b9db 100755
> --- a/scripts/kconfig/merge_config.sh
> +++ b/scripts/kconfig/merge_config.sh
> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
> NEW_VAL=$(grep -w $CFG $MERGE_FILE)
> BUILTIN_FLAG=false
> if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
> - ${WARNOVVERIDE} Previous value: $PREV_VAL
> + ${WARNOVERRIDE} Previous value: $PREV_VAL
> ${WARNOVERRIDE} New value: $NEW_VAL
> ${WARNOVERRIDE} -y passed, will not demote y to m
> ${WARNOVERRIDE}
>
> Hope this helps.
P.S.
Later I thought of searching the committer of the patch that introduced the change,
so I Cc:ed Mark.
Best regards,
Mirsad
--
Mirsad Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
tel. +385 (0)1 3711 451
mob. +385 91 57 88 355
next prev parent reply other threads:[~2023-03-21 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 13:04 BUG: scripts/kconfig/merge_config.sh: typo in variable name Mirsad Goran Todorovac
2023-03-21 20:13 ` Mirsad Goran Todorovac [this message]
2023-03-22 3:40 ` Masahiro Yamada
2023-03-22 8:57 ` Mirsad Todorovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7349a16f-6e7e-51d4-4686-ec7e688d891b@alu.unizg.hr \
--to=mirsad.todorovac@alu.unizg.hr \
--cc=broonie@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).