[PATCH 1/1] ath5k: 5211, don't crypt every protected frame

[PATCH 1/1] ath5k: 5211, don't crypt every protected frame

[Jiri Slaby]

Hi guys,
do you remember some 5211 HW which didn't work with this?
--

Set null key type even on ar5211, otherwise it en/decrypts every frame with
protected bit set which renders the card unusable on encrypted networks.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Nick Kossifidis <mickflemm@gmail.com>
Cc: Luis R. Rodriguez <lrodriguez@atheros.com>
Cc: Bob Copeland <me@bobcopeland.com>
---
 drivers/net/wireless/ath/ath5k/pcu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireless/ath/ath5k/pcu.c
index 55122f1..5f07e87 100644
--- a/drivers/net/wireless/ath/ath5k/pcu.c
+++ b/drivers/net/wireless/ath/ath5k/pcu.c
@@ -1003,7 +1003,7 @@ int ath5k_hw_reset_key(struct ath5k_hw *ah, u16 entry)
 	 * Note2: Windows driver (ndiswrapper) sets this to
 	 *        0x00000714 instead of 0x00000007
 	 */
-	if (ah->ah_version > AR5K_AR5211) {
+	if (ah->ah_version >= AR5K_AR5211) {
 		ath5k_hw_reg_write(ah, AR5K_KEYTABLE_TYPE_NULL,
 				AR5K_KEYTABLE_TYPE(entry));
 
-- 
1.6.2.4

Re: [PATCH 1/1] ath5k: 5211, don't crypt every protected frame

[Bob Copeland]

On Sat, Apr 25, 2009 at 02:09:23PM +0200, Jiri Slaby wrote:
> Hi guys,
> do you remember some 5211 HW which didn't work with this?
> --
> 
> Set null key type even on ar5211, otherwise it en/decrypts every frame with
> protected bit set which renders the card unusable on encrypted networks.

Not me.  I don't have the hardware, so I would say if your patch is known
to work on a 5211 then we go with it.

-- 
Bob Copeland %% www.bobcopeland.com

Re: [PATCH 1/1] ath5k: 5211, don't crypt every protected frame

[Jiri Slaby]

On 04/26/2009 04:00 AM, Bob Copeland wrote:
> On Sat, Apr 25, 2009 at 02:09:23PM +0200, Jiri Slaby wrote:
>> Hi guys,
>> do you remember some 5211 HW which didn't work with this?
>> --
>>
>> Set null key type even on ar5211, otherwise it en/decrypts every frame with
>> protected bit set which renders the card unusable on encrypted networks.
> 
> Not me.  I don't have the hardware, so I would say if your patch is known
> to work on a 5211 then we go with it.

Ok, thanks. Of course the HW I used (IBM T40 Thinkpad) needs the patch ;).

Re: [PATCH 1/1] ath5k: 5211, don't crypt every protected frame

[Nick Kossifidis]

2009/4/26 Jiri Slaby <jirislaby@gmail.com>:
> On 04/26/2009 04:00 AM, Bob Copeland wrote:
>> On Sat, Apr 25, 2009 at 02:09:23PM +0200, Jiri Slaby wrote:
>>> Hi guys,
>>> do you remember some 5211 HW which didn't work with this?
>>> --
>>>
>>> Set null key type even on ar5211, otherwise it en/decrypts every frame with
>>> protected bit set which renders the card unusable on encrypted networks.
>>
>> Not me.  I don't have the hardware, so I would say if your patch is known
>> to work on a 5211 then we go with it.
>
> Ok, thanks. Of course the HW I used (IBM T40 Thinkpad) needs the patch ;).
>

Acked-by: Nick Kossifidis <mickflemm@gmail.com>

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick