linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Ziyuan Xu <xzy.xu@rock-chips.com>,
	ulf.hansson@linaro.org, robh+dt@kernel.org, heiko@sntech.de
Cc: shawn.lin@rock-chips.com, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 1/2] Documentation: mmc: sdhci-of-arasan: add description of power domain
Date: Sat, 27 Aug 2016 22:50:33 +0800	[thread overview]
Message-ID: <40f46bd6-22d2-f008-602a-47200340f733@rock-chips.com> (raw)
In-Reply-To: <20160827134103.28160-2-xzy.xu@rock-chips.com>

On 2016/8/27 21:41, Ziyuan Xu wrote:
> Add power domain as a optional property for sdhci-of-arasan, which can
> be truned off in the so-called unused condition, such as suspend and
> remove. Aim to lower power requirements.
>
> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
>
> ---
>
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index 3404afa..3f5189c 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -1,12 +1,14 @@
>  Device Tree Bindings for the Arasan SDHCI Controller
>
> -  The bindings follow the mmc[1], clock[2], interrupt[3] and phy[4] bindings.
> +  The bindings follow the mmc[1], clock[2], interrupt[3], phy[4] and power
> +  domain[5] bindings.
>    Only deviations are documented here.
>
>    [1] Documentation/devicetree/bindings/mmc/mmc.txt
>    [2] Documentation/devicetree/bindings/clock/clock-bindings.txt
>    [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
>    [4] Documentation/devicetree/bindings/phy/phy-bindings.txt
> +  [5] Documentation/devicetree/bindings/power/power_domain.txt
>
>  Required Properties:
>    - compatible: Compatibility string.  One of:
> @@ -36,6 +38,8 @@ Optional Properties:
>    - #clock-cells: If specified this should be the value <0>.  With this property
>      in place we will export a clock representing the Card Clock.  This clock
>      is expected to be consumed by our PHY.  You must also specify
> +  - power-domains: A phandle of and PM domain as specifier defined by bindings

	A phandle of what?

> +    of the power controller specified by phandle.
>
>  Example:
>  	sdhci@e0100000 {

It would be nice to add the example code.

>


-- 
Best Regards
Shawn Lin

  reply	other threads:[~2016-08-27 14:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-27 13:41 [PATCH 0/2] Add power domain support for eMMC node on rk3399 Ziyuan Xu
2016-08-27 13:41 ` [PATCH 1/2] Documentation: mmc: sdhci-of-arasan: add description of power domain Ziyuan Xu
2016-08-27 14:50   ` Shawn Lin [this message]
2016-08-29  0:36     ` Ziyuan Xu
2016-08-27 13:41 ` [PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399 Ziyuan Xu
2016-08-27 15:05   ` Shawn Lin
2016-08-29  1:58     ` Elaine Zhang
2016-08-29  2:50     ` Elaine Zhang
2016-08-29  3:25       ` Shawn Lin
2016-08-31 17:42         ` Doug Anderson
2016-09-01  2:29           ` Ziyuan Xu
2016-09-01  3:23             ` Shawn Lin
2016-09-01 13:45               ` Ulf Hansson
2016-09-01 21:50                 ` Doug Anderson
2016-09-02 10:24                   ` Ulf Hansson
2016-09-02 14:23                     ` Ziyuan Xu
2016-09-06 12:34                       ` Ulf Hansson
2016-09-01  4:20             ` Doug Anderson
2016-09-01  6:56               ` Ziyuan Xu
2016-09-01 21:29                 ` Doug Anderson
2016-09-02  2:35                   ` Ziyuan Xu
2016-09-02  5:22                     ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40f46bd6-22d2-f008-602a-47200340f733@rock-chips.com \
    --to=shawn.lin@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=xzy.xu@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).