linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Shawn Lin" <shawn.lin@rock-chips.com>,
	"Ziyuan Xu" <xzy.xu@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Xing Zheng" <zhengxing@rock-chips.com>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"Frank Wang" <frank.wang@rock-chips.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Elaine Zhang" <zhangqing@rock-chips.com>,
	"Will Deacon" <will.deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Brian Norris" <briannorris@chromium.org>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"David Wu" <david.wu@rock-chips.com>,
	"Caesar Wang" <wxt@rock-chips.com>,
	"Jianqun Xu" <jay.xu@rock-chips.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Shunqian Zheng" <zhengsq@rock-chips.com>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399
Date: Thu, 1 Sep 2016 14:50:56 -0700	[thread overview]
Message-ID: <CAD=FV=VQ7Gf33fH8=FM_Lj-r9uovoEHxusMrFQrDwf2rxeiecg@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFqwqdu=9PSzD32aOYAeBVRMQ0s8oKA29JGBsMsRMsDz4w@mail.gmail.com>

Hi,

On Thu, Sep 1, 2016 at 6:45 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> I was reading the discussion regarding this change and browsing the DT
> documentation around this... Can you guys explain what really goes on
> here, please.
>
> To me, it seems like you are managing one device's resources in one
> separate genpd. One genpd per device. Is that correct?
>
> Perhaps each device actually has its own PM domain and thus it makes
> sense to assign one genpd per device?

I'm not as familiar with genpd as I should be, so hopefully this makes sense.

...in hardware there is a "pd_emmc" that is the power domain for just
eMMC.  That will be referenced hooked up via device tree, like:

power-domains = <&power RK3399_PD_EMMC>;

I believe that means that power will automatically be removed whenever
the device is runtime suspended or suspended.

If w're not supporting "autosuspend" and nobody is tweaking anything
manually, then it's possible (I think) that runtime suspend happens at
exactly the same time as suspend.  ...but my point was that it was
cleaner to actually do it any restoring in the "runtime resume" hooks
to match what genpd does.  This matches what you say: use runtime PM.

...but it also sounds like it might not be terribly important to
restore these values since they're a bit silly to begin with.  If
that's true then I guess we don't need to do anything special here.


Did that all make sense (it's entirely possible it didn't since
somehow my brain still hasn't absorbed all runtime PM and genpd
concepts)

-Doug

  reply	other threads:[~2016-09-01 21:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-27 13:41 [PATCH 0/2] Add power domain support for eMMC node on rk3399 Ziyuan Xu
2016-08-27 13:41 ` [PATCH 1/2] Documentation: mmc: sdhci-of-arasan: add description of power domain Ziyuan Xu
2016-08-27 14:50   ` Shawn Lin
2016-08-29  0:36     ` Ziyuan Xu
2016-08-27 13:41 ` [PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399 Ziyuan Xu
2016-08-27 15:05   ` Shawn Lin
2016-08-29  1:58     ` Elaine Zhang
2016-08-29  2:50     ` Elaine Zhang
2016-08-29  3:25       ` Shawn Lin
2016-08-31 17:42         ` Doug Anderson
2016-09-01  2:29           ` Ziyuan Xu
2016-09-01  3:23             ` Shawn Lin
2016-09-01 13:45               ` Ulf Hansson
2016-09-01 21:50                 ` Doug Anderson [this message]
2016-09-02 10:24                   ` Ulf Hansson
2016-09-02 14:23                     ` Ziyuan Xu
2016-09-06 12:34                       ` Ulf Hansson
2016-09-01  4:20             ` Doug Anderson
2016-09-01  6:56               ` Ziyuan Xu
2016-09-01 21:29                 ` Doug Anderson
2016-09-02  2:35                   ` Ziyuan Xu
2016-09-02  5:22                     ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=VQ7Gf33fH8=FM_Lj-r9uovoEHxusMrFQrDwf2rxeiecg@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=briannorris@chromium.org \
    --cc=catalin.marinas@arm.com \
    --cc=david.wu@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frank.wang@rock-chips.com \
    --cc=heiko@sntech.de \
    --cc=jay.xu@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    --cc=will.deacon@arm.com \
    --cc=wxt@rock-chips.com \
    --cc=xzy.xu@rock-chips.com \
    --cc=yamada.masahiro@socionext.com \
    --cc=zhangqing@rock-chips.com \
    --cc=zhengsq@rock-chips.com \
    --cc=zhengxing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).