* [PATCH] usb: dwc2: remove set but unused variable
@ 2018-09-12 18:16 Josh Abraham
2018-09-13 6:36 ` Minas Harutyunyan
0 siblings, 1 reply; 4+ messages in thread
From: Josh Abraham @ 2018-09-12 18:16 UTC (permalink / raw)
To: hminas; +Cc: gregkh, linux-usb, kernel-janitors, linux-kernel
This patch removes a set but unused variable in hcd.c.
Fixes warning:
variable ‘data_fifo’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
---
drivers/usb/dwc2/hcd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 2bd6e6bfc241..5f23b933cafc 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -1328,14 +1328,11 @@ static void dwc2_hc_write_packet(struct dwc2_hsotg *hsotg,
u32 remaining_count;
u32 byte_count;
u32 dword_count;
- u32 __iomem *data_fifo;
u32 *data_buf = (u32 *)chan->xfer_buf;
if (dbg_hc(chan))
dev_vdbg(hsotg->dev, "%s()\n", __func__);
- data_fifo = (u32 __iomem *)(hsotg->regs + HCFIFO(chan->hc_num));
-
remaining_count = chan->xfer_len - chan->xfer_count;
if (remaining_count > chan->max_packet)
byte_count = chan->max_packet;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: dwc2: remove set but unused variable
2018-09-12 18:16 [PATCH] usb: dwc2: remove set but unused variable Josh Abraham
@ 2018-09-13 6:36 ` Minas Harutyunyan
0 siblings, 0 replies; 4+ messages in thread
From: Minas Harutyunyan @ 2018-09-13 6:36 UTC (permalink / raw)
To: Josh Abraham, Minas.Harutyunyan
Cc: gregkh, linux-usb, kernel-janitors, linux-kernel
On 9/12/2018 10:16 PM, Josh Abraham wrote:
> This patch removes a set but unused variable in hcd.c.
>
> Fixes warning:
> variable ‘data_fifo’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
> ---
> drivers/usb/dwc2/hcd.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 2bd6e6bfc241..5f23b933cafc 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -1328,14 +1328,11 @@ static void dwc2_hc_write_packet(struct dwc2_hsotg *hsotg,
> u32 remaining_count;
> u32 byte_count;
> u32 dword_count;
> - u32 __iomem *data_fifo;
> u32 *data_buf = (u32 *)chan->xfer_buf;
>
> if (dbg_hc(chan))
> dev_vdbg(hsotg->dev, "%s()\n", __func__);
>
> - data_fifo = (u32 __iomem *)(hsotg->regs + HCFIFO(chan->hc_num));
> -
> remaining_count = chan->xfer_len - chan->xfer_count;
> if (remaining_count > chan->max_packet)
> byte_count = chan->max_packet;
>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] usb: dwc2: remove set but unused variable
@ 2018-09-24 1:41 Josh Abraham
2018-09-24 5:48 ` Minas Harutyunyan
0 siblings, 1 reply; 4+ messages in thread
From: Josh Abraham @ 2018-09-24 1:41 UTC (permalink / raw)
To: hminas; +Cc: gregkh, linux-usb, linux-kernel, kernel-janitors, j.abraham1776
This patch removes a set but unused variable in hcd.c.
Fixes gcc warning:
variable ‘data_fifo’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
---
drivers/usb/dwc2/hcd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 2bd6e6bfc241..5f23b933cafc 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -1328,14 +1328,11 @@ static void dwc2_hc_write_packet(struct dwc2_hsotg *hsotg,
u32 remaining_count;
u32 byte_count;
u32 dword_count;
- u32 __iomem *data_fifo;
u32 *data_buf = (u32 *)chan->xfer_buf;
if (dbg_hc(chan))
dev_vdbg(hsotg->dev, "%s()\n", __func__);
- data_fifo = (u32 __iomem *)(hsotg->regs + HCFIFO(chan->hc_num));
-
remaining_count = chan->xfer_len - chan->xfer_count;
if (remaining_count > chan->max_packet)
byte_count = chan->max_packet;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: dwc2: remove set but unused variable
2018-09-24 1:41 Josh Abraham
@ 2018-09-24 5:48 ` Minas Harutyunyan
0 siblings, 0 replies; 4+ messages in thread
From: Minas Harutyunyan @ 2018-09-24 5:48 UTC (permalink / raw)
To: Josh Abraham, minas.harutyunyan
Cc: gregkh, linux-usb, linux-kernel, kernel-janitors
On 9/24/2018 5:41 AM, Josh Abraham wrote:
> This patch removes a set but unused variable in hcd.c.
>
> Fixes gcc warning:
> variable ‘data_fifo’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
> ---
> drivers/usb/dwc2/hcd.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 2bd6e6bfc241..5f23b933cafc 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -1328,14 +1328,11 @@ static void dwc2_hc_write_packet(struct dwc2_hsotg *hsotg,
> u32 remaining_count;
> u32 byte_count;
> u32 dword_count;
> - u32 __iomem *data_fifo;
> u32 *data_buf = (u32 *)chan->xfer_buf;
>
> if (dbg_hc(chan))
> dev_vdbg(hsotg->dev, "%s()\n", __func__);
>
> - data_fifo = (u32 __iomem *)(hsotg->regs + HCFIFO(chan->hc_num));
> -
> remaining_count = chan->xfer_len - chan->xfer_count;
> if (remaining_count > chan->max_packet)
> byte_count = chan->max_packet;
>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-24 5:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-12 18:16 [PATCH] usb: dwc2: remove set but unused variable Josh Abraham
2018-09-13 6:36 ` Minas Harutyunyan
2018-09-24 1:41 Josh Abraham
2018-09-24 5:48 ` Minas Harutyunyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).