From: Jens Axboe <axboe@kernel.dk>
To: Wen Yang <wenyang@linux.alibaba.com>
Cc: Joseph Qi <joseph.qi@linux.alibaba.com>,
xlpang@linux.alibaba.com, Mikulas Patocka <mpatocka@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] block: make the io_ticks counter more accurate
Date: Wed, 25 Dec 2019 20:39:31 -0700 [thread overview]
Message-ID: <41175786-8a02-62e0-fc79-955ec0e74aeb@kernel.dk> (raw)
In-Reply-To: <20191226031014.58970-1-wenyang@linux.alibaba.com>
On 12/25/19 8:10 PM, Wen Yang wrote:
> Instead of the jiffies, we should update the io_ticks counter
> with the passed in parameter 'now'.
I'm still missing some justification for this. What exactly is this
patch trying to solve or improve? Your commit message says "we should",
but why?
--
Jens Axboe
next prev parent reply other threads:[~2019-12-26 3:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 3:10 [PATCH v2] block: make the io_ticks counter more accurate Wen Yang
2019-12-26 3:39 ` Jens Axboe [this message]
2019-12-26 16:42 ` Wen Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41175786-8a02-62e0-fc79-955ec0e74aeb@kernel.dk \
--to=axboe@kernel.dk \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
--cc=wenyang@linux.alibaba.com \
--cc=xlpang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).