From: David Rientjes <rientjes@google.com>
To: Georgi Djakov <quic_c_gdjako@quicinc.com>
Cc: vbabka@suse.cz, akpm@linux-foundation.org,
iamjoonsoo.kim@lge.com, penberg@kernel.org, cl@linux.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
djakov@kernel.org
Subject: Re: [PATCH] mm/slub: Add taint after the errors are printed
Date: Fri, 18 Jun 2021 12:38:01 -0700 (PDT) [thread overview]
Message-ID: <413080c2-bfd7-f386-709c-43718242ae87@google.com> (raw)
In-Reply-To: <1623860738-146761-1-git-send-email-quic_c_gdjako@quicinc.com>
On Wed, 16 Jun 2021, Georgi Djakov wrote:
> When running the kernel with panic_on_taint, the usual slub debug error
> messages are not being printed when object corruption happens. That's
> because we panic in add_taint(), which is called before printing the
> additional information. This is a bit unfortunate as the error messages
> are actually very useful, especially before a panic. Let's fix this by
> moving add_taint() after the errors are printed on the console.
>
> Signed-off-by: Georgi Djakov <quic_c_gdjako@quicinc.com>
Acked-by: David Rientjes <rientjes@google.com>
prev parent reply other threads:[~2021-06-18 19:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 16:25 [PATCH] mm/slub: Add taint after the errors are printed Georgi Djakov
2021-06-16 16:34 ` Vlastimil Babka
2021-06-16 22:13 ` Rafael Aquini
2021-06-16 22:11 ` Rafael Aquini
2021-06-17 9:22 ` Aaron Tomlin
2021-06-17 14:07 ` Vlastimil Babka
2021-06-18 19:38 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413080c2-bfd7-f386-709c-43718242ae87@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=djakov@kernel.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=quic_c_gdjako@quicinc.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).