From: Rafael Aquini <aquini@redhat.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Georgi Djakov <quic_c_gdjako@quicinc.com>,
akpm@linux-foundation.org, iamjoonsoo.kim@lge.com,
rientjes@google.com, penberg@kernel.org, cl@linux.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
djakov@kernel.org
Subject: Re: [PATCH] mm/slub: Add taint after the errors are printed
Date: Wed, 16 Jun 2021 18:13:26 -0400 [thread overview]
Message-ID: <YMp3htJJkyVZJglK@optiplex-fbsd> (raw)
In-Reply-To: <4b22baf7-582b-f1ae-a525-046a493ec85f@suse.cz>
On Wed, Jun 16, 2021 at 06:34:41PM +0200, Vlastimil Babka wrote:
> On 6/16/21 6:25 PM, Georgi Djakov wrote:
> > When running the kernel with panic_on_taint, the usual slub debug error
> > messages are not being printed when object corruption happens. That's
> > because we panic in add_taint(), which is called before printing the
> > additional information. This is a bit unfortunate as the error messages
> > are actually very useful, especially before a panic. Let's fix this by
> > moving add_taint() after the errors are printed on the console.
> >
> > Signed-off-by: Georgi Djakov <quic_c_gdjako@quicinc.com>
>
> Makes sense.
>
> While at it, I wonder if we should use LOCKDEP_STILL_OK instead of
> LOCKDEP_NOW_UNRELIABLE. Isn't it too pessimistic to assume that some slab's
> memory corruption hit some lock state?
>
Given there is noted corruption I don't think it's safe to assume otherwise.
next prev parent reply other threads:[~2021-06-16 22:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 16:25 [PATCH] mm/slub: Add taint after the errors are printed Georgi Djakov
2021-06-16 16:34 ` Vlastimil Babka
2021-06-16 22:13 ` Rafael Aquini [this message]
2021-06-16 22:11 ` Rafael Aquini
2021-06-17 9:22 ` Aaron Tomlin
2021-06-17 14:07 ` Vlastimil Babka
2021-06-18 19:38 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMp3htJJkyVZJglK@optiplex-fbsd \
--to=aquini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=djakov@kernel.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=quic_c_gdjako@quicinc.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).