* [PATCH] slimbus: fix duplicated argument to ||
@ 2019-07-21 17:47 Hariprasad Kelam
2019-07-21 18:04 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2019-07-21 17:47 UTC (permalink / raw)
To: Srinivas Kandagatla, alsa-devel, linux-kernel
Remove duplicate argument SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION.
fix below issue reported by coccicheck
./drivers/slimbus/slimbus.h:440:3-46: duplicated argument to && or ||
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/slimbus/slimbus.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/slimbus/slimbus.h b/drivers/slimbus/slimbus.h
index 9be4108..46a6441 100644
--- a/drivers/slimbus/slimbus.h
+++ b/drivers/slimbus/slimbus.h
@@ -438,8 +438,7 @@ static inline bool slim_tid_txn(u8 mt, u8 mc)
return (mt == SLIM_MSG_MT_CORE &&
(mc == SLIM_MSG_MC_REQUEST_INFORMATION ||
mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION ||
- mc == SLIM_MSG_MC_REQUEST_VALUE ||
- mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION));
+ mc == SLIM_MSG_MC_REQUEST_VALUE));
}
static inline bool slim_ec_txn(u8 mt, u8 mc)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] slimbus: fix duplicated argument to ||
2019-07-21 17:47 [PATCH] slimbus: fix duplicated argument to || Hariprasad Kelam
@ 2019-07-21 18:04 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2019-07-21 18:04 UTC (permalink / raw)
To: Hariprasad Kelam, Srinivas Kandagatla, alsa-devel, linux-kernel
On Sun, 2019-07-21 at 23:17 +0530, Hariprasad Kelam wrote:
> Remove duplicate argument SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION.
>
> fix below issue reported by coccicheck
> ./drivers/slimbus/slimbus.h:440:3-46: duplicated argument to && or ||
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> drivers/slimbus/slimbus.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/slimbus/slimbus.h b/drivers/slimbus/slimbus.h
> index 9be4108..46a6441 100644
> --- a/drivers/slimbus/slimbus.h
> +++ b/drivers/slimbus/slimbus.h
> @@ -438,8 +438,7 @@ static inline bool slim_tid_txn(u8 mt, u8 mc)
> return (mt == SLIM_MSG_MT_CORE &&
> (mc == SLIM_MSG_MC_REQUEST_INFORMATION ||
> mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION ||
> - mc == SLIM_MSG_MC_REQUEST_VALUE ||
> - mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION));
> + mc == SLIM_MSG_MC_REQUEST_VALUE));
> }
Perhaps this was intended to be
mc == SLIM_MSG_MC_REQUEST_CHANGE_VALUE ?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-21 18:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-21 17:47 [PATCH] slimbus: fix duplicated argument to || Hariprasad Kelam
2019-07-21 18:04 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).