From: Patrick McHardy <kaber@trash.net>
To: Kirill Korotaev <dev@sw.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BUG?] dev_close() is called with locks held
Date: Fri, 19 Nov 2004 10:40:53 +0100 [thread overview]
Message-ID: <419DBFA5.8080602@trash.net> (raw)
In-Reply-To: <419DB6BA.5040901@sw.ru>
Kirill Korotaev wrote:
> Hello,
>
> looks like a bug in 2.4/2.6 kernels:
>
> 1. dev_close() function is blocking. it calls schedule() inside and
> calls blocking dev_deactivate() function.
>
> 2. But... call chain
> dev_ioctl() -> dev_ifsioc() -> dev_change_flags() calls dev_close()
> under read_lock(&dev_base_lock)...
>
> Bug?
dev_change_flags is only called for SIOCSIFFLAGS. dev_ioctl
takes the rtnl semaphore in this case, so no bug.
Regards
Patrick
prev parent reply other threads:[~2004-11-19 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 9:02 [BUG?] dev_close() is called with locks held Kirill Korotaev
2004-11-19 9:40 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419DBFA5.8080602@trash.net \
--to=kaber@trash.net \
--cc=dev@sw.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).