* [BUG?] dev_close() is called with locks held
@ 2004-11-19 9:02 Kirill Korotaev
2004-11-19 9:40 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Kirill Korotaev @ 2004-11-19 9:02 UTC (permalink / raw)
To: linux-kernel
Hello,
looks like a bug in 2.4/2.6 kernels:
1. dev_close() function is blocking. it calls schedule() inside and
calls blocking dev_deactivate() function.
2. But... call chain
dev_ioctl() -> dev_ifsioc() -> dev_change_flags() calls dev_close()
under read_lock(&dev_base_lock)...
Bug?
Kirill
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [BUG?] dev_close() is called with locks held
2004-11-19 9:02 [BUG?] dev_close() is called with locks held Kirill Korotaev
@ 2004-11-19 9:40 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2004-11-19 9:40 UTC (permalink / raw)
To: Kirill Korotaev; +Cc: linux-kernel
Kirill Korotaev wrote:
> Hello,
>
> looks like a bug in 2.4/2.6 kernels:
>
> 1. dev_close() function is blocking. it calls schedule() inside and
> calls blocking dev_deactivate() function.
>
> 2. But... call chain
> dev_ioctl() -> dev_ifsioc() -> dev_change_flags() calls dev_close()
> under read_lock(&dev_base_lock)...
>
> Bug?
dev_change_flags is only called for SIOCSIFFLAGS. dev_ioctl
takes the rtnl semaphore in this case, so no bug.
Regards
Patrick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-19 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-19 9:02 [BUG?] dev_close() is called with locks held Kirill Korotaev
2004-11-19 9:40 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).