* [2.6 patch] i386/x86_64 msr.c: make two functions static
@ 2004-12-06 0:41 Adrian Bunk
2004-12-06 3:53 ` H. Peter Anvin
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2004-12-06 0:41 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: linux-kernel, ak, discuss
The patch below makes two needlessly global functions static.
diffstat output:
arch/i386/kernel/msr.c | 4 ++--
arch/x86_64/kernel/msr.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm4-full/arch/i386/kernel/msr.c.old 2004-12-06 01:23:13.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/arch/i386/kernel/msr.c 2004-12-06 01:23:26.000000000 +0100
@@ -291,7 +291,7 @@
.notifier_call = msr_class_cpu_callback,
};
-int __init msr_init(void)
+static int __init msr_init(void)
{
int i, err = 0;
i = 0;
@@ -328,7 +328,7 @@
return err;
}
-void __exit msr_exit(void)
+static void __exit msr_exit(void)
{
int cpu = 0;
for_each_online_cpu(cpu)
--- linux-2.6.10-rc2-mm4-full/arch/x86_64/kernel/msr.c.old 2004-12-06 01:23:35.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/arch/x86_64/kernel/msr.c 2004-12-06 01:23:48.000000000 +0100
@@ -255,7 +255,7 @@
.open = msr_open,
};
-int __init msr_init(void)
+static int __init msr_init(void)
{
if (register_chrdev(MSR_MAJOR, "cpu/msr", &msr_fops)) {
printk(KERN_ERR "msr: unable to get major %d for msr\n",
@@ -266,7 +266,7 @@
return 0;
}
-void __exit msr_exit(void)
+static void __exit msr_exit(void)
{
unregister_chrdev(MSR_MAJOR, "cpu/msr");
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] i386/x86_64 msr.c: make two functions static
2004-12-06 0:41 [2.6 patch] i386/x86_64 msr.c: make two functions static Adrian Bunk
@ 2004-12-06 3:53 ` H. Peter Anvin
0 siblings, 0 replies; 2+ messages in thread
From: H. Peter Anvin @ 2004-12-06 3:53 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel, ak, discuss
Adrian Bunk wrote:
> The patch below makes two needlessly global functions static.
>
>
> diffstat output:
> arch/i386/kernel/msr.c | 4 ++--
> arch/x86_64/kernel/msr.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
Looks good to me.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-12-06 3:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-06 0:41 [2.6 patch] i386/x86_64 msr.c: make two functions static Adrian Bunk
2004-12-06 3:53 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).