* ide and ROMs
@ 2005-02-02 3:57 Jon Smirl
2005-02-03 22:05 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Jon Smirl @ 2005-02-02 3:57 UTC (permalink / raw)
To: Tejun Heo, lkml
Since it looks like ide is being worked on, can you convert ide to use
the PCI ROM access calls in drivers/pci/rom.c instead of directly
manipulating PCI config space? The new ROM calls work on all
architectures.
These are the places that need to be fix:
[jonsmirl@jonsmirl ide]$ grep -r PCI_ROM_ADDRESS_ENABLE *
pci/aec62xx.c: pci_write_config_dword(dev, PCI_ROM_ADDRESS,
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/cmd64x.c: pci_write_config_byte(dev, PCI_ROM_ADDRESS,
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/hpt34x.c:
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/hpt366.c: dev->resource[PCI_ROM_RESOURCE].start
| PCI_ROM_ADDRESS_ENABLE);
pci/pdc202xx_new.c:
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/pdc202xx_old.c:
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
[jonsmirl@jonsmirl ide]$
--
Jon Smirl
jonsmirl@gmail.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ide and ROMs
2005-02-02 3:57 ide and ROMs Jon Smirl
@ 2005-02-03 22:05 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2005-02-03 22:05 UTC (permalink / raw)
To: Jon Smirl; +Cc: lkml
Jon Smirl wrote:
> Since it looks like ide is being worked on, can you convert ide to use
> the PCI ROM access calls in drivers/pci/rom.c instead of directly
> manipulating PCI config space? The new ROM calls work on all
> architectures.
>
> These are the places that need to be fix:
> [jonsmirl@jonsmirl ide]$ grep -r PCI_ROM_ADDRESS_ENABLE *
> pci/aec62xx.c: pci_write_config_dword(dev, PCI_ROM_ADDRESS,
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> pci/cmd64x.c: pci_write_config_byte(dev, PCI_ROM_ADDRESS,
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> pci/hpt34x.c:
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> pci/hpt366.c: dev->resource[PCI_ROM_RESOURCE].start
> | PCI_ROM_ADDRESS_ENABLE);
> pci/pdc202xx_new.c:
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> pci/pdc202xx_old.c:
> dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
> [jonsmirl@jonsmirl ide]$
Sure, I'll look at it.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-02-03 22:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-02-02 3:57 ide and ROMs Jon Smirl
2005-02-03 22:05 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).