linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* initialize_acct_integrals
@ 2005-02-18 14:15 Jay Lan
  0 siblings, 0 replies; only message in thread
From: Jay Lan @ 2005-02-18 14:15 UTC (permalink / raw)
  To: LKML, Christoph Lameter; +Cc: Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

Hi Andrew,

The new "move-accounting-function-calls-out-of-critical-vm-code-paths"
patch in 2.6.11-rc3-mm2 was different from the code i tested.

In particular, it mistakenly dropped the accounting routine calls
in fs/exec.c. The calls in do_execve() are needed to properly
initialize accounting fields. Specifically, the tsk->acct_stimexpd
needs to be initialized to tsk->stime.

I have discussed this with Christoph Lameter and he gave me full
blessings to bring the calls back.

This initialize_acct_integrals patch was generated against
2.6.11-rc3-mm2 to fix the problem. Thanks!

Signed-off-by: Jay Lan <jlan@sgi.com>


[-- Attachment #2: initialize_acct_integrals --]
[-- Type: text/plain, Size: 421 bytes --]

Index: linux/fs/exec.c
===================================================================
--- linux.orig/fs/exec.c	2005-02-17 19:24:45.785343748 -0800
+++ linux/fs/exec.c	2005-02-18 05:45:19.868493728 -0800
@@ -1193,6 +1193,8 @@ int do_execve(char * filename,
 
 		/* execve success */
 		security_bprm_free(bprm);
+		acct_update_integrals(current);
+		update_mem_hiwater(current);
 		kfree(bprm);
 		return retval;
 	}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-02-18 14:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-02-18 14:15 initialize_acct_integrals Jay Lan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).