RE: [PATCH 1/1] mm: Export a function to read vm_committed_as

[KY Srinivasan <kys@microsoft.com>]

> -----Original Message-----
> From: Dan Magenheimer [mailto:dan.magenheimer@oracle.com]
> Sent: Monday, November 12, 2012 6:32 PM
> To: KY Srinivasan; David Rientjes; Konrad Wilk
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> andi@firstfloor.org; akpm@linux-foundation.org; linux-mm@kvack.org;
> kamezawa.hiroyuki@gmail.com; mhocko@suse.cz; hannes@cmpxchg.org;
> yinghan@google.com
> Subject: RE: [PATCH 1/1] mm: Export a function to read vm_committed_as
> 
> > From: KY Srinivasan [mailto:kys@microsoft.com]
> > Sent: Monday, November 12, 2012 3:58 PM
> > To: David Rientjes
> > Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org;
> > olaf@aepfle.de; apw@canonical.com; andi@firstfloor.org; akpm@linux-
> foundation.org; linux-mm@kvack.org;
> > kamezawa.hiroyuki@gmail.com; mhocko@suse.cz; hannes@cmpxchg.org;
> yinghan@google.com; Dan Magenheimer
> > Subject: RE: [PATCH 1/1] mm: Export a function to read vm_committed_as
> >
> > > -----Original Message-----
> > > From: David Rientjes [mailto:rientjes@google.com]
> > > Sent: Monday, November 12, 2012 4:54 PM
> > > To: KY Srinivasan
> > > Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> > > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> > > andi@firstfloor.org; akpm@linux-foundation.org; linux-mm@kvack.org;
> > > kamezawa.hiroyuki@gmail.com; mhocko@suse.cz; hannes@cmpxchg.org;
> > > yinghan@google.com
> > > Subject: RE: [PATCH 1/1] mm: Export a function to read vm_committed_as
> > >
> > > On Sun, 11 Nov 2012, KY Srinivasan wrote:
> > >
> > > > Thanks for the prompt response. For the Linux balloon driver for Hyper-V, I
> > > need access
> > > > to the metric that reflects the system wide memory commitment made by
> the
> > > guest kernel.
> > > > In the Hyper-V case, this information is one of the many metrics used to
> drive
> > > the policy engine
> > > > on the host. Granted, the interface name I have chosen here could be more
> > > generic; how about
> > > > read_mem_commit_info(void). I am open to suggestions here.
> > > >
> > >
> > > I would suggest vm_memory_committed() and there shouldn't be a
> comment
> > > describing that this is just a wrapper for modules to read
> > > vm_committed_as, that's apparent from the implementation: it should be
> > > describing exactly what this value represents and why it is a useful
> > > metric (at least in the case that you're concerned about).
> >
> > Will do; thanks.
> > >
> > > > With regards to making changes to the Xen self ballooning code, I would like
> to
> > > separate that patch
> > > > from the patch that implements the exported mechanism to access the
> > > memory commitment information.
> > >
> > > Why?  Is xen using it for a different inference?
> >
> > I think it is good to separate these patches. Dan (copied here) wrote the code
> for the
> > Xen self balloon driver. If it is ok with him I can submit the patch for Xen as well.
> 
> Hi KY --
> 
> If I understand correctly, this would be only a cosmetic (function renaming)
> change
> to the Xen selfballooning code.  If so, then I will be happy to Ack when I
> see the patch.  However, Konrad (konrad.wilk@oracle.com) is the maintainer
> for all Xen code so you should ask him... and (from previous painful experience)
> it can be difficult to sync even very simple interdependent changes going through
> different maintainers without breaking linux-next.  So I can't offer any
> help with that process, only commiseration. :-(
> 
> Dan
> 

Dan,

Thank you. I will send the patches out soon.

Regards,

K. Y