From: David Rientjes <rientjes@google.com>
To: KY Srinivasan <kys@microsoft.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
"andi@firstfloor.org" <andi@firstfloor.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"kamezawa.hiroyuki@gmail.com" <kamezawa.hiroyuki@gmail.com>,
"mhocko@suse.cz" <mhocko@suse.cz>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"yinghan@google.com" <yinghan@google.com>
Subject: RE: [PATCH 1/1] mm: Export a function to read vm_committed_as
Date: Mon, 12 Nov 2012 13:53:36 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1211121349130.23347@chino.kir.corp.google.com> (raw)
In-Reply-To: <426367E2313C2449837CD2DE46E7EAF930E35B45@SN2PRD0310MB382.namprd03.prod.outlook.com>
On Sun, 11 Nov 2012, KY Srinivasan wrote:
> Thanks for the prompt response. For the Linux balloon driver for Hyper-V, I need access
> to the metric that reflects the system wide memory commitment made by the guest kernel.
> In the Hyper-V case, this information is one of the many metrics used to drive the policy engine
> on the host. Granted, the interface name I have chosen here could be more generic; how about
> read_mem_commit_info(void). I am open to suggestions here.
>
I would suggest vm_memory_committed() and there shouldn't be a comment
describing that this is just a wrapper for modules to read
vm_committed_as, that's apparent from the implementation: it should be
describing exactly what this value represents and why it is a useful
metric (at least in the case that you're concerned about).
> With regards to making changes to the Xen self ballooning code, I would like to separate that patch
> from the patch that implements the exported mechanism to access the memory commitment information.
Why? Is xen using it for a different inference?
next prev parent reply other threads:[~2012-11-12 21:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 2:25 [PATCH 1/1] mm: Export a function to read vm_committed_as K. Y. Srinivasan
2012-11-11 2:35 ` David Rientjes
2012-11-11 9:24 ` KY Srinivasan
2012-11-12 21:53 ` David Rientjes [this message]
2012-11-12 22:58 ` KY Srinivasan
2012-11-12 23:32 ` Dan Magenheimer
2012-11-12 23:49 ` David Rientjes
2012-11-13 5:24 ` KY Srinivasan
2012-11-13 15:41 ` Dan Magenheimer
2012-11-13 21:04 ` David Rientjes
2012-11-13 5:16 ` KY Srinivasan
2012-11-12 21:36 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1211121349130.23347@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyuki@gmail.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=olaf@aepfle.de \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).