* fix ultrastor.c compile error
@ 2005-04-22 13:56 K.R. Foley
2005-04-22 17:29 ` Linus Torvalds
0 siblings, 1 reply; 3+ messages in thread
From: K.R. Foley @ 2005-04-22 13:56 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
This simple patch fixes a compile error in the ultrastor driver. Patch
was originally submitted by Barry K. Nathan as referenced here:
http://marc.theaimsgroup.com/?l=linux-kernel&m=111391774018717&w=2
I just regenerated it against your current git tree. Please apply.
--
kr
Signed-off-by: K.R. Foley <kr@cybsft.com>
[-- Attachment #2: ultrafix2.patch --]
[-- Type: text/x-patch, Size: 427 bytes --]
--- linux.test/drivers/scsi/ultrastor.c.orig 2005-04-22 08:38:06.000000000 -0500
+++ linux.test/drivers/scsi/ultrastor.c 2005-04-22 08:38:12.000000000 -0500
@@ -945,7 +945,7 @@
config.mscp[mscp_index].SCint, SCpnt);
#endif
if (config.mscp[mscp_index].SCint == 0)
- return FAILURE;
+ return FAILED;
if (config.mscp[mscp_index].SCint != SCpnt) panic("Bad abort");
config.mscp[mscp_index].SCint = NULL;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fix ultrastor.c compile error
2005-04-22 13:56 fix ultrastor.c compile error K.R. Foley
@ 2005-04-22 17:29 ` Linus Torvalds
2005-04-22 17:51 ` K.R. Foley
0 siblings, 1 reply; 3+ messages in thread
From: Linus Torvalds @ 2005-04-22 17:29 UTC (permalink / raw)
To: K.R. Foley; +Cc: linux-kernel
On Fri, 22 Apr 2005, K.R. Foley wrote:
>
> This simple patch fixes a compile error in the ultrastor driver. Patch
> was originally submitted by Barry K. Nathan as referenced here:
> http://marc.theaimsgroup.com/?l=linux-kernel&m=111391774018717&w=2
> I just regenerated it against your current git tree. Please apply.
Can you also verify that it works?
Finally, when forwarding other peoples patches, please make sure that you
include their commentary, and their sign-off. In this case the original
definitely has them..
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fix ultrastor.c compile error
2005-04-22 17:29 ` Linus Torvalds
@ 2005-04-22 17:51 ` K.R. Foley
0 siblings, 0 replies; 3+ messages in thread
From: K.R. Foley @ 2005-04-22 17:51 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel
Linus Torvalds wrote:
>
> On Fri, 22 Apr 2005, K.R. Foley wrote:
>
>>This simple patch fixes a compile error in the ultrastor driver. Patch
>>was originally submitted by Barry K. Nathan as referenced here:
>>http://marc.theaimsgroup.com/?l=linux-kernel&m=111391774018717&w=2
>>I just regenerated it against your current git tree. Please apply.
>
>
> Can you also verify that it works?
No. I can only verify that it compiles. I don't have the hardware.
Enabled by default in the config and it hadn't blown up before.
>
> Finally, when forwarding other peoples patches, please make sure that you
> include their commentary, and their sign-off. In this case the original
> definitely has them..
Will do.
>
> Linus
>
--
kr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-04-22 17:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-22 13:56 fix ultrastor.c compile error K.R. Foley
2005-04-22 17:29 ` Linus Torvalds
2005-04-22 17:51 ` K.R. Foley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).