* acpi=off and acpi_get_firmware_table
@ 2005-05-11 17:21 Corey Minyard
2005-05-12 2:54 ` Shaohua Li
0 siblings, 1 reply; 4+ messages in thread
From: Corey Minyard @ 2005-05-11 17:21 UTC (permalink / raw)
To: lkml
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
In 2.6.12-rc4, I added acpi=off to the kernel command line and it
panic-ed in acpi_get_firmware_table, called from the IPMI driver.
The attached patch fixes the problem, but it still spits out ugly
"ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the
patch is right, but maybe it points to something else.
Is it legal to call acpi_get_firmware_table if acpi is off? If not, how
can I tell that acpi is off?
-Corey
[-- Attachment #2: acpi_table_null_fix.patch --]
[-- Type: text/x-patch, Size: 528 bytes --]
Index: linux-2.6.12-rc4/drivers/acpi/tables/tbxfroot.c
===================================================================
--- linux-2.6.12-rc4.orig/drivers/acpi/tables/tbxfroot.c
+++ linux-2.6.12-rc4/drivers/acpi/tables/tbxfroot.c
@@ -313,7 +313,9 @@
cleanup:
- acpi_os_unmap_memory (rsdt_info->pointer, (acpi_size) rsdt_info->pointer->length);
+ if (rsdt_info->pointer)
+ acpi_os_unmap_memory (rsdt_info->pointer,
+ (acpi_size) rsdt_info->pointer->length);
ACPI_MEM_FREE (rsdt_info);
if (header) {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: acpi=off and acpi_get_firmware_table
2005-05-11 17:21 acpi=off and acpi_get_firmware_table Corey Minyard
@ 2005-05-12 2:54 ` Shaohua Li
2005-05-12 2:59 ` Corey Minyard
0 siblings, 1 reply; 4+ messages in thread
From: Shaohua Li @ 2005-05-12 2:54 UTC (permalink / raw)
To: Corey Minyard; +Cc: lkml
On Wed, 2005-05-11 at 12:21 -0500, Corey Minyard wrote:
> In 2.6.12-rc4, I added acpi=off to the kernel command line and it
> panic-ed in acpi_get_firmware_table, called from the IPMI driver.
>
> The attached patch fixes the problem, but it still spits out ugly
> "ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the
> patch is right, but maybe it points to something else.
>
> Is it legal to call acpi_get_firmware_table if acpi is off? If not, how
> can I tell that acpi is off?
Please check 'acpi_disabled' variable.
Thanks,
Shaohua
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: acpi=off and acpi_get_firmware_table
2005-05-12 2:54 ` Shaohua Li
@ 2005-05-12 2:59 ` Corey Minyard
2005-05-12 3:07 ` Shaohua Li
0 siblings, 1 reply; 4+ messages in thread
From: Corey Minyard @ 2005-05-12 2:59 UTC (permalink / raw)
To: Shaohua Li; +Cc: lkml
Shaohua Li wrote:
>On Wed, 2005-05-11 at 12:21 -0500, Corey Minyard wrote:
>
>
>>In 2.6.12-rc4, I added acpi=off to the kernel command line and it
>>panic-ed in acpi_get_firmware_table, called from the IPMI driver.
>>
>>The attached patch fixes the problem, but it still spits out ugly
>>"ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the
>>patch is right, but maybe it points to something else.
>>
>>Is it legal to call acpi_get_firmware_table if acpi is off? If not, how
>>can I tell that acpi is off?
>>
>>
>Please check 'acpi_disabled' variable.
>
>
acpi_disabled is not available on ia64. It doesn't seem to be a
standard interface. So that's not an option.
-Corey
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: acpi=off and acpi_get_firmware_table
2005-05-12 2:59 ` Corey Minyard
@ 2005-05-12 3:07 ` Shaohua Li
0 siblings, 0 replies; 4+ messages in thread
From: Shaohua Li @ 2005-05-12 3:07 UTC (permalink / raw)
To: Corey Minyard; +Cc: lkml
On Wed, 2005-05-11 at 21:59 -0500, Corey Minyard wrote:
> Shaohua Li wrote:
>
> >On Wed, 2005-05-11 at 12:21 -0500, Corey Minyard wrote:
> >
> >
> >>In 2.6.12-rc4, I added acpi=off to the kernel command line and it
> >>panic-ed in acpi_get_firmware_table, called from the IPMI driver.
> >>
> >>The attached patch fixes the problem, but it still spits out ugly
> >>"ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the
> >>patch is right, but maybe it points to something else.
> >>
> >>Is it legal to call acpi_get_firmware_table if acpi is off? If not, how
> >>can I tell that acpi is off?
> >>
> >>
> >Please check 'acpi_disabled' variable.
> >
> >
> acpi_disabled is not available on ia64. It doesn't seem to be a
> standard interface. So that's not an option.
It always return 0 in IA64. IA64 can't disable ACPI.
Thanks,
Shaohua
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-05-12 3:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-11 17:21 acpi=off and acpi_get_firmware_table Corey Minyard
2005-05-12 2:54 ` Shaohua Li
2005-05-12 2:59 ` Corey Minyard
2005-05-12 3:07 ` Shaohua Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).