* [PATCH v1] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes
@ 2023-06-05 19:15 Arseniy Krasnov
2023-06-07 21:18 ` Arseniy Krasnov
0 siblings, 1 reply; 4+ messages in thread
From: Arseniy Krasnov @ 2023-06-05 19:15 UTC (permalink / raw)
To: Liang Yang, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
Cc: oxffffaa, kernel, Arseniy Krasnov, linux-mtd, linux-arm-kernel,
linux-amlogic, linux-kernel
Both operations have no effect.
Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
---
drivers/mtd/nand/raw/meson_nand.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
index 074e14225c06..50d3110ad321 100644
--- a/drivers/mtd/nand/raw/meson_nand.c
+++ b/drivers/mtd/nand/raw/meson_nand.c
@@ -595,12 +595,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand,
cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN;
nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0;
- addrs[0] = cs | NFC_CMD_ALE | 0;
+ addrs[0] = cs | NFC_CMD_ALE;
if (mtd->writesize <= 512) {
cmd_num--;
row_start = 1;
} else {
- addrs[1] = cs | NFC_CMD_ALE | 0;
+ addrs[1] = cs | NFC_CMD_ALE;
row_start = 2;
}
--
2.35.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes
2023-06-05 19:15 [PATCH v1] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes Arseniy Krasnov
@ 2023-06-07 21:18 ` Arseniy Krasnov
2023-06-08 3:23 ` Liang Yang
0 siblings, 1 reply; 4+ messages in thread
From: Arseniy Krasnov @ 2023-06-07 21:18 UTC (permalink / raw)
To: Liang Yang, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
Cc: oxffffaa, kernel, linux-mtd, linux-arm-kernel, linux-amlogic,
linux-kernel
Hi again Miquel, Liang!
What do You think about this patch?
Thanks, Arseniy
On 05.06.2023 22:15, Arseniy Krasnov wrote:
> Both operations have no effect.
>
> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> ---
> drivers/mtd/nand/raw/meson_nand.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index 074e14225c06..50d3110ad321 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -595,12 +595,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand,
> cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN;
> nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0;
>
> - addrs[0] = cs | NFC_CMD_ALE | 0;
> + addrs[0] = cs | NFC_CMD_ALE;
> if (mtd->writesize <= 512) {
> cmd_num--;
> row_start = 1;
> } else {
> - addrs[1] = cs | NFC_CMD_ALE | 0;
> + addrs[1] = cs | NFC_CMD_ALE;
> row_start = 2;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes
2023-06-07 21:18 ` Arseniy Krasnov
@ 2023-06-08 3:23 ` Liang Yang
2023-06-08 4:37 ` Arseniy Krasnov
0 siblings, 1 reply; 4+ messages in thread
From: Liang Yang @ 2023-06-08 3:23 UTC (permalink / raw)
To: Arseniy Krasnov, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
Cc: oxffffaa, kernel, linux-mtd, linux-arm-kernel, linux-amlogic,
linux-kernel
On 2023/6/8 5:18, Arseniy Krasnov wrote:
> [ EXTERNAL EMAIL ]
>
> Hi again Miquel, Liang!
>
> What do You think about this patch?
>
> Thanks, Arseniy
>
> On 05.06.2023 22:15, Arseniy Krasnov wrote:
>> Both operations have no effect.
>>
>> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
>> ---
>> drivers/mtd/nand/raw/meson_nand.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
>> index 074e14225c06..50d3110ad321 100644
>> --- a/drivers/mtd/nand/raw/meson_nand.c
>> +++ b/drivers/mtd/nand/raw/meson_nand.c
>> @@ -595,12 +595,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand,
>> cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN;
>> nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0;
>>
>> - addrs[0] = cs | NFC_CMD_ALE | 0;
>> + addrs[0] = cs | NFC_CMD_ALE;
>> if (mtd->writesize <= 512) {
>> cmd_num--;
>> row_start = 1;
>> } else {
>> - addrs[1] = cs | NFC_CMD_ALE | 0;
>> + addrs[1] = cs | NFC_CMD_ALE;
>> row_start = 2;
>> }
Hi Arseniy and Miquel,
The two zeros indcates two column address. maybe we could use the micro
"COLUMN_ADDR_0" and "COLUMN_ADDR_1" to keep the nfc command format "CE |
ALE | addr" consistency and also let function
"meson_nfc_rw_cmd_prepare_and_execute" be more readable.
Thanks,
Liang
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes
2023-06-08 3:23 ` Liang Yang
@ 2023-06-08 4:37 ` Arseniy Krasnov
0 siblings, 0 replies; 4+ messages in thread
From: Arseniy Krasnov @ 2023-06-08 4:37 UTC (permalink / raw)
To: Liang Yang, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
Cc: oxffffaa, kernel, linux-mtd, linux-arm-kernel, linux-amlogic,
linux-kernel
On 08.06.2023 06:23, Liang Yang wrote:
>
>
> On 2023/6/8 5:18, Arseniy Krasnov wrote:
>> [ EXTERNAL EMAIL ]
>>
>> Hi again Miquel, Liang!
>>
>> What do You think about this patch?
>>
>> Thanks, Arseniy
>>
>> On 05.06.2023 22:15, Arseniy Krasnov wrote:
>>> Both operations have no effect.
>>>
>>> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
>>> ---
>>> drivers/mtd/nand/raw/meson_nand.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
>>> index 074e14225c06..50d3110ad321 100644
>>> --- a/drivers/mtd/nand/raw/meson_nand.c
>>> +++ b/drivers/mtd/nand/raw/meson_nand.c
>>> @@ -595,12 +595,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand,
>>> cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN;
>>> nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0;
>>>
>>> - addrs[0] = cs | NFC_CMD_ALE | 0;
>>> + addrs[0] = cs | NFC_CMD_ALE;
>>> if (mtd->writesize <= 512) {
>>> cmd_num--;
>>> row_start = 1;
>>> } else {
>>> - addrs[1] = cs | NFC_CMD_ALE | 0;
>>> + addrs[1] = cs | NFC_CMD_ALE;
>>> row_start = 2;
>>> }
> Hi Arseniy and Miquel,
>
> The two zeros indcates two column address. maybe we could use the micro "COLUMN_ADDR_0" and "COLUMN_ADDR_1" to keep the nfc command format "CE | ALE | addr" consistency and also let function "meson_nfc_rw_cmd_prepare_and_execute" be more readable.
Liang, done in v2:)
Thanks, Arseniy
>
> Thanks,
> Liang
>
>>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-08 4:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-05 19:15 [PATCH v1] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes Arseniy Krasnov
2023-06-07 21:18 ` Arseniy Krasnov
2023-06-08 3:23 ` Liang Yang
2023-06-08 4:37 ` Arseniy Krasnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).