* [PATCH v1 0/6] add support for MT8195 VPPSYS on MMSYS and MUTEX
@ 2022-10-04 9:33 Moudy Ho
[not found] ` <20221004093319.5069-5-moudy.ho@mediatek.com>
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Moudy Ho @ 2022-10-04 9:33 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
AngeloGioacchino Del Regno, Chun-Kuang Hu
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Moudy Ho
Hi,
This series add support for MT8195's two VPPSYS(Video Processor Pipe Subsystem),
under which there will be corresponding MMSYS and MUTEX settings that
need to be configured.
Roy-CW.Yeh (6):
dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS
dts: arm64: mt8195: add MMSYS and MUTEX configuration for VPPSYS
soc: mediatek: mmsys: add support for MT8195 VPPSYS
soc: mediatek: mmsys: add config api for RSZ switching and DCM
soc: mediatek: mutex: Add mtk_mutex_set_mod support to set MOD1
soc: mediatek: mutex: support MT8195 VPPSYS
.../bindings/soc/mediatek/mediatek,mutex.yaml | 1 +
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 22 ++-
drivers/soc/mediatek/mt8195-mmsys.h | 8 ++
drivers/soc/mediatek/mtk-mmsys.c | 60 +++++++-
drivers/soc/mediatek/mtk-mmsys.h | 1 +
drivers/soc/mediatek/mtk-mutex.c | 129 ++++++++++++++++--
include/linux/soc/mediatek/mtk-mmsys.h | 4 +
include/linux/soc/mediatek/mtk-mutex.h | 36 +++++
8 files changed, 250 insertions(+), 11 deletions(-)
--
2.18.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 2/6] dts: arm64: mt8195: add MMSYS and MUTEX configuration for VPPSYS
[not found] ` <20221004093319.5069-3-moudy.ho@mediatek.com>
@ 2022-10-04 11:46 ` Allen-KH Cheng (程冠勳)
2022-10-05 1:53 ` moudy ho
2022-10-05 7:57 ` Krzysztof Kozlowski
1 sibling, 1 reply; 8+ messages in thread
From: Allen-KH Cheng (程冠勳) @ 2022-10-04 11:46 UTC (permalink / raw)
To: matthias.bgg, chunkuang.hu, angelogioacchino.delregno,
Moudy Ho (何宗原),
robh+dt, krzysztof.kozlowski+dt
Cc: linux-arm-kernel, linux-kernel, linux-mediatek,
Roy-CW Yeh (葉中瑋),
devicetree, Project_Global_Chrome_Upstream_Group
Hi Moudy,
On Tue, 2022-10-04 at 17:33 +0800, Moudy Ho wrote:
> From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com>
>
> Compatible names of VPPSYS0 and VPPSYS1 should be renamed to
> "mediatek,mt8195-mmsys" to match the description of the binding file.
> Also, add two nodes for MT8195 VPPSYS0/1 MUTEX.
>
> Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index 905d1a90b406..7f54fa7d0185 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1477,11 +1477,20 @@
> };
>
> vppsys0: clock-controller@14000000 {
> - compatible = "mediatek,mt8195-vppsys0";
> + compatible = "mediatek,mt8195-mmsys";
> reg = <0 0x14000000 0 0x1000>;
> + mediatek,gce-client-reg = <&gce1
> SUBSYS_1400XXXX 0 0x1000>;
> #clock-cells = <1>;
> };
>
I run "ARCH=arm64 make dtbs check" and some of the tests failed.
The node name should be 'syscon' from mediatek/mediatek,mmsys.yaml.
> + vpp0-mutex@1400f000 {
> + compatible = "mediatek,mt8195-vpp-mutex";
> + reg = <0 0x1400f000 0 0x1000>;
> + mediatek,gce-client-reg = <&gce1
> SUBSYS_1400XXXX 0xf000 0x1000>;
> + clocks = <&vppsys0 CLK_VPP0_MUTEX>;
> + power-domains = <&spm
> MT8195_POWER_DOMAIN_VPPSYS0>;
> + };
> +
'interrupts' is a required property from mediatek/mediatek,mutex.yaml
> smi_sub_common_vpp0_vpp1_2x1: smi@14010000 {
> compatible = "mediatek,mt8195-smi-sub-common";
> reg = <0 0x14010000 0 0x1000>;
> @@ -1582,11 +1591,20 @@
> };
>
> vppsys1: clock-controller@14f00000 {
> - compatible = "mediatek,mt8195-vppsys1";
> + compatible = "mediatek,mt8195-mmsys";
> reg = <0 0x14f00000 0 0x1000>;
> + mediatek,gce-client-reg = <&gce1
> SUBSYS_14f0XXXX 0 0x1000>;
Node name: syscon.
> #clock-cells = <1>;
> };
>
> + vpp1-mutex@14f01000 {
> + compatible = "mediatek,mt8195-vpp-mutex";
> + reg = <0 0x14f01000 0 0x1000>;
> + mediatek,gce-client-reg = <&gce1
> SUBSYS_14f0XXXX 0x1000 0x1000>;
> + clocks = <&vppsys1 CLK_VPP1_DISP_MUTEX>;
> + power-domains = <&spm
> MT8195_POWER_DOMAIN_VPPSYS1>;
> + };
> +
'interrupts' is a required property
Thanks,
Allen
> larb5: larb@14f02000 {
> compatible = "mediatek,mt8195-smi-larb";
> reg = <0 0x14f02000 0 0x1000>;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 4/6] soc: mediatek: mmsys: add config api for RSZ switching and DCM
[not found] ` <20221004093319.5069-5-moudy.ho@mediatek.com>
@ 2022-10-04 12:17 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-04 12:17 UTC (permalink / raw)
To: Moudy Ho, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Chun-Kuang Hu
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Roy-CW.Yeh
Il 04/10/22 11:33, Moudy Ho ha scritto:
> From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com>
>
> Due to MT8195 HW design, some RSZs have additional settings that
> need to be configured in MMSYS.
>
> Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com>
Hello Moudy,
please remember that you have to add your Signed-off-by tag to all of the commits
that you're sending, even if you're not the author, otherwise they are not
acceptable.
> ---
> drivers/soc/mediatek/mt8195-mmsys.h | 8 ++++++
> drivers/soc/mediatek/mtk-mmsys.c | 40 ++++++++++++++++++++++++++
> include/linux/soc/mediatek/mtk-mmsys.h | 4 +++
> 3 files changed, 52 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mt8195-mmsys.h b/drivers/soc/mediatek/mt8195-mmsys.h
> index abfe94a30248..e0cf13d09763 100644
> --- a/drivers/soc/mediatek/mt8195-mmsys.h
> +++ b/drivers/soc/mediatek/mt8195-mmsys.h
> @@ -75,6 +75,14 @@
> #define MT8195_SOUT_DSC_WRAP1_OUT_TO_SINA_VIRTUAL0 (2 << 16)
> #define MT8195_SOUT_DSC_WRAP1_OUT_TO_VPP_MERGE (3 << 16)
>
> +/* VPPSYS1 */
> +#define MT8195_SVPP1_HW_DCM_1ST_DIS0 0x150
> +#define MT8195_SVPP1_HW_DCM_1ST_DIS1 0x160
> +#define MT8195_SVPP1_HW_DCM_2ND_DIS0 0x1a0
> +#define MT8195_SVPP1_HW_DCM_2ND_DIS1 0x1b0
> +#define MT8195_SVPP2_BUF_BF_RSZ_SWITCH 0xf48
> +#define MT8195_SVPP3_BUF_BF_RSZ_SWITCH 0xf74
> +
> static const struct mtk_mmsys_routes mmsys_mt8195_routing_table[] = {
> {
> DDP_COMPONENT_OVL0, DDP_COMPONENT_RDMA0,
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index c4d15f99f853..c98cfcb7db38 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -261,6 +261,46 @@ void mtk_mmsys_ddp_dpi_fmt_config(struct device *dev, u32 val)
> }
> EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_dpi_fmt_config);
>
> +void mtk_mmsys_merge_config(struct device *dev, u32 id, bool enable)
void mtk_mmsys_merge_config(struct device *dev, u32 svpp_id, bool enable)
or
void mtk_mmsys_vpp_merge_config(struct device *dev, u32 id, bool enable)
...adding that "svpp" or "vpp" word makes the function easier to understand :-)
> +{
> + u32 reg;
> +
> + switch (id) {
> + case 2:
> + reg = MT8195_SVPP2_BUF_BF_RSZ_SWITCH;
> + break;
> + case 3:
> + reg = MT8195_SVPP3_BUF_BF_RSZ_SWITCH;
> + break;
> + default:
> + dev_err(dev, "Invalid id %d\n", id);
> + return;
> + }
> +
> + mtk_mmsys_update_bits(dev_get_drvdata(dev), reg, ~0, enable);
> +}
> +EXPORT_SYMBOL_GPL(mtk_mmsys_merge_config);
> +
> +void mtk_mmsys_rsz_dcm_config(struct device *dev, bool enable)
...would be the same here, but only about the function name, so I'd go with
changing the name for both.
> +{
> + u32 val = 0;
> +
> + if (enable)
> + val = BIT(25);
No magic bits please, add a definition for them
> + mtk_mmsys_update_bits(dev_get_drvdata(dev),
> + MT8195_SVPP1_HW_DCM_1ST_DIS0, BIT(25), val);
> + mtk_mmsys_update_bits(dev_get_drvdata(dev),
> + MT8195_SVPP1_HW_DCM_2ND_DIS0, BIT(25), val);
> +
> + if (enable)
> + val = (BIT(4) | BIT(5));
same here
> + mtk_mmsys_update_bits(dev_get_drvdata(dev),
> + MT8195_SVPP1_HW_DCM_1ST_DIS1, (BIT(4) | BIT(5)), val);
> + mtk_mmsys_update_bits(dev_get_drvdata(dev),
> + MT8195_SVPP1_HW_DCM_2ND_DIS1, (BIT(4) | BIT(5)), val);
> +}
> +EXPORT_SYMBOL_GPL(mtk_mmsys_rsz_dcm_config);
> +
> static int mtk_mmsys_reset_update(struct reset_controller_dev *rcdev, unsigned long id,
> bool assert)
> {
> diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
> index d2b02bb43768..2d5c7fe920b0 100644
> --- a/include/linux/soc/mediatek/mtk-mmsys.h
> +++ b/include/linux/soc/mediatek/mtk-mmsys.h
> @@ -67,4 +67,8 @@ void mtk_mmsys_ddp_disconnect(struct device *dev,
>
> void mtk_mmsys_ddp_dpi_fmt_config(struct device *dev, u32 val);
>
> +void mtk_mmsys_merge_config(struct device *dev, u32 id, bool enable);
> +
> +void mtk_mmsys_rsz_dcm_config(struct device *dev, bool enable);
> +
> #endif /* __MTK_MMSYS_H */
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 3/6] soc: mediatek: mmsys: add support for MT8195 VPPSYS
[not found] ` <20221004093319.5069-4-moudy.ho@mediatek.com>
@ 2022-10-04 12:17 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-04 12:17 UTC (permalink / raw)
To: Moudy Ho, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Chun-Kuang Hu
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Roy-CW.Yeh
Il 04/10/22 11:33, Moudy Ho ha scritto:
> From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com>
>
> Add MT8195 VPPSYS0 and VPPSYS1 driver data.
>
> Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-mmsys.c | 20 +++++++++++++++++++-
> drivers/soc/mediatek/mtk-mmsys.h | 1 +
> 2 files changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index d2c7a87aab87..c4d15f99f853 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -149,11 +149,25 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = {
> .clk_driver = "clk-mt8195-vdo1",
> };
>
> +static const struct mtk_mmsys_driver_data mt8195_vppsys0_driver_data = {
> + .io_start = 0x14000000,
> + .clk_driver = "clk-mt8195-vpp0",
> + .is_copies = true,
> +};
> +
> +static const struct mtk_mmsys_driver_data mt8195_vppsys1_driver_data = {
> + .io_start = 0x14f00000,
> + .clk_driver = "clk-mt8195-vpp1",
> + .is_copies = true,
> +};
> +
> static const struct mtk_mmsys_match_data mt8195_mmsys_match_data = {
> - .num_drv_data = 2,
> + .num_drv_data = 4,
After a long discussion, it was chosen to not use the io_start way, but to change
the devicetree compatible....
Check this series, and rebase on top of it:
https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097
Cheers,
Angelo
> .drv_data = {
> &mt8195_vdosys0_driver_data,
> &mt8195_vdosys1_driver_data,
> + &mt8195_vppsys0_driver_data,
> + &mt8195_vppsys1_driver_data,
> },
> };
>
> @@ -360,6 +374,9 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
> if (IS_ERR(clks))
> return PTR_ERR(clks);
>
> + if (mmsys->data->is_copies)
I don't get what "is_copies" means, sorry. I'm sure that there's a better name
for this one.
> + goto out_probe_done;
> +
> drm = platform_device_register_data(&pdev->dev, "mediatek-drm",
> PLATFORM_DEVID_AUTO, NULL, 0);
> if (IS_ERR(drm)) {
Regards,
Angelo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 5/6] soc: mediatek: mutex: Add mtk_mutex_set_mod support to set MOD1
[not found] ` <20221004093319.5069-6-moudy.ho@mediatek.com>
@ 2022-10-04 12:38 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-04 12:38 UTC (permalink / raw)
To: Moudy Ho, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Chun-Kuang Hu
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Roy-CW.Yeh
Il 04/10/22 11:33, Moudy Ho ha scritto:
> From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com>
>
> Add mtk_mutex_set_mod support to set MOD1
>
> Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-mutex.c | 27 +++++++++++++++++++--------
> 1 file changed, 19 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
> index c1a33d52038e..5dcbd61fe42c 100644
> --- a/drivers/soc/mediatek/mtk-mutex.c
> +++ b/drivers/soc/mediatek/mtk-mutex.c
> @@ -23,6 +23,7 @@
> #define DISP_REG_MUTEX(n) (0x24 + 0x20 * (n))
> #define DISP_REG_MUTEX_RST(n) (0x28 + 0x20 * (n))
> #define DISP_REG_MUTEX_MOD(mutex_mod_reg, n) (mutex_mod_reg + 0x20 * (n))
> +#define DISP_REG_MUTEX_MOD1(mutex_mod_reg, n) ((mutex_mod_reg) + 0x20 * (n) + 0x4)
> #define DISP_REG_MUTEX_SOF(mutex_sof_reg, n) (mutex_sof_reg + 0x20 * (n))
> #define DISP_REG_MUTEX_MOD2(n) (0x34 + 0x20 * (n))
>
> @@ -750,14 +751,24 @@ int mtk_mutex_write_mod(struct mtk_mutex *mutex,
> return -EINVAL;
> }
>
> - offset = DISP_REG_MUTEX_MOD(mtx->data->mutex_mod_reg,
> - mutex->id);
> - reg = readl_relaxed(mtx->regs + offset);
> -
> - if (clear)
> - reg &= ~BIT(mtx->data->mutex_table_mod[idx]);
> - else
> - reg |= BIT(mtx->data->mutex_table_mod[idx]);
> + if (mtx->data->mutex_table_mod[idx] < 32) {
What if we do...
u8 id_offset = 0;
/*
* Some SoCs may have multiple MUTEX_MOD registers as more than 32 mods
* are present, hence requiring multiple 32-bits registers.
*
* The mutex_table_mod fully represents that by defining the number of
* the mod sequentially, later used as a bit number, which can be more
* than 0..31.
*
* In order to retain compatibility with older SoCs, we perform R/W on
* the single 32 bits registers, but this requires us to translate the
* mutex ID bit accordingly.
*/
if (mtx->data->mutex_table_mod[idx] < 32) {
reg_offset = DISP_REG_MUTEX_MOD0(mtx->data->mutex_mod_reg,
mutex->id);
} else {
reg_offset = DISP_REG_MUTEX_MOD1(mtx->data->mutex_mod_reg,
mutex->id);
id_offset = 32;
}
reg = readl_relaxed(mtx->regs + offset);
if (clear)
reg &= ~BIT(mtx->data->mutex_table_mod[idx] - id_offset);
else
reg |= BIT(mtx->data->mutex_table_mod[idx] - id_offset);
writel_relaxed(reg, mtx->regs + offset);
...like this, we give good documentation and also keep the code "short" :-)
Regards,
Angelo
> + offset = DISP_REG_MUTEX_MOD(mtx->data->mutex_mod_reg,
> + mutex->id);
> + reg = readl_relaxed(mtx->regs + offset);
> + if (clear)
> + reg &= ~BIT(mtx->data->mutex_table_mod[idx]);
> + else
> + reg |= BIT(mtx->data->mutex_table_mod[idx]);
> +
> + } else {
> + offset = DISP_REG_MUTEX_MOD1(mtx->data->mutex_mod_reg,
> + mutex->id);
> + reg = readl_relaxed(mtx->regs + offset);
> + if (clear)
> + reg &= ~BIT(mtx->data->mutex_table_mod[idx] - 32);
> + else
> + reg |= BIT(mtx->data->mutex_table_mod[idx] - 32);
> + }
>
> writel_relaxed(reg, mtx->regs + offset);
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 2/6] dts: arm64: mt8195: add MMSYS and MUTEX configuration for VPPSYS
2022-10-04 11:46 ` [PATCH v1 2/6] dts: arm64: mt8195: add MMSYS and MUTEX configuration for VPPSYS Allen-KH Cheng (程冠勳)
@ 2022-10-05 1:53 ` moudy ho
0 siblings, 0 replies; 8+ messages in thread
From: moudy ho @ 2022-10-05 1:53 UTC (permalink / raw)
To: Allen-KH Cheng (程冠勳),
matthias.bgg, chunkuang.hu, angelogioacchino.delregno, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-kernel, linux-kernel, linux-mediatek,
Roy-CW Yeh (葉中瑋),
devicetree, Project_Global_Chrome_Upstream_Group
On Tue, 2022-10-04 at 19:46 +0800, Allen-KH Cheng (程冠勳) wrote:
> Hi Moudy,
>
> On Tue, 2022-10-04 at 17:33 +0800, Moudy Ho wrote:
> > From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com>
> >
> > Compatible names of VPPSYS0 and VPPSYS1 should be renamed to
> > "mediatek,mt8195-mmsys" to match the description of the binding
> > file.
> > Also, add two nodes for MT8195 VPPSYS0/1 MUTEX.
> >
> > Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 22
> > ++++++++++++++++++++--
> > 1 file changed, 20 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > index 905d1a90b406..7f54fa7d0185 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > @@ -1477,11 +1477,20 @@
> > };
> >
> > vppsys0: clock-controller@14000000 {
> > - compatible = "mediatek,mt8195-vppsys0";
> > + compatible = "mediatek,mt8195-mmsys";
> > reg = <0 0x14000000 0 0x1000>;
> > + mediatek,gce-client-reg = <&gce1
> > SUBSYS_1400XXXX 0 0x1000>;
> > #clock-cells = <1>;
> > };
> >
>
> I run "ARCH=arm64 make dtbs check" and some of the tests failed.
>
> The node name should be 'syscon' from mediatek/mediatek,mmsys.yaml.
>
>
> > + vpp0-mutex@1400f000 {
> > + compatible = "mediatek,mt8195-vpp-mutex";
> > + reg = <0 0x1400f000 0 0x1000>;
> > + mediatek,gce-client-reg = <&gce1
> > SUBSYS_1400XXXX 0xf000 0x1000>;
> > + clocks = <&vppsys0 CLK_VPP0_MUTEX>;
> > + power-domains = <&spm
> > MT8195_POWER_DOMAIN_VPPSYS0>;
> > + };
> > +
>
> 'interrupts' is a required property from mediatek/mediatek,mutex.yaml
>
>
> > smi_sub_common_vpp0_vpp1_2x1: smi@14010000 {
> > compatible = "mediatek,mt8195-smi-sub-common";
> > reg = <0 0x14010000 0 0x1000>;
> > @@ -1582,11 +1591,20 @@
> > };
> >
> > vppsys1: clock-controller@14f00000 {
> > - compatible = "mediatek,mt8195-vppsys1";
> > + compatible = "mediatek,mt8195-mmsys";
> > reg = <0 0x14f00000 0 0x1000>;
> > + mediatek,gce-client-reg = <&gce1
> > SUBSYS_14f0XXXX 0 0x1000>;
>
> Node name: syscon.
>
> > #clock-cells = <1>;
> > };
> >
> > + vpp1-mutex@14f01000 {
> > + compatible = "mediatek,mt8195-vpp-mutex";
> > + reg = <0 0x14f01000 0 0x1000>;
> > + mediatek,gce-client-reg = <&gce1
> > SUBSYS_14f0XXXX 0x1000 0x1000>;
> > + clocks = <&vppsys1 CLK_VPP1_DISP_MUTEX>;
> > + power-domains = <&spm
> > MT8195_POWER_DOMAIN_VPPSYS1>;
> > + };
> > +
>
> 'interrupts' is a required property
>
> Thanks,
> Allen
>
Hi Allen,
Apologies for the failed test, I'll check again by adding dtsb_check
instead of just dt_binding_check .
Thanks & Regards,
Moudy
> > larb5: larb@14f02000 {
> > compatible = "mediatek,mt8195-smi-larb";
> > reg = <0 0x14f02000 0 0x1000>;
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 2/6] dts: arm64: mt8195: add MMSYS and MUTEX configuration for VPPSYS
[not found] ` <20221004093319.5069-3-moudy.ho@mediatek.com>
2022-10-04 11:46 ` [PATCH v1 2/6] dts: arm64: mt8195: add MMSYS and MUTEX configuration for VPPSYS Allen-KH Cheng (程冠勳)
@ 2022-10-05 7:57 ` Krzysztof Kozlowski
1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-05 7:57 UTC (permalink / raw)
To: Moudy Ho, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
AngeloGioacchino Del Regno, Chun-Kuang Hu
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Roy-CW.Yeh
On 04/10/2022 11:33, Moudy Ho wrote:
> From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com>
>
> Compatible names of VPPSYS0 and VPPSYS1 should be renamed to
> "mediatek,mt8195-mmsys" to match the description of the binding file.
> Also, add two nodes for MT8195 VPPSYS0/1 MUTEX.
>
> Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index 905d1a90b406..7f54fa7d0185 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1477,11 +1477,20 @@
> };
>
> vppsys0: clock-controller@14000000 {
> - compatible = "mediatek,mt8195-vppsys0";
> + compatible = "mediatek,mt8195-mmsys";
This does not look like matching bindings. Last patch for bindings was
requiring this to be prepended with vdosys0 and followed with syscon.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/6] dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS
[not found] ` <20221004093319.5069-2-moudy.ho@mediatek.com>
@ 2022-10-05 7:58 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-05 7:58 UTC (permalink / raw)
To: Moudy Ho, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
AngeloGioacchino Del Regno, Chun-Kuang Hu
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Roy-CW.Yeh
On 04/10/2022 11:33, Moudy Ho wrote:
> From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com>
>
> Add compatible for MT8195 VPPSYS.
>
> Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com>
Missing SoB.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-10-05 7:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 9:33 [PATCH v1 0/6] add support for MT8195 VPPSYS on MMSYS and MUTEX Moudy Ho
[not found] ` <20221004093319.5069-5-moudy.ho@mediatek.com>
2022-10-04 12:17 ` [PATCH v1 4/6] soc: mediatek: mmsys: add config api for RSZ switching and DCM AngeloGioacchino Del Regno
[not found] ` <20221004093319.5069-4-moudy.ho@mediatek.com>
2022-10-04 12:17 ` [PATCH v1 3/6] soc: mediatek: mmsys: add support for MT8195 VPPSYS AngeloGioacchino Del Regno
[not found] ` <20221004093319.5069-6-moudy.ho@mediatek.com>
2022-10-04 12:38 ` [PATCH v1 5/6] soc: mediatek: mutex: Add mtk_mutex_set_mod support to set MOD1 AngeloGioacchino Del Regno
[not found] ` <20221004093319.5069-3-moudy.ho@mediatek.com>
2022-10-04 11:46 ` [PATCH v1 2/6] dts: arm64: mt8195: add MMSYS and MUTEX configuration for VPPSYS Allen-KH Cheng (程冠勳)
2022-10-05 1:53 ` moudy ho
2022-10-05 7:57 ` Krzysztof Kozlowski
[not found] ` <20221004093319.5069-2-moudy.ho@mediatek.com>
2022-10-05 7:58 ` [PATCH v1 1/6] dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).