From: Joe Perches <joe@perches.com>
To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"trix@redhat.com" <trix@redhat.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>
Cc: linux-power <linux-power@fi.rohmeurope.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"apw@canonical.com" <apw@canonical.com>
Subject: Re: [PATCH] gpio: bd70528: remove unneeded break
Date: Wed, 21 Oct 2020 07:39:33 -0700 [thread overview]
Message-ID: <42c1d07d46655f622c081f45b68ccaffba7361a1.camel@perches.com> (raw)
In-Reply-To: <db6856d5431aac3ff56cd3817312d204c41cf7d0.camel@fi.rohmeurope.com>
On Wed, 2020-10-21 at 07:25 +0000, Vaittinen, Matti wrote:
> Hello Joe & All,
> On Tue, 2020-10-20 at 11:36 -0700, Joe Perches wrote:
> > On Tue, 2020-10-20 at 11:48 +0000, Vaittinen, Matti wrote:
[]
> > > And for peeps who have not been following - following function
> > > triggers the checkpatch error above:
> >
> > Huh? what version of checkpatch are you using?
> > Send it to me please.
[]
> Please find my version of checkpatch and the patch to trigger the
> warning attached.
Thanks. This test wasn't particularly useful
(and had some false positives) and was removed by
commit ef3c005c0eb07a60949191bc6ee407d5f43cc502
Author: Joe Perches <joe@perches.com>
Date: Tue Aug 11 18:35:19 2020 -0700
checkpatch: remove missing switch/case break test
This test doesn't work well and newer compilers are much better
at emitting this warning.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Cambda Zhu <cambda@linux.alibaba.com>
Link: http://lkml.kernel.org/r/7e25090c79f6a69d502ab8219863300790192fe2.camel@perches.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
next prev parent reply other threads:[~2020-10-21 14:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 19:33 [PATCH] gpio: bd70528: remove unneeded break trix
2020-10-20 10:08 ` Vaittinen, Matti
2020-10-20 11:46 ` Andy Shevchenko
2020-10-20 11:50 ` Vaittinen, Matti
2020-10-20 11:48 ` Vaittinen, Matti
2020-10-20 18:36 ` Joe Perches
2020-10-21 7:25 ` Vaittinen, Matti
2020-10-21 14:39 ` Joe Perches [this message]
2020-10-22 9:23 ` Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42c1d07d46655f622c081f45b68ccaffba7361a1.camel@perches.com \
--to=joe@perches.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=apw@canonical.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).