From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Cc: "bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"trix@redhat.com" <trix@redhat.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
linux-power <linux-power@fi.rohmeurope.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: bd70528: remove unneeded break
Date: Tue, 20 Oct 2020 14:46:38 +0300 [thread overview]
Message-ID: <CAHp75VdxXw0_W+MytA72sBfYT6nr=xHc+tTsTp7GPLnR9EgOVg@mail.gmail.com> (raw)
In-Reply-To: <5b13773306265f89366b86afba71d2b4a4130e2b.camel@fi.rohmeurope.com>
On Tue, Oct 20, 2020 at 2:26 PM Vaittinen, Matti
<Matti.Vaittinen@fi.rohmeurope.com> wrote:
> On Mon, 2020-10-19 at 12:33 -0700, trix@redhat.com wrote:
> > - break;
> My personal taste is also to omit these breaks but I am pretty sure I
> saw some tooling issuing a warning about falling through the switch-
> case back when I wrote this. Most probably checkpatch didn't like that
> back then. Anyways - if you have no warnings from any of the tools -
> this indeed looks better (to me) without the break :)
JFYI: it's a clang which actually *is* complaining for an extra break.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-20 11:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 19:33 [PATCH] gpio: bd70528: remove unneeded break trix
2020-10-20 10:08 ` Vaittinen, Matti
2020-10-20 11:46 ` Andy Shevchenko [this message]
2020-10-20 11:50 ` Vaittinen, Matti
2020-10-20 11:48 ` Vaittinen, Matti
2020-10-20 18:36 ` Joe Perches
2020-10-21 7:25 ` Vaittinen, Matti
2020-10-21 14:39 ` Joe Perches
2020-10-22 9:23 ` Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdxXw0_W+MytA72sBfYT6nr=xHc+tTsTp7GPLnR9EgOVg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).