* Re: [PATCH] tee: optee: remove need_resched() before cond_resched()
[not found] ` <CAHUa44GsbxO=wJ_o-AZsxNvKOhn=y=dexkrN17zCy=7+0=1ZQg@mail.gmail.com>
@ 2021-01-31 8:13 ` Rouven Czerwinski
2021-02-01 5:02 ` Sumit Garg
2021-02-03 7:10 ` Jens Wiklander
2 siblings, 0 replies; 5+ messages in thread
From: Rouven Czerwinski @ 2021-01-31 8:13 UTC (permalink / raw)
To: Jens Wiklander, Sumit Garg
Cc: Arnd Bergmann, op-tee, Linux Kernel Mailing List
Hi Jens,
On 29.01.21 14:29, Jens Wiklander wrote:
> Hi Rouven and Sumit,
>
> On Mon, Jan 25, 2021 at 10:58 AM Jens Wiklander via OP-TEE
> <op-tee@lists.trustedfirmware.org> wrote:
>>
>> Hi Rouven and Sumit,
>>
>> On Mon, Jan 25, 2021 at 10:55 AM Jens Wiklander
>> <jens.wiklander@linaro.org> wrote:
>>>
>>> Testing need_resched() before cond_resched() is not needed as an
>>> equivalent test is done internally in cond_resched(). So drop the
>>> need_resched() test.
>>>
>>> Fixes: dcb3b06d9c34 ("tee: optee: replace might_sleep with cond_resched")
>>> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
>>> ---
>>> drivers/tee/optee/call.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> Can you please test to see that this works in your setups too?
>
> Does this work for you? I'd like to get this patch ready for v5.12.
Yes it does. I also looked at it right after Arnds mail, so for future
reference:
cond_resched()
_cond_resched() (ifndef CONFIG_PREEMPTION)
should_resched(0)
tif_need_resched() (+ preempt_count == 0 for current thread)
while:
need_resched()
tif_need_resched()
You can add my
Reviewed-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
I also retested on the STM32-DK2 and the problem remains fixed:
Tested-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Regrads and thanks for the patch,
Rouven
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tee: optee: remove need_resched() before cond_resched()
[not found] ` <CAHUa44GsbxO=wJ_o-AZsxNvKOhn=y=dexkrN17zCy=7+0=1ZQg@mail.gmail.com>
2021-01-31 8:13 ` Rouven Czerwinski
@ 2021-02-01 5:02 ` Sumit Garg
2021-02-03 7:10 ` Jens Wiklander
2 siblings, 0 replies; 5+ messages in thread
From: Sumit Garg @ 2021-02-01 5:02 UTC (permalink / raw)
To: Jens Wiklander
Cc: Rouven Czerwinski, Arnd Bergmann, op-tee, Linux Kernel Mailing List
Hi Jens,
On Fri, 29 Jan 2021 at 18:59, Jens Wiklander <jens.wiklander@linaro.org> wrote:
>
> Hi Rouven and Sumit,
>
> On Mon, Jan 25, 2021 at 10:58 AM Jens Wiklander via OP-TEE
> <op-tee@lists.trustedfirmware.org> wrote:
> >
> > Hi Rouven and Sumit,
> >
> > On Mon, Jan 25, 2021 at 10:55 AM Jens Wiklander
> > <jens.wiklander@linaro.org> wrote:
> > >
> > > Testing need_resched() before cond_resched() is not needed as an
> > > equivalent test is done internally in cond_resched(). So drop the
> > > need_resched() test.
> > >
> > > Fixes: dcb3b06d9c34 ("tee: optee: replace might_sleep with cond_resched")
> > > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
> > > ---
> > > drivers/tee/optee/call.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Can you please test to see that this works in your setups too?
>
> Does this work for you? I'd like to get this patch ready for v5.12.
It does work for me as well.
Tested-by: Sumit Garg <sumit.garg@linaro.org>
-Sumit
>
> Thanks,
> Jens
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tee: optee: remove need_resched() before cond_resched()
[not found] ` <CAHUa44GsbxO=wJ_o-AZsxNvKOhn=y=dexkrN17zCy=7+0=1ZQg@mail.gmail.com>
2021-01-31 8:13 ` Rouven Czerwinski
2021-02-01 5:02 ` Sumit Garg
@ 2021-02-03 7:10 ` Jens Wiklander
2 siblings, 0 replies; 5+ messages in thread
From: Jens Wiklander @ 2021-02-03 7:10 UTC (permalink / raw)
To: Rouven Czerwinski, Sumit Garg
Cc: Arnd Bergmann, op-tee, Linux Kernel Mailing List
On Fri, Jan 29, 2021 at 02:29:33PM +0100, Jens Wiklander wrote:
> Hi Rouven and Sumit,
>
> On Mon, Jan 25, 2021 at 10:58 AM Jens Wiklander via OP-TEE
> <op-tee@lists.trustedfirmware.org> wrote:
> >
> > Hi Rouven and Sumit,
> >
> > On Mon, Jan 25, 2021 at 10:55 AM Jens Wiklander
> > <jens.wiklander@linaro.org> wrote:
> > >
> > > Testing need_resched() before cond_resched() is not needed as an
> > > equivalent test is done internally in cond_resched(). So drop the
> > > need_resched() test.
> > >
> > > Fixes: dcb3b06d9c34 ("tee: optee: replace might_sleep with cond_resched")
> > > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
> > > ---
> > > drivers/tee/optee/call.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Can you please test to see that this works in your setups too?
>
> Does this work for you? I'd like to get this patch ready for v5.12.
Thanks for the help with this patch. I'll submit this up for v5.12.
Cheers,
Jens
^ permalink raw reply [flat|nested] 5+ messages in thread