* [PATCH 2.6.14-rc1] Fix broken NVIDIA device ID in sata_nv
@ 2005-09-19 13:17 Andy Currid
2005-09-22 2:36 ` Jeff Garzik
2005-09-22 2:52 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Andy Currid @ 2005-09-19 13:17 UTC (permalink / raw)
To: linux-kernel
Please apply this patch that corrects an NVIDIA SATA device ID in
2.6.14-rc1.
Thanks
Andy
--
Signed-off-by: Andy Currid <acurrid@nvidia.com>
diff -upr linux-2.6.14-rc1/drivers/scsi/sata_nv.c
linux-2.6.14-rc1devel/drivers/scsi/sata_nv.c
--- linux-2.6.14-rc1/drivers/scsi/sata_nv.c 2005-09-16
18:48:18.000000000 -0700
+++ linux-2.6.14-rc1devel/drivers/scsi/sata_nv.c 2005-09-16
18:49:38.000000000 -0700
@@ -158,6 +158,8 @@ static struct pci_device_id nv_pci_tbl[]
PCI_ANY_ID, PCI_ANY_ID, 0, 0, MCP51 },
{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, MCP55 },
+ { PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA2,
+ PCI_ANY_ID, PCI_ANY_ID, 0, 0, MCP55 },
{ PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID,
PCI_ANY_ID, PCI_ANY_ID,
PCI_CLASS_STORAGE_IDE<<8, 0xffff00, GENERIC },
diff -upr linux-2.6.14-rc1/include/linux/pci_ids.h
linux-2.6.14-rc1devel/include/linux/pci_ids.h
--- linux-2.6.14-rc1/include/linux/pci_ids.h 2005-09-16
18:48:20.000000000 -0700
+++ linux-2.6.14-rc1devel/include/linux/pci_ids.h 2005-09-16
18:49:18.000000000 -0700
@@ -1249,7 +1249,8 @@
#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SATA 0x0266
#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SATA2 0x0267
#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_IDE 0x036E
-#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA 0x036F
+#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA 0x037E
+#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA2 0x037F
#define PCI_DEVICE_ID_NVIDIA_NVENET_12 0x0268
#define PCI_DEVICE_ID_NVIDIA_NVENET_13 0x0269
#define PCI_DEVICE_ID_NVIDIA_MCP51_AUDIO 0x026B
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.14-rc1] Fix broken NVIDIA device ID in sata_nv
2005-09-19 13:17 [PATCH 2.6.14-rc1] Fix broken NVIDIA device ID in sata_nv Andy Currid
@ 2005-09-22 2:36 ` Jeff Garzik
2005-09-22 2:52 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2005-09-22 2:36 UTC (permalink / raw)
To: Andy Currid; +Cc: linux-kernel
Andy Currid wrote:
> Please apply this patch that corrects an NVIDIA SATA device ID in
> 2.6.14-rc1.
> @@ -158,6 +158,8 @@ static struct pci_device_id nv_pci_tbl[]
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, MCP51 },
> { PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, MCP55 },
> + { PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA2,
> + PCI_ANY_ID, PCI_ANY_ID, 0, 0, MCP55 },
> { PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID,
> PCI_ANY_ID, PCI_ANY_ID,
> PCI_CLASS_STORAGE_IDE<<8, 0xffff00, GENERIC },
I am applying this patch, but note that it does not "fix" anything. It
simply adds a new PCI ID, for additional hardware support.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.14-rc1] Fix broken NVIDIA device ID in sata_nv
2005-09-19 13:17 [PATCH 2.6.14-rc1] Fix broken NVIDIA device ID in sata_nv Andy Currid
2005-09-22 2:36 ` Jeff Garzik
@ 2005-09-22 2:52 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2005-09-22 2:52 UTC (permalink / raw)
To: Andy Currid; +Cc: linux-kernel
also, your patch was word-wrapped by your mailer...
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 2.6.14-rc1] Fix broken NVIDIA device ID in sata_nv
@ 2005-09-22 4:28 Andy Currid
0 siblings, 0 replies; 4+ messages in thread
From: Andy Currid @ 2005-09-22 4:28 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel
Jeff
It fixes something if you apply the entire patch that I posted. I
changed the #defines for MCP55_SATA and MCP55_SATA2 in pci_ids.h.
The patch didn't appear word-wrapped in what I saw get reflected back to
me from LKML. Andrew Morton accepted it without comment.
Let me now if you want me to resubmit.
Thanks
Andy
> -----Original Message-----
> From: Jeff Garzik [mailto:jgarzik@pobox.com]
> Sent: Wednesday, September 21, 2005 19:37
> To: Andy Currid
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2.6.14-rc1] Fix broken NVIDIA device ID in sata_nv
>
> Andy Currid wrote:
> > Please apply this patch that corrects an NVIDIA SATA device ID in
> > 2.6.14-rc1.
>
> > @@ -158,6 +158,8 @@ static struct pci_device_id nv_pci_tbl[]
> > PCI_ANY_ID, PCI_ANY_ID, 0, 0, MCP51 },
> > { PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA,
> > PCI_ANY_ID, PCI_ANY_ID, 0, 0, MCP55 },
> > + { PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA2,
> > + PCI_ANY_ID, PCI_ANY_ID, 0, 0, MCP55 },
> > { PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID,
> > PCI_ANY_ID, PCI_ANY_ID,
> > PCI_CLASS_STORAGE_IDE<<8, 0xffff00, GENERIC },
>
> I am applying this patch, but note that it does not "fix"
> anything. It
> simply adds a new PCI ID, for additional hardware support.
>
> Jeff
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-09-22 4:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-09-19 13:17 [PATCH 2.6.14-rc1] Fix broken NVIDIA device ID in sata_nv Andy Currid
2005-09-22 2:36 ` Jeff Garzik
2005-09-22 2:52 ` Jeff Garzik
2005-09-22 4:28 Andy Currid
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).