Re: SPI

[Eric Piel <Eric.Piel@tremplin-utc.net>]

09/26/2005 01:12 PM, dmitry pervushin wrote/a écrit:
> Hello guys,
> 
> I am attaching the next incarnation of SPI core; feel free to comment it.
Hello,

Very little comments...


> Index: linux-2.6.10/drivers/spi/Kconfig
> ===================================================================
> --- /dev/null
> +++ linux-2.6.10/drivers/spi/Kconfig
> @@ -0,0 +1,33 @@
> +#
> +# SPI device configuration
> +#
> +menu "SPI support"
> +
> +config SPI
> +	default Y
> +	tristate "SPI support"
> +        default false
> +	help
> +	  Say Y if you need to enable SPI support on your kernel
SPI is far from being well know, please put more help. At least define 
SPI as "Serial Peripheral Interface" and suggest the user to have a look 
at Documentation/spi.txt . IMHO, it's also convenient if you give the 
name of the module that will be created (spi?).


> Index: linux-2.6.10/Documentation/spi.txt
> ===================================================================
> --- /dev/null
> +++ linux-2.6.10/Documentation/spi.txt
:
:
> +
> +1. What is SPI ?
> +----------------
> +SPI stands for "Serial Peripheral Interface", a full-duplex synchronous 
> +serial interface for connecting low-/medium-bandwidth external devices 
> +using four wires. SPI devices communicate using a master/slave relation-
> +ship over two data lines and two control lines:
> +- Master Out Slave In (MOSI): supplies the output data from the master 
> +  to the inputs of the slaves;
> +- Master In Slave Out (MISO): supplies the output data from a slave to 
> +  the input of the master. It is important to note that there can be no 
> +  more than one slave that is transmitting data during any particular 
> +  transfer;
> +- Serial Clock (SCLK): a control line driven by the master, regulating 
> +  the flow of data bits;
> +- Slave Select (SS): a control line that allows slaves to be turned on 
> +  and off with  hardware control.
> +More information is also available at http://en.wikipedia.org/wiki/Serial_Peripheral_Interface/ .
Broken link, it is 
http://en.wikipedia.org/wiki/Serial_Peripheral_Interface (no trailing /)


Cheers,
Eric