* [kernel-2.6.15] Fix PCI irq mapping for lite5200
@ 2006-01-12 8:34 Andrey Volkov
2006-01-12 9:48 ` Sylvain Munaut
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Volkov @ 2006-01-12 8:34 UTC (permalink / raw)
To: Sylvain Munaut; +Cc: ML linuxppc-embedded, LKML
[-- Attachment #1: Type: text/plain, Size: 151 bytes --]
Hi Sylvain,
This patch fix problem of PCI boards irq mapping on lite5200
(raised after your changes of MPC52xx_IRQ0 number)
--
Regards
Andrey Volkov
[-- Attachment #2: 01-lite5200_map_irq-fix.diff --]
[-- Type: text/plain, Size: 678 bytes --]
lite5200_map_irq: Fix irq mapping for external PCI boards
Signed-off-by: Andrey Volkov <avolkov@varma-el.com>
---
arch/ppc/platforms/lite5200.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/ppc/platforms/lite5200.c b/arch/ppc/platforms/lite5200.c
index 7ed52dc..cd4acb3 100644
--- a/arch/ppc/platforms/lite5200.c
+++ b/arch/ppc/platforms/lite5200.c
@@ -73,7 +73,8 @@ lite5200_show_cpuinfo(struct seq_file *m
static int
lite5200_map_irq(struct pci_dev *dev, unsigned char idsel, unsigned char pin)
{
- return (pin == 1) && (idsel==24) ? MPC52xx_IRQ0 : -1;
+ /* Only INTA supported */
+ return (pin == 1) ? MPC52xx_IRQ0 : -1;
}
#endif
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [kernel-2.6.15] Fix PCI irq mapping for lite5200
2006-01-12 8:34 [kernel-2.6.15] Fix PCI irq mapping for lite5200 Andrey Volkov
@ 2006-01-12 9:48 ` Sylvain Munaut
0 siblings, 0 replies; 2+ messages in thread
From: Sylvain Munaut @ 2006-01-12 9:48 UTC (permalink / raw)
To: Andrey Volkov; +Cc: ML linuxppc-embedded, LKML
Hi Andrey,
Andrey Volkov wrote:
> Hi Sylvain,
>
> This patch fix problem of PCI boards irq mapping on lite5200
What problem is that patch supposed to fix ?
The Lite5200 has a single PCI port, assigned to idsel 24 (afair) and its
INTA is connected to the IRQ0 pin of the 5200 so that looks correct to me.
> (raised after your changes of MPC52xx_IRQ0 number)
I'm not sure I get this either.
Do you mean that change provoked the bug you're talking about or that
before that change the bug was there but just not visible because masked
by the interrupt number being 0 problem ?
Sylvain
>
> --
> Regards
> Andrey Volkov
>
>
> ------------------------------------------------------------------------
>
> lite5200_map_irq: Fix irq mapping for external PCI boards
>
> Signed-off-by: Andrey Volkov <avolkov@varma-el.com>
> ---
>
> arch/ppc/platforms/lite5200.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/ppc/platforms/lite5200.c b/arch/ppc/platforms/lite5200.c
> index 7ed52dc..cd4acb3 100644
> --- a/arch/ppc/platforms/lite5200.c
> +++ b/arch/ppc/platforms/lite5200.c
> @@ -73,7 +73,8 @@ lite5200_show_cpuinfo(struct seq_file *m
> static int
> lite5200_map_irq(struct pci_dev *dev, unsigned char idsel, unsigned char pin)
> {
> - return (pin == 1) && (idsel==24) ? MPC52xx_IRQ0 : -1;
> + /* Only INTA supported */
> + return (pin == 1) ? MPC52xx_IRQ0 : -1;
> }
> #endif
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-12 9:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-12 8:34 [kernel-2.6.15] Fix PCI irq mapping for lite5200 Andrey Volkov
2006-01-12 9:48 ` Sylvain Munaut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).