[KORG] GITWEB doesn't show any DIFF's

[KORG] GITWEB doesn't show any DIFF's

[Michael Krufky]

To Whom (and ALL) that it may concern:

For the past week or so, I haven't been able to get gitweb, running on 
kernel.org, to show me any diff's.

For each commit, if I click on the "commit" link, or "commitdiff" link, 
the best I get is something that looks like this:

file:fd8bc718f0e33df0a446d3d5c67f68929eca6490 
<http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;h=fd8bc718f0e33df0a446d3d5c67f68929eca6490;hb=e0ad8486266c3415ab9c17f5c03c47edc7b93d7b;f=drivers/media/video/cx88/cx88-alsa.c> 
-> file:e649f678d47ab0a749b89146867ff9b1f513f73a 
<http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;h=e649f678d47ab0a749b89146867ff9b1f513f73a;hb=e0ad8486266c3415ab9c17f5c03c47edc7b93d7b;f=drivers/media/video/cx88/cx88-alsa.c>

This is for "V4L/DVB (3375): git dvb callbacks fix" , but it happens for 
every patch I try to view...  Even if I try to view the patch in "plan" 
mode, the following is all that I can see:

From: Andrew Morton <akpm@osdl.org>
Date: Sun, 15 Jan 2006 08:45:20 +0000 (-0200)
Subject: V4L/DVB (3375): git dvb callbacks fix
X-Git-Tag: v2.6.16-rc1
X-Git-Url: http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e0ad8486266c3415ab9c17f5c03c47edc7b93d7b

V4L/DVB (3375): git dvb callbacks fix

- Not sure what went wrong here, but SND_PCI_PM_CALLBACKS got deleted.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

(I havent seen this patch, and I'm really curious what happens in it, 
and the explanation of the commit message -- these questions are 
probably answered simply by viewing the patch, which I cant do :-(  )

... I have tried this at multiple locations, using several different 
browsers under different OS's ... It won't show me a diff no matter what 
I do, and it USED to work (about a week ago)

I'm surprised nobody has complained about this already.  (or maybe I 
just didnt see any such thread about it)

I like to use gitweb to review patches that have already been applied to 
the various trees.  Can we do something to get this working again?

Thank you,

Michael Krufky
...v4l / dvb...

Re: [KORG] GITWEB doesn't show any DIFF's

[Alistair John Strachan]

On Tuesday 17 January 2006 14:01, Michael Krufky wrote:
> To Whom (and ALL) that it may concern:
>
> For the past week or so, I haven't been able to get gitweb, running on
> kernel.org, to show me any diff's.
>
> For each commit, if I click on the "commit" link, or "commitdiff" link,
> the best I get is something that looks like this:
>
> file:fd8bc718f0e33df0a446d3d5c67f68929eca6490
> <http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blo
>b;h=fd8bc718f0e33df0a446d3d5c67f68929eca6490;hb=e0ad8486266c3415ab9c17f5c03c
>47edc7b93d7b;f=drivers/media/video/cx88/cx88-alsa.c> ->
> file:e649f678d47ab0a749b89146867ff9b1f513f73a
> <http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blo
>b;h=e649f678d47ab0a749b89146867ff9b1f513f73a;hb=e0ad8486266c3415ab9c17f5c03c
>47edc7b93d7b;f=drivers/media/video/cx88/cx88-alsa.c>
>
> This is for "V4L/DVB (3375): git dvb callbacks fix" , but it happens for
> every patch I try to view...  Even if I try to view the patch in "plan"
> mode, the following is all that I can see:
>
> From: Andrew Morton <akpm@osdl.org>
> Date: Sun, 15 Jan 2006 08:45:20 +0000 (-0200)
> Subject: V4L/DVB (3375): git dvb callbacks fix
> X-Git-Tag: v2.6.16-rc1
> X-Git-Url:
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=comm
>itdiff;h=e0ad8486266c3415ab9c17f5c03c47edc7b93d7b
>
> V4L/DVB (3375): git dvb callbacks fix
>
> - Not sure what went wrong here, but SND_PCI_PM_CALLBACKS got deleted.
>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
> ---
>
> (I havent seen this patch, and I'm really curious what happens in it,
> and the explanation of the commit message -- these questions are
> probably answered simply by viewing the patch, which I cant do :-(  )
>
> ... I have tried this at multiple locations, using several different
> browsers under different OS's ... It won't show me a diff no matter what
> I do, and it USED to work (about a week ago)
>
> I'm surprised nobody has complained about this already.  (or maybe I
> just didnt see any such thread about it)

Seems to work for me right _now_, could you verify that this is still 
happening?

-- 
Cheers,
Alistair.

'No sense being pessimistic, it probably wouldn't work anyway.'
Third year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

Re: [KORG] GITWEB doesn't show any DIFF's

[Diego Calleja]

El Tue, 17 Jan 2006 17:39:17 +0000,
Alistair John Strachan <s0348365@sms.ed.ac.uk> escribió:

> Seems to work for me right _now_, could you verify that this is still 
> happening?


It happens for me, too - instead of showing me the diff, diffstat
shows me just:


file:844a6c9fb9490e585fc5371d759840b9e7ae327c -> file:21965e5ef25e8c1c86bd59da0f40350d4f821702
file:9a96f05883935a32955b216fcc3184bf162b0a85 -> file:63dd184ec808e7129efc3a355abdba4a21bf2c81

With this commitdiff link, for example: 
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7fab773de16ccaeb249acdc6e956a9759c68225d;hp=0046b06a367cd853efd3223ce60143f3a7952522

Re: [KORG] GITWEB doesn't show any DIFF's

[Michael Krufky]

Alistair John Strachan wrote:

>On Tuesday 17 January 2006 14:01, Michael Krufky wrote:
>  
>
>>To Whom (and ALL) that it may concern:
>>
>>For the past week or so, I haven't been able to get gitweb, running on
>>kernel.org, to show me any diff's.
>>
>>For each commit, if I click on the "commit" link, or "commitdiff" link,
>>the best I get is something that looks like this:
>>
>>file:fd8bc718f0e33df0a446d3d5c67f68929eca6490
>><http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blo
>>b;h=fd8bc718f0e33df0a446d3d5c67f68929eca6490;hb=e0ad8486266c3415ab9c17f5c03c
>>47edc7b93d7b;f=drivers/media/video/cx88/cx88-alsa.c> ->
>>file:e649f678d47ab0a749b89146867ff9b1f513f73a
>><http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blo
>>b;h=e649f678d47ab0a749b89146867ff9b1f513f73a;hb=e0ad8486266c3415ab9c17f5c03c
>>47edc7b93d7b;f=drivers/media/video/cx88/cx88-alsa.c>
>>
>>This is for "V4L/DVB (3375): git dvb callbacks fix" , but it happens for
>>every patch I try to view...  Even if I try to view the patch in "plan"
>>mode, the following is all that I can see:
>>
>>From: Andrew Morton <akpm@osdl.org>
>>Date: Sun, 15 Jan 2006 08:45:20 +0000 (-0200)
>>Subject: V4L/DVB (3375): git dvb callbacks fix
>>X-Git-Tag: v2.6.16-rc1
>>X-Git-Url:
>>http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=comm
>>itdiff;h=e0ad8486266c3415ab9c17f5c03c47edc7b93d7b
>>
>>V4L/DVB (3375): git dvb callbacks fix
>>
>>- Not sure what went wrong here, but SND_PCI_PM_CALLBACKS got deleted.
>>
>>Signed-off-by: Andrew Morton <akpm@osdl.org>
>>Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
>>---
>>
>>(I havent seen this patch, and I'm really curious what happens in it,
>>and the explanation of the commit message -- these questions are
>>probably answered simply by viewing the patch, which I cant do :-(  )
>>
>>... I have tried this at multiple locations, using several different
>>browsers under different OS's ... It won't show me a diff no matter what
>>I do, and it USED to work (about a week ago)
>>
>>I'm surprised nobody has complained about this already.  (or maybe I
>>just didnt see any such thread about it)
>>    
>>
>
>Seems to work for me right _now_, could you verify that this is still 
>happening?
>
>  
>
I confirm, that nothing has changed...... Once again, no matter what OS, 
no matter what browser, no matter which location I am sitting at, I see 
no diff.

Thanks,

Michael Krufky

Re: [KORG] GITWEB doesn't show any DIFF's

[Jesper Juhl]

On 1/17/06, Diego Calleja <diegocg@gmail.com> wrote:
> El Tue, 17 Jan 2006 17:39:17 +0000,
> Alistair John Strachan <s0348365@sms.ed.ac.uk> escribió:
>
> > Seems to work for me right _now_, could you verify that this is still
> > happening?
>
>
> It happens for me, too - instead of showing me the diff, diffstat
> shows me just:
>
>
> file:844a6c9fb9490e585fc5371d759840b9e7ae327c -> file:21965e5ef25e8c1c86bd59da0f40350d4f821702
> file:9a96f05883935a32955b216fcc3184bf162b0a85 -> file:63dd184ec808e7129efc3a355abdba4a21bf2c81
>
> With this commitdiff link, for example:
> http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7fab773de16ccaeb249acdc6e956a9759c68225d;hp=0046b06a367cd853efd3223ce60143f3a7952522

Seems to work just fine for me.
With that link I get this :



[PATCH] ide: AMD Geode GX/LX support
From: "Jordan Crouse" <jordan.crouse@amd.com>

The core IDE engine on the CS5536 is the same as the other AMD southbridges,
so unlike the CS5535, we can simply add the appropriate PCI headers to
the existing amd74xx code.


file:844a6c9fb9490e585fc5371d759840b9e7ae327c ->
file:21965e5ef25e8c1c86bd59da0f40350d4f821702
--- a/drivers/ide/pci/amd74xx.c
+++ b/drivers/ide/pci/amd74xx.c
@@ -74,6 +74,7 @@ static struct amd_ide_chip {
{ PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_IDE, 0x50, AMD_UDMA_133 },
{ PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_IDE, 0x50, AMD_UDMA_133 },
{ PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_IDE, 0x50, AMD_UDMA_133 },
+ { PCI_DEVICE_ID_AMD_CS5536_IDE, 0x40, AMD_UDMA_100 },
{ 0 }
};
@@ -491,6 +492,7 @@ static ide_pci_device_t amd74xx_chipsets
/* 14 */ DECLARE_NV_DEV("NFORCE-MCP04"),
/* 15 */ DECLARE_NV_DEV("NFORCE-MCP51"),
/* 16 */ DECLARE_NV_DEV("NFORCE-MCP55"),
+ /* 17 */ DECLARE_AMD_DEV("AMD5536"),
};
static int __devinit amd74xx_probe(struct pci_dev *dev, const struct
pci_device_id *id)
@@ -527,6 +529,7 @@ static struct pci_device_id amd74xx_pci_
{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_IDE,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 14 },
{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_IDE,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 15 },
{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_IDE,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 16 },
+ { PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CS5536_IDE, PCI_ANY_ID,
PCI_ANY_ID, 0, 0, 17 },
{ 0, },
};
MODULE_DEVICE_TABLE(pci, amd74xx_pci_tbl);
file:9a96f05883935a32955b216fcc3184bf162b0a85 ->
file:63dd184ec808e7129efc3a355abdba4a21bf2c81
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -487,6 +487,8 @@
#define PCI_DEVICE_ID_AMD_8151_0 0x7454
#define PCI_DEVICE_ID_AMD_8131_APIC 0x7450
+#define PCI_DEVICE_ID_AMD_CS5536_IDE 0x209A
+
#define PCI_VENDOR_ID_TRIDENT 0x1023
#define PCI_DEVICE_ID_TRIDENT_4DWAVE_DX 0x2000
#define PCI_DEVICE_ID_TRIDENT_4DWAVE_NX 0x2001


--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: [KORG] GITWEB doesn't show any DIFF's

[Michael Krufky]

On 1/17/06, Jesper Juhl <jesper.juhl@gmail.com> wrote:
> On 1/17/06, Diego Calleja <diegocg@gmail.com> wrote:
> > El Tue, 17 Jan 2006 17:39:17 +0000,
> > Alistair John Strachan <s0348365@sms.ed.ac.uk> escribió:
> >
> > > Seems to work for me right _now_, could you verify that this is still
> > > happening?
> >
> >
> > It happens for me, too - instead of showing me the diff, diffstat
> > shows me just:
> >
> >
> > file:844a6c9fb9490e585fc5371d759840b9e7ae327c -> file:21965e5ef25e8c1c86bd59da0f40350d4f821702
> > file:9a96f05883935a32955b216fcc3184bf162b0a85 -> file:63dd184ec808e7129efc3a355abdba4a21bf2c81
> >
> > With this commitdiff link, for example:
> > http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7fab773de16ccaeb249acdc6e956a9759c68225d;hp=0046b06a367cd853efd3223ce60143f3a7952522
>
> Seems to work just fine for me.
> With that link I get this :
>
>
>
> [PATCH] ide: AMD Geode GX/LX support
> From: "Jordan Crouse" <jordan.crouse@amd.com>
>
> The core IDE engine on the CS5536 is the same as the other AMD southbridges,
> so unlike the CS5535, we can simply add the appropriate PCI headers to
> the existing amd74xx code.
>
>
> file:844a6c9fb9490e585fc5371d759840b9e7ae327c ->
> file:21965e5ef25e8c1c86bd59da0f40350d4f821702
> --- a/drivers/ide/pci/amd74xx.c
> +++ b/drivers/ide/pci/amd74xx.c
> @@ -74,6 +74,7 @@ static struct amd_ide_chip {
> { PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_IDE, 0x50, AMD_UDMA_133 },
> { PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_IDE, 0x50, AMD_UDMA_133 },
> { PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_IDE, 0x50, AMD_UDMA_133 },
> + { PCI_DEVICE_ID_AMD_CS5536_IDE, 0x40, AMD_UDMA_100 },
> { 0 }
> };
> @@ -491,6 +492,7 @@ static ide_pci_device_t amd74xx_chipsets
> /* 14 */ DECLARE_NV_DEV("NFORCE-MCP04"),
> /* 15 */ DECLARE_NV_DEV("NFORCE-MCP51"),
> /* 16 */ DECLARE_NV_DEV("NFORCE-MCP55"),
> + /* 17 */ DECLARE_AMD_DEV("AMD5536"),
> };
> static int __devinit amd74xx_probe(struct pci_dev *dev, const struct
> pci_device_id *id)
> @@ -527,6 +529,7 @@ static struct pci_device_id amd74xx_pci_
> { PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_IDE,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, 14 },
> { PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_IDE,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, 15 },
> { PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_IDE,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, 16 },
> + { PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CS5536_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 17 },
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, amd74xx_pci_tbl);
> file:9a96f05883935a32955b216fcc3184bf162b0a85 ->
> file:63dd184ec808e7129efc3a355abdba4a21bf2c81
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -487,6 +487,8 @@
> #define PCI_DEVICE_ID_AMD_8151_0 0x7454
> #define PCI_DEVICE_ID_AMD_8131_APIC 0x7450
> +#define PCI_DEVICE_ID_AMD_CS5536_IDE 0x209A
> +
> #define PCI_VENDOR_ID_TRIDENT 0x1023
> #define PCI_DEVICE_ID_TRIDENT_4DWAVE_DX 0x2000
> #define PCI_DEVICE_ID_TRIDENT_4DWAVE_NX 0x2001


Hmmm... very strange... It seems to be working fine for Jesper and
Alistair, but Diego Calleja confirms the same problem that I'm seeing.
 Could it be a problem on one of the two KORG servers, and not the
other?  Maybe thats why it works for some people but not everyone??

If that were the case, I would assume that it should work for me
SOMETIMES, but no.... It used to always show me a diff, and now it
never does.  :-(

-Michael

Re: [KORG] GITWEB doesn't show any DIFF's

[Alistair John Strachan]

On Tuesday 17 January 2006 17:59, Michael Krufky wrote:
[snip]
> >>
> >>... I have tried this at multiple locations, using several different
> >>browsers under different OS's ... It won't show me a diff no matter what
> >>I do, and it USED to work (about a week ago)
> >>
> >>I'm surprised nobody has complained about this already.  (or maybe I
> >>just didnt see any such thread about it)
> >
> >Seems to work for me right _now_, could you verify that this is still
> >happening?
>
> I confirm, that nothing has changed...... Once again, no matter what OS,
> no matter what browser, no matter which location I am sitting at, I see
> no diff.

Try holding shift and pressing refresh. Maybe it's some bizarre caching issue?

Also, try s/www/zeus2/ in the URL to see if it's a problem specific to one 
server (I wonder if the reason some of us have problems and others don't is 
that we are being http load balanced).

-- 
Cheers,
Alistair.

'No sense being pessimistic, it probably wouldn't work anyway.'
Third year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

Re: [KORG] GITWEB doesn't show any DIFF's

[Michael Krufky]

Alistair John Strachan wrote:

>On Tuesday 17 January 2006 17:59, Michael Krufky wrote:
>[snip]
>  
>
>>>>... I have tried this at multiple locations, using several different
>>>>browsers under different OS's ... It won't show me a diff no matter what
>>>>I do, and it USED to work (about a week ago)
>>>>
>>>>I'm surprised nobody has complained about this already.  (or maybe I
>>>>just didnt see any such thread about it)
>>>>        
>>>>
>>>Seems to work for me right _now_, could you verify that this is still
>>>happening?
>>>      
>>>
>>I confirm, that nothing has changed...... Once again, no matter what OS, no matter what browser, no matter which location I am sitting at, I see no diff.
>>    
>>
>
>Try holding shift and pressing refresh. Maybe it's some bizarre caching issue?
>
>Also, try s/www/zeus2/ in the URL to see if it's a problem specific to one 
>server (I wonder if the reason some of us have problems and others don't is 
>that we are being http load balanced).
>
Well, when I used zeus2 directly, I can see the diff...... I tried doing 
the same with  zeus1, and in fact, the diff does not show.

That solves it!

Zeus2 is working correctly, Zeus1 isnt showing us any diff's ......

Thanks for the help, now, can this be fixed?

Cheers,

Michael Krufky

Re: [KORG] GITWEB doesn't show any DIFF's

[Nathan Laredo]

On Tue, Jan 17, 2006 at 01:27:08PM -0500, Michael Krufky wrote:
> >Also, try s/www/zeus2/ in the URL to see if it's a problem 
> >specific to one server (I wonder if the reason some of us have 
> >problems and others don't is that we are being http load 
> >balanced).
> >
> Well, when I used zeus2 directly, I can see the diff...... I tried doing 
> the same with  zeus1, and in fact, the diff does not show.
> 
> That solves it!
> 
> Zeus2 is working correctly, Zeus1 isnt showing us any diff's ......
> 
> Thanks for the help, now, can this be fixed?

A couple things were happening here...

zeus1 suffered a cpu fan failure and was shutdown by external 
hardware that rebooted it into a different kernel (which ended
up resolving the 64-bit sendfile issue (older kernel)

load average on zeus1 was well over 150 with the older kernel--
and a bit of investigation went into whether or not the kernel
was the cause, but in the process of investigation, a third problem 
was discovered...

Logwatch left 39GB of turds in /tmp filling up the entire root
filesystem causing gitweb to fail because it had nowhere to
write temp files (also why the bandwidth graph wasn't showing
up as well for zeus1).

The root filesystem is only 50GB on that machine while /var/log
is hundreds of gigabytes...

/tmp was cleared out, the system is now on a more stable kernel
that should resolve the 64-bit sendfile issues, and the system
load appears to now be at a reasonable level...

We will be updating the kernel on the other machine after the
current one proves stable with 64-bit sendfile support.

That should fix the problem with apache not being able to
serve DVD images...

-- Nathan Laredo
laredo@kernel.org