[PATCH] ieee1394: allow building with absolute SUBDIRS path

[PATCH] ieee1394: allow building with absolute SUBDIRS path

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

This patch allows building the modules with an absolute SUBDIRS path,
especially for building them out of tree.

Signed-Off-By: Johannes Berg <johannes@sipsolutions.net>

--- a/drivers/ieee1394/Makefile
+++ b/drivers/ieee1394/Makefile
@@ -18,7 +19,7 @@ obj-$(CONFIG_IEEE1394_AMDTP) += amdtp.o
 obj-$(CONFIG_IEEE1394_CMP) += cmp.o
 
 quiet_cmd_oui2c = OUI2C   $@
-      cmd_oui2c = $(CONFIG_SHELL) $(srctree)/$(src)/oui2c.sh < $< > $@
+      cmd_oui2c = $(CONFIG_SHELL) $(src)/oui2c.sh < $< > $@
 
 targets := oui.c
 $(obj)/oui.o: $(obj)/oui.c


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH] ieee1394: allow building with absolute SUBDIRS path

[Stefan Richter]

Johannes Berg wrote:
> This patch allows building the modules with an absolute SUBDIRS path,
> especially for building them out of tree.
> 
> Signed-Off-By: Johannes Berg <johannes@sipsolutions.net>
> 
> --- a/drivers/ieee1394/Makefile
> +++ b/drivers/ieee1394/Makefile
> @@ -18,7 +19,7 @@ obj-$(CONFIG_IEEE1394_AMDTP) += amdtp.o
>  obj-$(CONFIG_IEEE1394_CMP) += cmp.o
>  
>  quiet_cmd_oui2c = OUI2C   $@
> -      cmd_oui2c = $(CONFIG_SHELL) $(srctree)/$(src)/oui2c.sh < $< > $@
> +      cmd_oui2c = $(CONFIG_SHELL) $(src)/oui2c.sh < $< > $@
>  
>  targets := oui.c
>  $(obj)/oui.o: $(obj)/oui.c
> 

Looks good, although you should rediff against current sources
and post at linux1394-devel. :-)

If you want to develop on top of latest 1394 sources but with a
released kernel underneath, you could check out my quilt trees.
http://me.in-berlin.de/~s5r6/linux1394/updates/
-- 
Stefan Richter
-=====-=-==- ---= ==-=-
http://arcgraph.de/sr/

Re: [PATCH] ieee1394: allow building with absolute SUBDIRS path

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]


> Looks good, although you should rediff against current sources
> and post at linux1394-devel. :-)

Right.

> If you want to develop on top of latest 1394 sources but with a
> released kernel underneath, you could check out my quilt trees.
> http://me.in-berlin.de/~s5r6/linux1394/updates/

Thanks, will take a look.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH] ieee1394: allow building with absolute SUBDIRS path

[Jody McIntyre]

On Thu, Jan 26, 2006 at 01:19:03AM +0100, Johannes Berg wrote:
> This patch allows building the modules with an absolute SUBDIRS path,
> especially for building them out of tree.

Applied, thanks.

Does anyone else feel like killing oui.c?

> Signed-Off-By: Johannes Berg <johannes@sipsolutions.net>

Minor nit: This should be Signed-off-by:

I doubt anyone cares :)

Cheers,
Jody

> 
> --- a/drivers/ieee1394/Makefile
> +++ b/drivers/ieee1394/Makefile
> @@ -18,7 +19,7 @@ obj-$(CONFIG_IEEE1394_AMDTP) += amdtp.o
>  obj-$(CONFIG_IEEE1394_CMP) += cmp.o
>  
>  quiet_cmd_oui2c = OUI2C   $@
> -      cmd_oui2c = $(CONFIG_SHELL) $(srctree)/$(src)/oui2c.sh < $< > $@
> +      cmd_oui2c = $(CONFIG_SHELL) $(src)/oui2c.sh < $< > $@
>  
>  targets := oui.c
>  $(obj)/oui.o: $(obj)/oui.c
> 



-- 

ieee1394/oui.db (was Re: [PATCH] ieee1394: allow building with absolute SUBDIRS path)

[Stefan Richter]

Jody McIntyre wrote:
> Does anyone else feel like killing oui.c?

I have no strong feelings for or against oui.db. It is nice to have the 
vendor names decoded in sysfs, although the footprint is considerable:

$ du oui.o ieee1394.ko
252K    oui.o
356K    ieee1394.ko

OTOH, nobody is forced to compile it in. And except for the Makefile 
patch and .gitignore patch which came in this month, oui.db does not 
impose a real maintenance burden. The fact that we are too lazy to 
update the db saves us work too. :-)

BTW, oui.db has 7048 entries but IEEE lists 8949 today. Either people 
vote oui.db off the island now, or I will submit an update.
-- 
Stefan Richter
-=====-=-==- ---= =====
http://arcgraph.de/sr/

Re: ieee1394/oui.db (was Re: [PATCH] ieee1394: allow building with absolute SUBDIRS path)

[Jody McIntyre]

On Tue, Jan 31, 2006 at 09:19:20PM +0100, Stefan Richter wrote:
> 
> I have no strong feelings for or against oui.db. It is nice to have the 
> vendor names decoded in sysfs, although the footprint is considerable:

I guess it's nice (I've never compiled it in until a few days ago mind
you) but this type of thing is userland's job.  I've been meaning to
write a good ls1394 for some time now.  I have one that's too crappy to
release :)

> $ du oui.o ieee1394.ko
> 252K    oui.o
> 356K    ieee1394.ko
> 
> OTOH, nobody is forced to compile it in. And except for the Makefile 
> patch and .gitignore patch which came in this month, oui.db does not 
> impose a real maintenance burden. The fact that we are too lazy to 
> update the db saves us work too. :-)

No, it doesn't, but its existance offends me :)

I don't care deeply though.  If people want it, I'll live with it being
in.

Cheers,
Jody


> BTW, oui.db has 7048 entries but IEEE lists 8949 today. Either people 
> vote oui.db off the island now, or I will submit an update.
> -- 
> Stefan Richter
> -=====-=-==- ---= =====
> http://arcgraph.de/sr/
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 

Re: ieee1394/oui.db (was Re: [PATCH] ieee1394: allow building with absolute SUBDIRS path)

[Stefan Richter]

Ben Collins wrote on 2006-01-31:
> On Tue, 2006-01-31 at 21:19 +0100, Stefan Richter wrote:
>>Jody McIntyre wrote:
>>>Does anyone else feel like killing oui.c?
>>
>>I have no strong feelings for or against oui.db. It is nice to have the 
>>vendor names decoded in sysfs, although the footprint is considerable:
>>
>>$ du oui.o ieee1394.ko
>>252K    oui.o
>>356K    ieee1394.ko
>>
>>OTOH, nobody is forced to compile it in. And except for the Makefile 
>>patch and .gitignore patch which came in this month, oui.db does not 
>>impose a real maintenance burden. The fact that we are too lazy to 
>>update the db saves us work too. :-)
>>
>>BTW, oui.db has 7048 entries but IEEE lists 8949 today. Either people 
>>vote oui.db off the island now, or I will submit an update.
> 
> I vote update it. I really think something like OUI needs to be part of
> the kernel lib/ though. Lots of things, like ethernet and bluetooth can
> use it. No one really does though.

Yes, drivers/ieee1394/ is the wrong place for oui.db. In case oui.db was 
not killed by then, I will submit patches to move oui.db to lib/ later 
this month.
-- 
Stefan Richter
-=====-=-==- --=- --=--
http://arcgraph.de/sr/