From: Ian Abbott <abbotti@mev.co.uk>
To: chakravarthikulkarni <chakravarthikulkarni2021@gmail.com>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Al Viro <viro@zeniv.linux.org.uk>, Xin Tan <tanxin.ctf@gmail.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
"Alexander A. Klimov" <grandmaster@al2klimov.de>,
Michel Lespinasse <walken@google.com>,
B K Karthik <bkkarthik@pesu.pes.edu>,
Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: Replaced strlcpy to strscpy
Date: Thu, 18 Feb 2021 16:45:30 +0000 [thread overview]
Message-ID: <43b0f966-9d88-3c92-28ce-6dfce755a1be@mev.co.uk> (raw)
In-Reply-To: <20210218143152.3957-1-chakravarthikulkarni2021@gmail.com>
On 18/02/2021 14:31, chakravarthikulkarni wrote:
> Warning found by checkpath.pl script.
>
> Signed-off-by: chakravarthikulkarni <chakravarthikulkarni2021@gmail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 80d74cce2a01..df77b6bf5c64 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -939,8 +939,8 @@ static int do_devinfo_ioctl(struct comedi_device *dev,
> /* fill devinfo structure */
> devinfo.version_code = COMEDI_VERSION_CODE;
> devinfo.n_subdevs = dev->n_subdevices;
> - strlcpy(devinfo.driver_name, dev->driver->driver_name, COMEDI_NAMELEN);
> - strlcpy(devinfo.board_name, dev->board_name, COMEDI_NAMELEN);
> + strscpy(devinfo.driver_name, dev->driver->driver_name, COMEDI_NAMELEN);
> + strscpy(devinfo.board_name, dev->board_name, COMEDI_NAMELEN);
>
> s = comedi_file_read_subdevice(file);
> if (s)
>
Thanks, but you are too late. It has already been fixed in linux-next.
--
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
prev parent reply other threads:[~2021-02-18 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 14:31 [PATCH] Staging: comedi: Replaced strlcpy to strscpy chakravarthikulkarni
2021-02-18 16:45 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43b0f966-9d88-3c92-28ce-6dfce755a1be@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=bkkarthik@pesu.pes.edu \
--cc=chakravarthikulkarni2021@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.m.jordan@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=grandmaster@al2klimov.de \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tanxin.ctf@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).