* [PATCH] Staging: comedi: Replaced strlcpy to strscpy
@ 2021-02-18 14:31 chakravarthikulkarni
2021-02-18 16:45 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: chakravarthikulkarni @ 2021-02-18 14:31 UTC (permalink / raw)
Cc: chakravarthikulkarni2021, Ian Abbott, H Hartley Sweeten,
Greg Kroah-Hartman, Al Viro, Xin Tan, Daniel Jordan,
Alexander A. Klimov, Michel Lespinasse, B K Karthik,
Dan Carpenter, devel, linux-kernel
Warning found by checkpath.pl script.
Signed-off-by: chakravarthikulkarni <chakravarthikulkarni2021@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 80d74cce2a01..df77b6bf5c64 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -939,8 +939,8 @@ static int do_devinfo_ioctl(struct comedi_device *dev,
/* fill devinfo structure */
devinfo.version_code = COMEDI_VERSION_CODE;
devinfo.n_subdevs = dev->n_subdevices;
- strlcpy(devinfo.driver_name, dev->driver->driver_name, COMEDI_NAMELEN);
- strlcpy(devinfo.board_name, dev->board_name, COMEDI_NAMELEN);
+ strscpy(devinfo.driver_name, dev->driver->driver_name, COMEDI_NAMELEN);
+ strscpy(devinfo.board_name, dev->board_name, COMEDI_NAMELEN);
s = comedi_file_read_subdevice(file);
if (s)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: comedi: Replaced strlcpy to strscpy
2021-02-18 14:31 [PATCH] Staging: comedi: Replaced strlcpy to strscpy chakravarthikulkarni
@ 2021-02-18 16:45 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2021-02-18 16:45 UTC (permalink / raw)
To: chakravarthikulkarni
Cc: H Hartley Sweeten, Greg Kroah-Hartman, Al Viro, Xin Tan,
Daniel Jordan, Alexander A. Klimov, Michel Lespinasse,
B K Karthik, Dan Carpenter, devel, linux-kernel
On 18/02/2021 14:31, chakravarthikulkarni wrote:
> Warning found by checkpath.pl script.
>
> Signed-off-by: chakravarthikulkarni <chakravarthikulkarni2021@gmail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 80d74cce2a01..df77b6bf5c64 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -939,8 +939,8 @@ static int do_devinfo_ioctl(struct comedi_device *dev,
> /* fill devinfo structure */
> devinfo.version_code = COMEDI_VERSION_CODE;
> devinfo.n_subdevs = dev->n_subdevices;
> - strlcpy(devinfo.driver_name, dev->driver->driver_name, COMEDI_NAMELEN);
> - strlcpy(devinfo.board_name, dev->board_name, COMEDI_NAMELEN);
> + strscpy(devinfo.driver_name, dev->driver->driver_name, COMEDI_NAMELEN);
> + strscpy(devinfo.board_name, dev->board_name, COMEDI_NAMELEN);
>
> s = comedi_file_read_subdevice(file);
> if (s)
>
Thanks, but you are too late. It has already been fixed in linux-next.
--
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-18 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 14:31 [PATCH] Staging: comedi: Replaced strlcpy to strscpy chakravarthikulkarni
2021-02-18 16:45 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).