* [PATCH] ARM: dts: BCM5301X: Change Ethernet switch management port
@ 2019-02-13 4:25 Florian Fainelli
2019-02-13 8:07 ` Rafał Miłecki
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2019-02-13 4:25 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Florian Fainelli, Hauke Mehrtens, Rafał Miłecki,
maintainer:BROADCOM BCM5301X ARM ARCHITECTURE, Rob Herring,
Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
BCM5301X has 3 Ethernet controllers: GMAC0, 1, 2 which map to ports 5, 7
and 8 respectively of the internal switch. Future changes will turn on
management mode in the Ethernet switch driver (b53) which will require
us to use port 8.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
index 3fced3b7f1a8..affa9cc7422d 100644
--- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
+++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
@@ -150,10 +150,15 @@
label = "wan";
};
- port@5 {
- reg = <5>;
+ port@8 {
+ reg = <8>;
label = "cpu";
- ethernet = <&gmac0>;
+ ethernet = <&gmac2>;
+
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
};
};
};
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: BCM5301X: Change Ethernet switch management port
2019-02-13 4:25 [PATCH] ARM: dts: BCM5301X: Change Ethernet switch management port Florian Fainelli
@ 2019-02-13 8:07 ` Rafał Miłecki
2019-02-13 17:24 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Rafał Miłecki @ 2019-02-13 8:07 UTC (permalink / raw)
To: Florian Fainelli, linux-arm-kernel
Cc: Hauke Mehrtens, maintainer:BROADCOM BCM5301X ARM ARCHITECTURE,
Rob Herring, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 13.02.2019 05:25, Florian Fainelli wrote:
> BCM5301X has 3 Ethernet controllers: GMAC0, 1, 2 which map to ports 5, 7
> and 8 respectively of the internal switch. Future changes will turn on
> management mode in the Ethernet switch driver (b53) which will require
> us to use port 8.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
> index 3fced3b7f1a8..affa9cc7422d 100644
> --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
> +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
> @@ -150,10 +150,15 @@
> label = "wan";
> };
>
> - port@5 {
> - reg = <5>;
> + port@8 {
> + reg = <8>;
> label = "cpu";
> - ethernet = <&gmac0>;
> + ethernet = <&gmac2>;
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> };
> };
> };
I'm not exactly sure how Linux switch driver works, but from DT
perspective I think we should rather have *hardware* described instead
of a common Linux case.
If I'm right, we should rather have all 3 switch ports described (5, 7,
8) and have Linux just use the one it needs.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: BCM5301X: Change Ethernet switch management port
2019-02-13 8:07 ` Rafał Miłecki
@ 2019-02-13 17:24 ` Florian Fainelli
0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-02-13 17:24 UTC (permalink / raw)
To: Rafał Miłecki, Florian Fainelli, linux-arm-kernel
Cc: Hauke Mehrtens, maintainer:BROADCOM BCM5301X ARM ARCHITECTURE,
Rob Herring, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 2/13/19 12:07 AM, Rafał Miłecki wrote:
> On 13.02.2019 05:25, Florian Fainelli wrote:
>> BCM5301X has 3 Ethernet controllers: GMAC0, 1, 2 which map to ports 5, 7
>> and 8 respectively of the internal switch. Future changes will turn on
>> management mode in the Ethernet switch driver (b53) which will require
>> us to use port 8.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 11 ++++++++---
>> 1 file changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
>> b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
>> index 3fced3b7f1a8..affa9cc7422d 100644
>> --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
>> +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
>> @@ -150,10 +150,15 @@
>> label = "wan";
>> };
>> - port@5 {
>> - reg = <5>;
>> + port@8 {
>> + reg = <8>;
>> label = "cpu";
>> - ethernet = <&gmac0>;
>> + ethernet = <&gmac2>;
>> +
>> + fixed-link {
>> + speed = <1000>;
>> + full-duplex;
>> + };
>> };
>> };
>> };
>
> I'm not exactly sure how Linux switch driver works, but from DT
> perspective I think we should rather have *hardware* described instead
> of a common Linux case.
>
> If I'm right, we should rather have all 3 switch ports described (5, 7,
> 8) and have Linux just use the one it needs.
Yes, let's do that.
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-13 17:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-13 4:25 [PATCH] ARM: dts: BCM5301X: Change Ethernet switch management port Florian Fainelli
2019-02-13 8:07 ` Rafał Miłecki
2019-02-13 17:24 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).