* Re: [PATCH] ASoC: tegra: SND_SOC_TEGRA_AUDIO_GRAPH_CARD should depend on SND_SOC_TEGRA
[not found] <20210129125915.2652952-1-geert+renesas@glider.be>
@ 2021-01-29 18:18 ` Sameer Pujar
2021-02-01 16:45 ` Mark Brown
1 sibling, 0 replies; 2+ messages in thread
From: Sameer Pujar @ 2021-01-29 18:18 UTC (permalink / raw)
To: Geert Uytterhoeven, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Thierry Reding, Jonathan Hunter
Cc: alsa-devel, linux-tegra, linux-kernel
On 1/29/2021 6:29 PM, Geert Uytterhoeven wrote:
> External email: Use caution opening links or attachments
>
>
> Audio Graph Card based Tegra driver is only useful on NVIDIA Tegra SoCs.
> Hence add a dependency on SND_SOC_TEGRA, to prevent asking the user
> about this driver when configuring a kernel without Tegra sound support.
>
> Wrap all Tegra sound config options inside a big if/endif block, instead
> of just adding the dependency to the single config option that does not
> have it yet, to preventing similar future mistakes.
>
> Fixes: 202e2f7745437aa5 ("ASoC: tegra: Add audio graph based card driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> sound/soc/tegra/Kconfig | 33 +++++++++++++--------------------
> 1 file changed, 13 insertions(+), 20 deletions(-)
>
Acked-by: Sameer Pujar <spujar@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: tegra: SND_SOC_TEGRA_AUDIO_GRAPH_CARD should depend on SND_SOC_TEGRA
[not found] <20210129125915.2652952-1-geert+renesas@glider.be>
2021-01-29 18:18 ` [PATCH] ASoC: tegra: SND_SOC_TEGRA_AUDIO_GRAPH_CARD should depend on SND_SOC_TEGRA Sameer Pujar
@ 2021-02-01 16:45 ` Mark Brown
1 sibling, 0 replies; 2+ messages in thread
From: Mark Brown @ 2021-02-01 16:45 UTC (permalink / raw)
To: Jonathan Hunter, Takashi Iwai, Geert Uytterhoeven, Sameer Pujar,
Thierry Reding, Liam Girdwood, Jaroslav Kysela
Cc: linux-kernel, linux-tegra, alsa-devel
On Fri, 29 Jan 2021 13:59:15 +0100, Geert Uytterhoeven wrote:
> Audio Graph Card based Tegra driver is only useful on NVIDIA Tegra SoCs.
> Hence add a dependency on SND_SOC_TEGRA, to prevent asking the user
> about this driver when configuring a kernel without Tegra sound support.
>
> Wrap all Tegra sound config options inside a big if/endif block, instead
> of just adding the dependency to the single config option that does not
> have it yet, to preventing similar future mistakes.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: tegra: SND_SOC_TEGRA_AUDIO_GRAPH_CARD should depend on SND_SOC_TEGRA
commit: e86caa011c80507783e5975bca1458f28c1d2b8c
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread