linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Dr. David Alan Gilbert" <linux@treblig.org>,
	James Courtier-Dutton <James@superbug.co.uk>,
	David Greaves <david@dgreaves.com>,
	Justin Piszcz <jpiszcz@lucidpixels.com>,
	Jeff Garzik <jgarzik@pobox.com>,
	linux-kernel@vger.kernel.org,
	IDE/ATA development list <linux-ide@vger.kernel.org>,
	albertcc@tw.ibm.com, axboe@suse.de, htejun@gmail.com
Subject: Re: Kernel SeekCompleteErrors... Different from Re: LibPATA code issues / 2.6.15.4
Date: Mon, 27 Feb 2006 08:40:08 -0500	[thread overview]
Message-ID: <44030138.4000203@rtr.ca> (raw)
In-Reply-To: <1141040889.27539.60.camel@localhost.localdomain>

Alan Cox wrote:
> On Sul, 2006-02-26 at 15:36 -0500, Mark Lord wrote:
>> It still is unreliable, as being discussed in another thread.
>>
>> libata wrongly says "medium error" any time it issues a command
>> that the drive rejects (unsupported, invalid parameters, etc..).
> 
> It seems to still get a single case wrong. But it does the report the
> ATA state correctly still.
> 
>> This is biting a few people in 2.6.16-rc*, due to the FUA stuff.
> 
> It is driven by a table in 
> 
> libata-scsi.c:ata_to_sense_error()
> 
> so if you can figure out the wrong entry and tweak the table that would be great

It's the fall-through case, where the table is not used.


         /* No error?  Undecoded? */
         printk(KERN_WARNING "ata%u: no sense translation for op=0x%02x status: 0x%02x\n",
                id, opcode, drv_stat);

         /* For our last chance pick, use medium read error because
          * it's much more common than an ATA drive telling you a write
          * has failed.
          */
         *sk = MEDIUM_ERROR;
         *asc = 0x11; /* "unrecovered read error" */
         *ascq = 0x04; /*  "auto-reallocation failed" */

Cheers

  reply	other threads:[~2006-02-27 13:40 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-14  9:48 LibPATA code issues / 2.6.15.4 Justin Piszcz
2006-02-14 14:50 ` Mark Lord
2006-02-14 16:27   ` David Greaves
2006-02-14 17:12     ` Justin Piszcz
2006-02-14 18:00       ` Mark Lord
2006-02-14 18:06         ` Justin Piszcz
2006-02-23 23:39         ` Justin Piszcz
2006-02-25 15:32           ` Mark Lord
2006-02-25 15:58             ` Justin Piszcz
2006-02-25 16:11               ` Jesper Juhl
2006-02-25 16:21               ` Mark Lord
2006-02-25 11:34         ` David Greaves
2006-02-25 16:20           ` Mark Lord
2006-02-25 17:45             ` Justin Piszcz
2006-02-25 18:28               ` Mark Lord
2006-02-25 18:55                 ` Justin Piszcz
2006-02-25 19:29                 ` Justin Piszcz
2006-02-25 19:53                   ` David Greaves
2006-02-25 19:47                 ` David Greaves
2006-02-26  2:27                   ` Mark Lord
2006-02-26  9:56                     ` David Greaves
2006-02-26 14:04                       ` Mark Lord
2006-02-27 21:34                         ` Mark Lord
2006-02-28  1:33                           ` Tejun Heo
2006-02-28  1:46                             ` Linus Torvalds
2006-02-28  2:07                               ` Jeff Garzik
2006-02-28  2:14                                 ` Linus Torvalds
2006-02-28  2:52                                   ` Jeff Garzik
2006-02-28  3:36                                   ` Jeff Garzik
2006-02-28  4:11                                     ` Mark Lord
2006-02-28 10:30                                 ` Alan Cox
2006-02-28  8:03                               ` Jens Axboe
2006-02-28  4:16                             ` Mark Lord
2006-02-28 10:32                               ` Alan Cox
2006-02-28 10:30                                 ` Justin Piszcz
2006-02-28 10:39                               ` David Greaves
2006-02-28 14:37                                 ` Mark Lord
2006-02-28 21:04                                   ` Bill Davidsen
2006-03-08  2:57                                     ` Mark Lord
2006-03-08  3:18                                       ` Dave Jones
2006-03-08  3:23                                         ` Mark Lord
2006-03-08 15:37                                       ` Bill Davidsen
2006-02-28 14:38                                 ` Mark Lord
2006-02-28 15:16                                   ` Alan Cox
2006-03-01 17:33                                     ` David Greaves
2006-03-01 18:37                                       ` Alan Cox
2006-03-01 20:12                                         ` Phillip Susi
2006-03-08 16:46                                           ` Alan Cox
2006-02-28 15:31                                 ` Mark Lord
2006-02-28 15:34                                   ` Jeff Garzik
2006-02-28 16:57                                     ` Eric D. Mudama
2006-03-01  1:04                                       ` Mark Lord
2006-03-01 11:37                                         ` Justin Piszcz
2006-03-01 13:17                                         ` Justin Piszcz
2006-03-01 17:41                                     ` David Greaves
2006-03-01 17:46                                       ` Mark Lord
2006-03-01 18:12                                         ` David Greaves
2006-03-01 18:30                                           ` Mark Lord
2006-03-01 18:32                                             ` Justin Piszcz
2006-03-01 18:33                                             ` Justin Piszcz
2006-03-01 18:48                                             ` David Greaves
2006-03-01 19:49                                               ` David Greaves
2006-03-03 19:38                                                 ` Justin Piszcz
2006-03-03 22:46                                                   ` David Greaves
2006-03-04 14:25                                                     ` Mark Lord
2006-03-06  6:13                                                       ` David Greaves
2006-03-21 18:11                                                         ` David Greaves
2006-03-22 15:23                                                           ` David Greaves
2006-03-05 11:43                                                 ` Justin Piszcz
2006-03-05 12:41                                                   ` Justin Piszcz
2006-03-05 22:58                                                     ` Mark Lord
2006-03-05 23:00                                                       ` Mark Lord
2006-03-05 23:19                                                         ` Justin Piszcz
2006-03-05 23:39                                                       ` Jeff Garzik
2006-04-21 19:14                                                         ` LibPATA code issues / 2.6.16 (previously, 2.6.15.x) Justin Piszcz
2006-04-21 19:18                                                           ` Jeff Garzik
2006-04-21 19:28                                                             ` Linus Torvalds
2006-04-21 22:46                                                               ` Jeff Garzik
2006-04-22  0:05                                                                 ` Linus Torvalds
2006-05-06 15:09                                                                   ` [smartmontools-support]Re: " Leon Woestenberg
2006-05-07 12:44                                                                     ` Ingo Oeser
2006-06-11 11:13                                                                   ` Justin Piszcz
2006-03-01 19:06                                             ` LibPATA code issues / 2.6.15.4 Justin Piszcz
2006-03-01 19:28                                               ` Mark Lord
2006-03-01 19:35                                               ` Mark Lord
2006-03-01 19:38                                                 ` Justin Piszcz
2006-03-01 19:41                                                   ` Jeff Garzik
2006-02-26 12:27                     ` James Courtier-Dutton
2006-02-26 12:55                       ` David Greaves
2006-02-26 13:56                       ` Mark Lord
2006-02-26 14:30                         ` Kernel SeekCompleteErrors... Different from " James Courtier-Dutton
2006-02-26 17:03                           ` Mark Lord
2006-02-26 17:13                             ` Dr. David Alan Gilbert
2006-02-26 17:43                               ` Alan Cox
2006-02-26 20:36                                 ` Mark Lord
2006-02-27 11:48                                   ` Alan Cox
2006-02-27 13:40                                     ` Mark Lord [this message]
2006-02-14 23:58   ` Justin Piszcz
2006-02-17  8:45   ` Jeff Garzik
2006-02-17 14:59     ` Mark Lord
2006-02-17 15:00       ` Justin Piszcz
2006-02-18 20:43       ` Sander
2006-02-18 21:42         ` Mark Lord
2006-02-18 21:51           ` Justin Piszcz
2006-02-19  7:14           ` Sander
2006-02-19 15:30             ` Mark Lord
2006-02-19 17:16               ` Sander
2006-07-06 23:08                 ` Justin Piszcz
2006-07-07 13:08                   ` Mark Lord
2006-07-07 13:24                     ` Justin Piszcz
2006-07-07 13:43                       ` Mark Lord
2006-07-07 13:48                         ` Justin Piszcz
2006-07-07 14:01                         ` Justin Piszcz
2006-07-07 14:35                         ` Justin Piszcz
2006-07-07 18:53                           ` Justin Piszcz
2006-07-07 19:19                             ` Jeff Garzik
2006-07-07 19:28                               ` Justin Piszcz
     [not found]                                 ` <200607091224.31451.liml@rtr.ca>
2006-07-09 17:27                                   ` Justin Piszcz
2006-07-09 20:16                                     ` Justin Piszcz
2006-07-09 20:40                                       ` LibPATA code issues / 2.6.15.4 (found the opcode=0x35)! Justin Piszcz
2006-07-09 20:46                                         ` Justin Piszcz
2006-07-09 21:05                                           ` Justin Piszcz
2006-07-09 22:03                                             ` Justin Piszcz
2006-07-10 13:59                                               ` Follow up? " Justin Piszcz
2006-07-10 15:33                                                 ` Alan Cox
2006-07-10 15:45                                                   ` Justin Piszcz
2006-07-11 13:28                                                     ` LibPATA code issues / 2.6.17.3 (What is the next step?) Justin Piszcz
2006-07-11 16:12                                                       ` Alan Cox
2006-07-12 22:10                                                         ` David Greaves
2006-07-12 22:29                                                           ` Justin Piszcz
2006-07-14 15:33                                                             ` David Greaves
2006-07-13 10:55                                                           ` Erik Mouw
2006-07-14 17:16                                                       ` Mark Lord
2006-07-14 17:18                                                         ` Justin Piszcz
2006-07-14 17:39                                                           ` Mark Lord
2006-07-14 18:18                                                             ` Justin Piszcz
2006-07-14 20:02                                                             ` Mark Lord
2006-07-14 17:14                                                     ` Follow up? LibPATA code issues / 2.6.15.4 (found the opcode=0x35)! Mark Lord
2006-07-14 17:17                                                       ` Justin Piszcz
2006-07-14 17:37                                                         ` Mark Lord
2006-07-14 18:17                                                           ` Justin Piszcz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44030138.4000203@rtr.ca \
    --to=liml@rtr.ca \
    --cc=James@superbug.co.uk \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=albertcc@tw.ibm.com \
    --cc=axboe@suse.de \
    --cc=david@dgreaves.com \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=jpiszcz@lucidpixels.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@treblig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).