From: Justin Piszcz <jpiszcz@lucidpixels.com>
To: David Greaves <david@dgreaves.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Mark Lord <liml@rtr.ca>,
Jeff Garzik <jgarzik@pobox.com>, Sander <sander@humilis.net>,
linux-kernel@vger.kernel.org,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: LibPATA code issues / 2.6.17.3 (What is the next step?)
Date: Wed, 12 Jul 2006 18:29:13 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0607121828290.11285@p34.internal.lan> (raw)
In-Reply-To: <44B57373.2030907@dgreaves.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1513 bytes --]
Unfortunately not, the correct patch you need is attached to get the
ata_op code, against 2.6.17.3.
On Wed, 12 Jul 2006, David Greaves wrote:
> Alan Cox wrote:
>> Ar Maw, 2006-07-11 am 09:28 -0400, ysgrifennodd Justin Piszcz:
>>> Alan/Jeff/Mark,
>>>
>>> Is there anything else I can do to further troubleshoot this problem now
>>> that we have the failed opcode(s)? Again, there is never any corruption
>>> on these drives, so it is more of an annoyance than anything else.
>>
>> Nothing strikes me so far other than the data not making sense. Possibly
>> it will become clearer later if/when we see other examples.
>
> For me it's SMART related.
>
> smartctl -data -o on /dev/sda reliably gets a similar message.
> Justin - does this smartctl command trigger a message for you?
>
> I've been mailing on and off since January-ish.
> (http://marc.theaimsgroup.com/?l=linux-ide&w=2&r=7&s=libpata&q=b)
>
> Back in March I was running 2.6.16 (with a different version of Mark's
> opcode patch) and I sent an email with the following info:
>
> dmesg:
> ata1: translated op=0x28 cmd=0x25 ATA stat/err 0x51/04 to SCSI
> SK/ASC/ASCQ 0xb/00/00
> ata1: status=0x51 { DriveReady SeekComplete Error }
> ata1: error=0x04 { DriveStatusError }
>
> Does that help with the diagnosis?
>
> Also see my emails: SMART on SATA reporting errors?
> http://marc.theaimsgroup.com/?l=linux-ide&m=113933732903205&w=2
>
> I did reply but got no response so I assumed I was just so far off base
> that I was being ignored :)
>
> David
>
[-- Attachment #2: Type: TEXT/PLAIN, Size: 2533 bytes --]
diff -uprN linux-2.6.17.3/drivers/scsi/libata-scsi.c linux-2.6.17.3-diff/drivers/scsi/libata-scsi.c
--- linux-2.6.17.3/drivers/scsi/libata-scsi.c 2006-06-30 13:37:38.000000000 -0400
+++ linux-2.6.17.3-diff/drivers/scsi/libata-scsi.c 2006-07-09 16:31:45.665112000 -0400
@@ -428,10 +428,16 @@ int ata_scsi_device_suspend(struct scsi_
* spin_lock_irqsave(host_set lock)
*/
void ata_to_sense_error(unsigned id, u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc,
- u8 *ascq)
+ u8 *ascq, struct ata_queued_cmd *qc)
{
int i;
+ struct scsi_cmnd *cmd = qc->scsicmd;
+ struct ata_taskfile *tf = &qc->tf;
+ unsigned char *sb = cmd->sense_buffer;
+ unsigned char *desc = sb + 8;
+ unsigned char ata_op = tf->command;
+
/* Based on the 3ware driver translation table */
static const unsigned char sense_table[][4] = {
/* BBD|ECC|ID|MAR */
@@ -520,6 +526,7 @@ void ata_to_sense_error(unsigned id, u8
printk(KERN_ERR "ata%u: translated ATA stat/err 0x%02x/%02x to "
"SCSI SK/ASC/ASCQ 0x%x/%02x/%02x\n", id, drv_stat, drv_err,
*sk, *asc, *ascq);
+ printk(KERN_ERR "ata_gen_ata_desc_sense: failed ata_op=0x%02x\n", ata_op);
return;
}
@@ -542,6 +549,7 @@ void ata_gen_ata_desc_sense(struct ata_q
struct ata_taskfile *tf = &qc->tf;
unsigned char *sb = cmd->sense_buffer;
unsigned char *desc = sb + 8;
+ unsigned char ata_op = tf->command;
memset(sb, 0, SCSI_SENSE_BUFFERSIZE);
@@ -558,8 +566,9 @@ void ata_gen_ata_desc_sense(struct ata_q
* onto sense key, asc & ascq.
*/
if (tf->command & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {
+ printk(KERN_WARNING "ata_gen_ata_desc_sense: failed ata_op=0x%02x\n", ata_op);
ata_to_sense_error(qc->ap->id, tf->command, tf->feature,
- &sb[1], &sb[2], &sb[3]);
+ &sb[1], &sb[2], &sb[3],qc);
sb[1] &= 0x0f;
}
@@ -617,6 +626,7 @@ void ata_gen_fixed_sense(struct ata_queu
struct scsi_cmnd *cmd = qc->scsicmd;
struct ata_taskfile *tf = &qc->tf;
unsigned char *sb = cmd->sense_buffer;
+ unsigned char ata_op = tf->command;
memset(sb, 0, SCSI_SENSE_BUFFERSIZE);
@@ -633,8 +643,9 @@ void ata_gen_fixed_sense(struct ata_queu
* onto sense key, asc & ascq.
*/
if (tf->command & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {
+ printk(KERN_WARNING "ata_gen_fixed_sense: failed ata_op=0x%02x\n", ata_op);
ata_to_sense_error(qc->ap->id, tf->command, tf->feature,
- &sb[2], &sb[12], &sb[13]);
+ &sb[2], &sb[12], &sb[13],qc);
sb[2] &= 0x0f;
}
next prev parent reply other threads:[~2006-07-12 22:29 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-14 9:48 LibPATA code issues / 2.6.15.4 Justin Piszcz
2006-02-14 14:50 ` Mark Lord
2006-02-14 16:27 ` David Greaves
2006-02-14 17:12 ` Justin Piszcz
2006-02-14 18:00 ` Mark Lord
2006-02-14 18:06 ` Justin Piszcz
2006-02-23 23:39 ` Justin Piszcz
2006-02-25 15:32 ` Mark Lord
2006-02-25 15:58 ` Justin Piszcz
2006-02-25 16:11 ` Jesper Juhl
2006-02-25 16:21 ` Mark Lord
2006-02-25 11:34 ` David Greaves
2006-02-25 16:20 ` Mark Lord
2006-02-25 17:45 ` Justin Piszcz
2006-02-25 18:28 ` Mark Lord
2006-02-25 18:55 ` Justin Piszcz
2006-02-25 19:29 ` Justin Piszcz
2006-02-25 19:53 ` David Greaves
2006-02-25 19:47 ` David Greaves
2006-02-26 2:27 ` Mark Lord
2006-02-26 9:56 ` David Greaves
2006-02-26 14:04 ` Mark Lord
2006-02-27 21:34 ` Mark Lord
2006-02-28 1:33 ` Tejun Heo
2006-02-28 1:46 ` Linus Torvalds
2006-02-28 2:07 ` Jeff Garzik
2006-02-28 2:14 ` Linus Torvalds
2006-02-28 2:52 ` Jeff Garzik
2006-02-28 3:36 ` Jeff Garzik
2006-02-28 4:11 ` Mark Lord
2006-02-28 10:30 ` Alan Cox
2006-02-28 8:03 ` Jens Axboe
2006-02-28 4:16 ` Mark Lord
2006-02-28 10:32 ` Alan Cox
2006-02-28 10:30 ` Justin Piszcz
2006-02-28 10:39 ` David Greaves
2006-02-28 14:37 ` Mark Lord
2006-02-28 21:04 ` Bill Davidsen
2006-03-08 2:57 ` Mark Lord
2006-03-08 3:18 ` Dave Jones
2006-03-08 3:23 ` Mark Lord
2006-03-08 15:37 ` Bill Davidsen
2006-02-28 14:38 ` Mark Lord
2006-02-28 15:16 ` Alan Cox
2006-03-01 17:33 ` David Greaves
2006-03-01 18:37 ` Alan Cox
2006-03-01 20:12 ` Phillip Susi
2006-03-08 16:46 ` Alan Cox
2006-02-28 15:31 ` Mark Lord
2006-02-28 15:34 ` Jeff Garzik
2006-02-28 16:57 ` Eric D. Mudama
2006-03-01 1:04 ` Mark Lord
2006-03-01 11:37 ` Justin Piszcz
2006-03-01 13:17 ` Justin Piszcz
2006-03-01 17:41 ` David Greaves
2006-03-01 17:46 ` Mark Lord
2006-03-01 18:12 ` David Greaves
2006-03-01 18:30 ` Mark Lord
2006-03-01 18:32 ` Justin Piszcz
2006-03-01 18:33 ` Justin Piszcz
2006-03-01 18:48 ` David Greaves
2006-03-01 19:49 ` David Greaves
2006-03-03 19:38 ` Justin Piszcz
2006-03-03 22:46 ` David Greaves
2006-03-04 14:25 ` Mark Lord
2006-03-06 6:13 ` David Greaves
2006-03-21 18:11 ` David Greaves
2006-03-22 15:23 ` David Greaves
2006-03-05 11:43 ` Justin Piszcz
2006-03-05 12:41 ` Justin Piszcz
2006-03-05 22:58 ` Mark Lord
2006-03-05 23:00 ` Mark Lord
2006-03-05 23:19 ` Justin Piszcz
2006-03-05 23:39 ` Jeff Garzik
2006-04-21 19:14 ` LibPATA code issues / 2.6.16 (previously, 2.6.15.x) Justin Piszcz
2006-04-21 19:18 ` Jeff Garzik
2006-04-21 19:28 ` Linus Torvalds
2006-04-21 22:46 ` Jeff Garzik
2006-04-22 0:05 ` Linus Torvalds
2006-05-06 15:09 ` [smartmontools-support]Re: " Leon Woestenberg
2006-05-07 12:44 ` Ingo Oeser
2006-06-11 11:13 ` Justin Piszcz
2006-03-01 19:06 ` LibPATA code issues / 2.6.15.4 Justin Piszcz
2006-03-01 19:28 ` Mark Lord
2006-03-01 19:35 ` Mark Lord
2006-03-01 19:38 ` Justin Piszcz
2006-03-01 19:41 ` Jeff Garzik
2006-02-26 12:27 ` James Courtier-Dutton
2006-02-26 12:55 ` David Greaves
2006-02-26 13:56 ` Mark Lord
2006-02-26 14:30 ` Kernel SeekCompleteErrors... Different from " James Courtier-Dutton
2006-02-26 17:03 ` Mark Lord
2006-02-26 17:13 ` Dr. David Alan Gilbert
2006-02-26 17:43 ` Alan Cox
2006-02-26 20:36 ` Mark Lord
2006-02-27 11:48 ` Alan Cox
2006-02-27 13:40 ` Mark Lord
2006-02-14 23:58 ` Justin Piszcz
2006-02-17 8:45 ` Jeff Garzik
2006-02-17 14:59 ` Mark Lord
2006-02-17 15:00 ` Justin Piszcz
2006-02-18 20:43 ` Sander
2006-02-18 21:42 ` Mark Lord
2006-02-18 21:51 ` Justin Piszcz
2006-02-19 7:14 ` Sander
2006-02-19 15:30 ` Mark Lord
2006-02-19 17:16 ` Sander
2006-07-06 23:08 ` Justin Piszcz
2006-07-07 13:08 ` Mark Lord
2006-07-07 13:24 ` Justin Piszcz
2006-07-07 13:43 ` Mark Lord
2006-07-07 13:48 ` Justin Piszcz
2006-07-07 14:01 ` Justin Piszcz
2006-07-07 14:35 ` Justin Piszcz
2006-07-07 18:53 ` Justin Piszcz
2006-07-07 19:19 ` Jeff Garzik
2006-07-07 19:28 ` Justin Piszcz
[not found] ` <200607091224.31451.liml@rtr.ca>
2006-07-09 17:27 ` Justin Piszcz
2006-07-09 20:16 ` Justin Piszcz
2006-07-09 20:40 ` LibPATA code issues / 2.6.15.4 (found the opcode=0x35)! Justin Piszcz
2006-07-09 20:46 ` Justin Piszcz
2006-07-09 21:05 ` Justin Piszcz
2006-07-09 22:03 ` Justin Piszcz
2006-07-10 13:59 ` Follow up? " Justin Piszcz
2006-07-10 15:33 ` Alan Cox
2006-07-10 15:45 ` Justin Piszcz
2006-07-11 13:28 ` LibPATA code issues / 2.6.17.3 (What is the next step?) Justin Piszcz
2006-07-11 16:12 ` Alan Cox
2006-07-12 22:10 ` David Greaves
2006-07-12 22:29 ` Justin Piszcz [this message]
2006-07-14 15:33 ` David Greaves
2006-07-13 10:55 ` Erik Mouw
2006-07-14 17:16 ` Mark Lord
2006-07-14 17:18 ` Justin Piszcz
2006-07-14 17:39 ` Mark Lord
2006-07-14 18:18 ` Justin Piszcz
2006-07-14 20:02 ` Mark Lord
2006-07-14 17:14 ` Follow up? LibPATA code issues / 2.6.15.4 (found the opcode=0x35)! Mark Lord
2006-07-14 17:17 ` Justin Piszcz
2006-07-14 17:37 ` Mark Lord
2006-07-14 18:17 ` Justin Piszcz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0607121828290.11285@p34.internal.lan \
--to=jpiszcz@lucidpixels.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=david@dgreaves.com \
--cc=jgarzik@pobox.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sander@humilis.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).