* [PATCH] synclink_gt: make ->init_error signed
@ 2006-02-28 21:26 Alexey Dobriyan
2006-02-28 21:38 ` Paul Fulghum
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2006-02-28 21:26 UTC (permalink / raw)
To: Andrew Morton; +Cc: Darren Jenkins, linux-kernel
From: "Darren Jenkins\\" <darrenrjenkins@gmail.com>
Examples of misuse are
3112 info->init_error = -1;
4440 if ((info->init_error = register_test(info)) < 0) {
Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
drivers/char/synclink_gt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/char/synclink_gt.c
+++ b/drivers/char/synclink_gt.c
@@ -306,7 +306,7 @@ struct slgt_info {
int tx_active;
unsigned char signals; /* serial signal states */
- unsigned int init_error; /* initialization error */
+ int init_error; /* initialization error */
unsigned char *tx_buf;
int tx_count;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] synclink_gt: make ->init_error signed
2006-02-28 21:26 [PATCH] synclink_gt: make ->init_error signed Alexey Dobriyan
@ 2006-02-28 21:38 ` Paul Fulghum
0 siblings, 0 replies; 2+ messages in thread
From: Paul Fulghum @ 2006-02-28 21:38 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Andrew Morton, Darren Jenkins, linux-kernel
Alexey Dobriyan wrote:
> From: "Darren Jenkins\\" <darrenrjenkins@gmail.com>
>
> Examples of misuse are
>
> 3112 info->init_error = -1;
>
> 4440 if ((info->init_error = register_test(info)) < 0) {
>
> Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> drivers/char/synclink_gt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/char/synclink_gt.c
> +++ b/drivers/char/synclink_gt.c
> @@ -306,7 +306,7 @@ struct slgt_info {
> int tx_active;
>
> unsigned char signals; /* serial signal states */
> - unsigned int init_error; /* initialization error */
> + int init_error; /* initialization error */
>
> unsigned char *tx_buf;
> int tx_count;
Yes, should definately by signed.
Acked-by: Paul Fulghum <paulkf@microgate.com>
--
Paul Fulghum
Microgate Systems, Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-02-28 21:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-28 21:26 [PATCH] synclink_gt: make ->init_error signed Alexey Dobriyan
2006-02-28 21:38 ` Paul Fulghum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).