From: "Mika Penttilä" <mika.penttila@nextfour.com>
To: Alex Shi <alex.shi@linux.alibaba.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Matthew Wilcox <willy@infradead.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Linux-MM <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hugh Dickins <hughd@google.com>
Subject: Re: a question of split_huge_page
Date: Fri, 10 Jul 2020 08:28:58 +0300 [thread overview]
Message-ID: <441ebbeb-0408-e22e-20f4-1be571c4a18e@nextfour.com> (raw)
In-Reply-To: <f761007f-4663-f72e-b0da-fc3ce9486b4b@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 2861 bytes --]
On 10.7.2020 7.51, Alex Shi wrote:
>
> 在 2020/7/10 上午12:07, Kirill A. Shutemov 写道:
>> On Thu, Jul 09, 2020 at 04:50:02PM +0100, Matthew Wilcox wrote:
>>> On Thu, Jul 09, 2020 at 11:11:11PM +0800, Alex Shi wrote:
>>>> Hi Kirill & Matthew,
>>>>
>>>> In the func call chain, from split_huge_page() to lru_add_page_tail(),
>>>> Seems tail pages are added to lru list at line 963, but in this scenario
>>>> the head page has no lru bit and isn't set the bit later. Why we do this?
>>>> or do I miss sth?
>>> I don't understand how we get to split_huge_page() with a page that's
>>> not on an LRU list. Both anonymous and page cache pages should be on
>>> an LRU list. What am I missing?>
>
> Thanks a lot for quick reply!
> What I am confusing is the call chain: __iommu_dma_alloc_pages()
> to split_huge_page(), in the func, splited page,
> page = alloc_pages_node(nid, alloc_flags, order);
> And if the pages were added into lru, they maybe reclaimed and lost,
> that would be a panic bug. But in fact, this never happened for long time.
> Also I put a BUG() at the line, it's nevre triggered in ltp, and run_vmtests
In __iommu_dma_alloc_pages, after split_huge_page(), who is taking a
reference on tail pages? Seems tail pages are freed and the function
errornously returns them in pages[] array for use?
> in kselftest.
>
>> Right, and it's never got removed from LRU during the split. The tail
>> pages have to be added to LRU because they now separate from the tail
>> page.
>>
> According to the explaination, looks like we could remove the code path,
> since it's never got into. (base on my v15 patchset). Any comments?
>
> Thanks
> Alex
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 7c52c5228aab..c28409509ad3 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -2357,17 +2357,6 @@ static void lru_add_page_tail(struct page *head, struct page *page_tail,
> if (!list)
> SetPageLRU(page_tail);
>
> if (likely(PageLRU(head)))
> list_add_tail(&page_tail->lru, &head->lru);
> else if (list) {
> /* page reclaim is reclaiming a huge page */
> get_page(page_tail);
> list_add_tail(&page_tail->lru, list);
> - } else {
> - /*
> - * Head page has not yet been counted, as an hpage,
> - * so we must account for each subpage individually.
> - *
> - * Put page_tail on the list at the correct position
> - * so they all end up in order.
> - */
> - VM_BUG_ON_PAGE(1, head);
> - add_page_to_lru_list_tail(page_tail, lruvec,
> - page_lru(page_tail));
> }
> }
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 3157 bytes --]
next prev parent reply other threads:[~2020-07-10 5:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 15:11 a question of split_huge_page Alex Shi
2020-07-09 15:50 ` Matthew Wilcox
2020-07-09 16:07 ` Kirill A. Shutemov
2020-07-10 4:51 ` Alex Shi
2020-07-10 5:28 ` Mika Penttilä [this message]
2020-07-10 7:00 ` Alex Shi
2020-07-10 7:22 ` Mika Penttilä
2020-07-10 9:34 ` Alex Shi
2020-07-10 12:56 ` Joerg Roedel
2020-07-10 17:29 ` Yang Shi
2020-07-10 10:33 ` Kirill A. Shutemov
2020-07-10 14:23 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441ebbeb-0408-e22e-20f4-1be571c4a18e@nextfour.com \
--to=mika.penttila@nextfour.com \
--cc=alex.shi@linux.alibaba.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).