From: Alex Shi <alex.shi@linux.alibaba.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Matthew Wilcox <willy@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Linux-MM <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hugh Dickins <hughd@google.com>
Subject: Re: a question of split_huge_page
Date: Fri, 10 Jul 2020 22:23:57 +0800 [thread overview]
Message-ID: <f6ce8cbe-9645-4b33-d699-663e68118bcd@linux.alibaba.com> (raw)
In-Reply-To: <20200710103318.bm2gp743lagiajao@box>
在 2020/7/10 下午6:33, Kirill A. Shutemov 写道:
> On Fri, Jul 10, 2020 at 12:51:58PM +0800, Alex Shi wrote:
>>
>>
>> 在 2020/7/10 上午12:07, Kirill A. Shutemov 写道:
>>> Right, and it's never got removed from LRU during the split. The tail
>>> pages have to be added to LRU because they now separate from the tail
>>> page.
>>>
>> According to the explaination, looks like we could remove the code path,
>> since it's never got into. (base on my v15 patchset). Any comments?
>
> Yes. But why? It's reasonable failsafe that gives chance to recover if
> something goes wrong.
>
Hi Kirill,
Sorry, I didn't get your points. IMHO, this fallback cann't work well,
since the head page isn't and shouldn't be added to lru. like the iommu issue
if a dma page added into lru list, it may be reclaim and lost. So, sorry, I
still don't know how this path could fix some wrong.
Thanks
Alex
prev parent reply other threads:[~2020-07-10 14:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 15:11 a question of split_huge_page Alex Shi
2020-07-09 15:50 ` Matthew Wilcox
2020-07-09 16:07 ` Kirill A. Shutemov
2020-07-10 4:51 ` Alex Shi
2020-07-10 5:28 ` Mika Penttilä
2020-07-10 7:00 ` Alex Shi
2020-07-10 7:22 ` Mika Penttilä
2020-07-10 9:34 ` Alex Shi
2020-07-10 12:56 ` Joerg Roedel
2020-07-10 17:29 ` Yang Shi
2020-07-10 10:33 ` Kirill A. Shutemov
2020-07-10 14:23 ` Alex Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6ce8cbe-9645-4b33-d699-663e68118bcd@linux.alibaba.com \
--to=alex.shi@linux.alibaba.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).