* [PATCH v2] platform/x86: intel-hid: fix _DSM function index handling
@ 2022-05-16 13:06 Michael Niewöhner
2022-05-17 16:14 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Michael Niewöhner @ 2022-05-16 13:06 UTC (permalink / raw)
To: Alex Hung, Hans de Goede, Mark Gross, platform-driver-x86,
linux-kernel, trivial
intel_hid_dsm_fn_mask is a bit mask containing one bit for each function
index. Fix the function index check in intel_hid_evaluate_method
accordingly, which was missed in commit 97ab4516205e ("platform/x86:
intel-hid: fix _DSM function index handling").
Cc: stable@vger.kernel.org
Signed-off-by: Michael Niewöhner <linux@mniewoehner.de>
---
Changes in v2:
Added Cc to stable
drivers/platform/x86/intel/hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
index 13f8cf70b9ae..5c39d40a701b 100644
--- a/drivers/platform/x86/intel/hid.c
+++ b/drivers/platform/x86/intel/hid.c
@@ -238,7 +238,7 @@ static bool intel_hid_evaluate_method(acpi_handle handle,
method_name = (char *)intel_hid_dsm_fn_to_method[fn_index];
- if (!(intel_hid_dsm_fn_mask & fn_index))
+ if (!(intel_hid_dsm_fn_mask & BIT(fn_index)))
goto skip_dsm_eval;
obj = acpi_evaluate_dsm_typed(handle, &intel_dsm_guid,
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] platform/x86: intel-hid: fix _DSM function index handling
2022-05-16 13:06 [PATCH v2] platform/x86: intel-hid: fix _DSM function index handling Michael Niewöhner
@ 2022-05-17 16:14 ` Andy Shevchenko
2022-05-17 18:31 ` [PATCH v3] " Michael Niewöhner
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2022-05-17 16:14 UTC (permalink / raw)
To: Michael Niewöhner
Cc: Alex Hung, Hans de Goede, Mark Gross, Platform Driver,
Linux Kernel Mailing List, Jiri Kosina
On Mon, May 16, 2022 at 3:58 PM Michael Niewöhner <linux@mniewoehner.de> wrote:
>
> intel_hid_dsm_fn_mask is a bit mask containing one bit for each function
> index. Fix the function index check in intel_hid_evaluate_method
> accordingly, which was missed in commit 97ab4516205e ("platform/x86:
> intel-hid: fix _DSM function index handling").
Hence Fixes tag?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3] platform/x86: intel-hid: fix _DSM function index handling
2022-05-17 16:14 ` Andy Shevchenko
@ 2022-05-17 18:31 ` Michael Niewöhner
2022-05-19 17:38 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Michael Niewöhner @ 2022-05-17 18:31 UTC (permalink / raw)
To: Andy Shevchenko, Alex Hung, Hans de Goede, Mark Gross,
Platform Driver, Linux Kernel Mailing List, Jiri Kosina
intel_hid_dsm_fn_mask is a bit mask containing one bit for each function
index. Fix the function index check in intel_hid_evaluate_method
accordingly, which was missed in commit 97ab4516205e ("platform/x86:
intel-hid: fix _DSM function index handling").
Fixes: 97ab4516205e ("platform/x86: intel-hid: fix _DSM function index handling")
Cc: stable@vger.kernel.org
Signed-off-by: Michael Niewöhner <linux@mniewoehner.de>
---
Changes in v3:
Added Fixes tag
Changes in v2:
Added Cc to stable
drivers/platform/x86/intel/hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
index 13f8cf70b9ae..5c39d40a701b 100644
--- a/drivers/platform/x86/intel/hid.c
+++ b/drivers/platform/x86/intel/hid.c
@@ -238,7 +238,7 @@ static bool intel_hid_evaluate_method(acpi_handle handle,
method_name = (char *)intel_hid_dsm_fn_to_method[fn_index];
- if (!(intel_hid_dsm_fn_mask & fn_index))
+ if (!(intel_hid_dsm_fn_mask & BIT(fn_index)))
goto skip_dsm_eval;
obj = acpi_evaluate_dsm_typed(handle, &intel_dsm_guid,
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] platform/x86: intel-hid: fix _DSM function index handling
2022-05-17 18:31 ` [PATCH v3] " Michael Niewöhner
@ 2022-05-19 17:38 ` Hans de Goede
0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2022-05-19 17:38 UTC (permalink / raw)
To: Michael Niewöhner, Andy Shevchenko, Alex Hung, Mark Gross,
Platform Driver, Linux Kernel Mailing List, Jiri Kosina
Hi,
On 5/17/22 20:31, Michael Niewöhner wrote:
> intel_hid_dsm_fn_mask is a bit mask containing one bit for each function
> index. Fix the function index check in intel_hid_evaluate_method
> accordingly, which was missed in commit 97ab4516205e ("platform/x86:
> intel-hid: fix _DSM function index handling").
>
> Fixes: 97ab4516205e ("platform/x86: intel-hid: fix _DSM function index handling")
> Cc: stable@vger.kernel.org
> Signed-off-by: Michael Niewöhner <linux@mniewoehner.de>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> Changes in v3:
> Added Fixes tag
>
> Changes in v2:
> Added Cc to stable
>
> drivers/platform/x86/intel/hid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 13f8cf70b9ae..5c39d40a701b 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -238,7 +238,7 @@ static bool intel_hid_evaluate_method(acpi_handle handle,
>
> method_name = (char *)intel_hid_dsm_fn_to_method[fn_index];
>
> - if (!(intel_hid_dsm_fn_mask & fn_index))
> + if (!(intel_hid_dsm_fn_mask & BIT(fn_index)))
> goto skip_dsm_eval;
>
> obj = acpi_evaluate_dsm_typed(handle, &intel_dsm_guid,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-19 17:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 13:06 [PATCH v2] platform/x86: intel-hid: fix _DSM function index handling Michael Niewöhner
2022-05-17 16:14 ` Andy Shevchenko
2022-05-17 18:31 ` [PATCH v3] " Michael Niewöhner
2022-05-19 17:38 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).