* [PATCH][2.6.17]drivers/media/video/bt8xx/bttvp.h has wrong include line
@ 2006-06-22 12:58 Predrag Ivanovic
2006-06-22 14:26 ` [v4l-dvb-maintainer] " Michael Krufky
0 siblings, 1 reply; 2+ messages in thread
From: Predrag Ivanovic @ 2006-06-22 12:58 UTC (permalink / raw)
To: v4l-dvb-maintainer; +Cc: linux-kernel
Hi.
Trivial patch, really.
Fixes include line in bttvp.h(btcx-risc.h is in parent dir).
------
--- bttvp.h 2006-06-19 16:48:46.000000000 +0200
+++ bttvp.h.new 2006-06-19 16:49:54.000000000 +0200
@@ -48,7 +48,7 @@
#include "bt848.h"
#include "bttv.h"
-#include "btcx-risc.h"
+#include "../btcx-risc.h"
#ifdef __KERNEL__
-----------
Pedja
--
Recent studies suggest that running /usr/bin/coffee from cron at regular
intervals can be more effective at enhancing uptime than launching a big
coffeed process at startup.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [v4l-dvb-maintainer] [PATCH][2.6.17]drivers/media/video/bt8xx/bttvp.h has wrong include line
2006-06-22 12:58 [PATCH][2.6.17]drivers/media/video/bt8xx/bttvp.h has wrong include line Predrag Ivanovic
@ 2006-06-22 14:26 ` Michael Krufky
0 siblings, 0 replies; 2+ messages in thread
From: Michael Krufky @ 2006-06-22 14:26 UTC (permalink / raw)
To: predivan; +Cc: v4l-dvb-maintainer, linux-kernel
Predrag Ivanovic wrote:
> Hi.
> Trivial patch, really.
> Fixes include line in bttvp.h(btcx-risc.h is in parent dir).
> ------
> --- bttvp.h 2006-06-19 16:48:46.000000000 +0200
> +++ bttvp.h.new 2006-06-19 16:49:54.000000000 +0200
> @@ -48,7 +48,7 @@
>
> #include "bt848.h"
> #include "bttv.h"
> -#include "btcx-risc.h"
> +#include "../btcx-risc.h"
>
> #ifdef __KERNEL__
>
> -----------
> Pedja
>
NACK.
Please see drivers/media/video/bt8xx/Makefile
You will notice the following line:
EXTRA_CFLAGS += -Idrivers/media/video
This instructs the compiler to find some other required headers in
drivers/media/video (such as btcx-risc.h)
Your patch is unnecessary, and it is bad practice to use ".." inside a
header includes path, IMHO at least.
In addition, please see the guidelines in
Documentation/SubmittingPatches before you send any future patches. We
cannot accept patches into the linux kernel without a proper developer's
certificate of origin.
Thank you for the effort, though :-)
Regards,
Michael Krufky
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-22 14:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-22 12:58 [PATCH][2.6.17]drivers/media/video/bt8xx/bttvp.h has wrong include line Predrag Ivanovic
2006-06-22 14:26 ` [v4l-dvb-maintainer] " Michael Krufky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).