[patch] 2.6.17: lockless pagecache

[patch] 2.6.17: lockless pagecache

[Nick Piggin]

Updated lockless pagecache patchset available here:

ftp://ftp.kernel.org/pub/linux/kernel/people/npiggin/patches/lockless/2.6.17/lockless.patch.gz

This should hopefully be my last release using the old (2.6.17)
indirect radix-tree, and I'll switch to the direct radix-tree in
future.

Changes since last release:
- lots of radix-tree cleanups and bugs fixed
- radix-tree tag lookups may be lockless
- added some missing memory barriers
- lockless pagevec_lookup_tag

The last item allowed me to remove the last few read-lockers,
which is nice.

Re: [patch] 2.6.17: lockless pagecache

[Michal Piotrowski]

Hi Nick,

On 25/06/06, Nick Piggin <npiggin@suse.de> wrote:
> Updated lockless pagecache patchset available here:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/npiggin/patches/lockless/2.6.17/lockless.patch.gz
>

"make O=/dir oldconfig" doesn't work.

[michal@ltg01-fedora linux-work]$ LANG="C" make O=../linux-work-obj/ oldconfig
  GEN     /usr/src/linux-work-obj/Makefile
  HOSTCC  scripts/kconfig/zconf.tab.o
In file included from scripts/kconfig/zconf.tab.c:158:
scripts/kconfig/zconf.hash.c: In function 'kconf_id_lookup':
scripts/kconfig/zconf.hash.c:190: error: 'T_OPT_DEFCONFIG_LIST'
undeclared (first use in this function)
scripts/kconfig/zconf.hash.c:190: error: (Each undeclared identifier
is reported only once
scripts/kconfig/zconf.hash.c:190: error: for each function it appears in.)
scripts/kconfig/zconf.hash.c:190: error: 'TF_OPTION' undeclared (first
use in this function)
scripts/kconfig/zconf.hash.c:203: error: 'T_OPT_MODULES' undeclared
(first use in this function)
scripts/kconfig/zconf.tab.c: In function 'zconfparse':
scripts/kconfig/zconf.tab.c:1557: error: 'TF_OPTION' undeclared (first
use in this function)
scripts/kconfig/zconf.tab.c:1557: error: invalid operands to binary &
scripts/kconfig/zconf.tab.c:1558: warning: implicit declaration of
function 'menu_add_option'
make[2]: *** [scripts/kconfig/zconf.tab.o] Error 1
make[1]: *** [oldconfig] Error 2
make: *** [oldconfig] Error 2

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)

Re: [patch] 2.6.17: lockless pagecache

[Michal Piotrowski]

Nick Piggin napisał(a):
> Updated lockless pagecache patchset available here:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/npiggin/patches/lockless/2.6.17/lockless.patch.gz
> 

Here is my fix for this warnings
WARNING: /lib/modules/2.6.17.1/kernel/fs/ntfs/ntfs.ko needs unknown symbol add_to_page_cache
WARNING: /lib/modules/2.6.17.1/kernel/fs/ntfs/ntfs.ko needs unknown symbol add_to_page_cache

Regards,
Michal

--
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)

diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/mm/filemap.c linux-work/mm/filemap.c
--- linux-work-clean/mm/filemap.c	2006-06-25 19:47:47.000000000 +0200
+++ linux-work/mm/filemap.c	2006-06-25 19:50:43.000000000 +0200
@@ -445,6 +445,8 @@ int add_to_page_cache(struct page *page,
 	return error;
 }

+EXPORT_SYMBOL(add_to_page_cache);
+
 /*
  * Same as add_to_page_cache, but works on pages that are already in
  * swapcache and possibly visible to external lookups.

Re: [patch] 2.6.17: lockless pagecache

[Nick Piggin]

Michal Piotrowski wrote:
> Hi Nick,
> 
> On 25/06/06, Nick Piggin <npiggin@suse.de> wrote:
> 
>> Updated lockless pagecache patchset available here:
>>
>> ftp://ftp.kernel.org/pub/linux/kernel/people/npiggin/patches/lockless/2.6.17/lockless.patch.gz 
>>
>>
> 
> "make O=/dir oldconfig" doesn't work.
> 
> [michal@ltg01-fedora linux-work]$ LANG="C" make O=../linux-work-obj/ 
> oldconfig

Hmm, I can't see how I did that.

npiggin@didi:~/x$ zcat lockless.patch.gz | diffstat
  drivers/mtd/devices/block2mtd.c |    7 -
  fs/buffer.c                     |    4
  fs/inode.c                      |    2
  include/asm-arm/cacheflush.h    |    4
  include/asm-parisc/cacheflush.h |    4
  include/linux/fs.h              |    2
  include/linux/mm.h              |    6
  include/linux/page-flags.h      |   26 ++--
  include/linux/pagemap.h         |   74 ++++++++++++
  include/linux/radix-tree.h      |   67 +++++++++++
  include/linux/swap.h            |    1
  lib/radix-tree.c                |  240 +++++++++++++++++++++++++++------------
  mm/filemap.c                    |  242 ++++++++++++++++++++++++++++++----------
  mm/hugetlb.c                    |    8 -
  mm/migrate.c                    |   21 ++-
  mm/page-writeback.c             |   40 ++----
  mm/readahead.c                  |    7 -
  mm/swap_state.c                 |   43 +++++--
  mm/swapfile.c                   |    6
  mm/truncate.c                   |    6
  mm/vmscan.c                     |   20 ++-
  21 files changed, 619 insertions(+), 211 deletions(-)

I recall there was a bit of noise recently about problems building
into an external working directory?

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

Re: [patch] 2.6.17: lockless pagecache

[Nick Piggin]

Michal Piotrowski wrote:
> Nick Piggin napisał(a):
> 
>>Updated lockless pagecache patchset available here:
>>
>>ftp://ftp.kernel.org/pub/linux/kernel/people/npiggin/patches/lockless/2.6.17/lockless.patch.gz
>>
> 
> 
> Here is my fix for this warnings
> WARNING: /lib/modules/2.6.17.1/kernel/fs/ntfs/ntfs.ko needs unknown symbol add_to_page_cache
> WARNING: /lib/modules/2.6.17.1/kernel/fs/ntfs/ntfs.ko needs unknown symbol add_to_page_cache

Thanks. Accidentally nuked that export.

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

Re: [patch] 2.6.17: lockless pagecache

[Michal Piotrowski]

On 26/06/06, Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> Michal Piotrowski wrote:
> > Hi Nick,
> >
> > On 25/06/06, Nick Piggin <npiggin@suse.de> wrote:
> >
> >> Updated lockless pagecache patchset available here:
> >>
> >> ftp://ftp.kernel.org/pub/linux/kernel/people/npiggin/patches/lockless/2.6.17/lockless.patch.gz
> >>
> >>
> >
> > "make O=/dir oldconfig" doesn't work.
> >
> > [michal@ltg01-fedora linux-work]$ LANG="C" make O=../linux-work-obj/
> > oldconfig
>
> Hmm, I can't see how I did that.
>
> npiggin@didi:~/x$ zcat lockless.patch.gz | diffstat
>   drivers/mtd/devices/block2mtd.c |    7 -
>   fs/buffer.c                     |    4
>   fs/inode.c                      |    2
>   include/asm-arm/cacheflush.h    |    4
>   include/asm-parisc/cacheflush.h |    4
>   include/linux/fs.h              |    2
>   include/linux/mm.h              |    6
>   include/linux/page-flags.h      |   26 ++--
>   include/linux/pagemap.h         |   74 ++++++++++++
>   include/linux/radix-tree.h      |   67 +++++++++++
>   include/linux/swap.h            |    1
>   lib/radix-tree.c                |  240 +++++++++++++++++++++++++++------------
>   mm/filemap.c                    |  242 ++++++++++++++++++++++++++++++----------
>   mm/hugetlb.c                    |    8 -
>   mm/migrate.c                    |   21 ++-
>   mm/page-writeback.c             |   40 ++----
>   mm/readahead.c                  |    7 -
>   mm/swap_state.c                 |   43 +++++--
>   mm/swapfile.c                   |    6
>   mm/truncate.c                   |    6
>   mm/vmscan.c                     |   20 ++-
>   21 files changed, 619 insertions(+), 211 deletions(-)
>
> I recall there was a bit of noise recently about problems building
> into an external working directory?

Sorry for noise - it's 2.6.17 problem. I didn't notice this.

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)