linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -mm only] Pass IO size to batch_write() address space operation
       [not found] <200607091208.k69C8umv021827@shell0.pdx.osdl.net>
@ 2006-07-24 17:50 ` Badari Pulavarty
  0 siblings, 0 replies; only message in thread
From: Badari Pulavarty @ 2006-07-24 17:50 UTC (permalink / raw)
  To: linux-kernel; +Cc: akpm, hch, miklos, nathans, reiser, swhiteho, vs

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

Hi,

Here is the patch to pass size of the remaining IO to batch_write() 
interface.
I would like to use it ext3/ext4 to allocate in chunks. Currently its 
passing
only the size of the current buffer (in the vector entry).

Comments ? Flames ? Looks reasonable ?

Thanks,
Badari



[-- Attachment #2: pass_io_size_to_batch_write.patch --]
[-- Type: text/plain, Size: 1831 bytes --]

Pass remaining size of this IO to batch_write(). This
way filesystems could choose to allocate for the entire IO,
instead of current buffer size.

I would like to use this for setting ext3 reservation window
or allocating entire extent (ext4).


Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com>

---
 include/linux/fs.h |    2 ++
 mm/filemap.c       |    1 +
 2 files changed, 3 insertions(+)

Index: linux-2.6.18-rc1/include/linux/fs.h
===================================================================
--- linux-2.6.18-rc1.orig/include/linux/fs.h	2006-07-24 10:12:18.000000000 -0700
+++ linux-2.6.18-rc1/include/linux/fs.h	2006-07-24 10:35:51.000000000 -0700
@@ -356,6 +356,7 @@ struct writeback_control;
  * struct write_descriptor - set of write arguments
  * @pos: offset from the start of the file to write to
  * @count: number of bytes to write
+ * @iosize: remaining number of bytes in the IO
  * @buf: pointer to data to be written
  * @lru_pvec: multipage container to batch adding pages to LRU list
  * @cached_page: allocated but not used on previous call
@@ -366,6 +367,7 @@ struct writeback_control;
 struct write_descriptor {
 	loff_t pos;
 	size_t count;
+	size_t iosize;
 	char __user *buf;
 	struct page *cached_page;
 	struct pagevec *lru_pvec;
Index: linux-2.6.18-rc1/mm/filemap.c
===================================================================
--- linux-2.6.18-rc1.orig/mm/filemap.c	2006-07-24 10:12:20.000000000 -0700
+++ linux-2.6.18-rc1/mm/filemap.c	2006-07-24 10:36:44.000000000 -0700
@@ -2278,6 +2278,7 @@ generic_file_buffered_write(struct kiocb
 	do {
 		/* do not walk over current segment */
 		desc.buf = cur_iov->iov_base + iov_base;
+		desc.iosize = count;
 		desc.count = min(count, cur_iov->iov_len - iov_base);
 		if (desc.count > 0)
 			status = (*batch_write)(file, &desc, &copied);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-07-24 17:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <200607091208.k69C8umv021827@shell0.pdx.osdl.net>
2006-07-24 17:50 ` [PATCH -mm only] Pass IO size to batch_write() address space operation Badari Pulavarty

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).