* [PATCH v2] powerpc/mm: fix "section_base" set but not used
@ 2019-03-01 14:20 Qian Cai
2019-03-04 0:48 ` [v2] " Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Qian Cai @ 2019-03-01 14:20 UTC (permalink / raw)
To: benh, paulus, mpe; +Cc: hch, linuxppc-dev, linux-kernel, Qian Cai
The commit 24b6d4164348 ("mm: pass the vmem_altmap to vmemmap_free")
removed a line in vmemmap_free(),
altmap = to_vmem_altmap((unsigned long) section_base);
but left a variable no longer used.
arch/powerpc/mm/init_64.c: In function 'vmemmap_free':
arch/powerpc/mm/init_64.c:277:16: error: variable 'section_base' set but
not used [-Werror=unused-but-set-variable]
Signed-off-by: Qian Cai <cai@lca.pw>
---
v2: improve the commit message.
arch/powerpc/mm/init_64.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/mm/init_64.c b/arch/powerpc/mm/init_64.c
index a5091c034747..a4c155af1597 100644
--- a/arch/powerpc/mm/init_64.c
+++ b/arch/powerpc/mm/init_64.c
@@ -274,7 +274,6 @@ void __ref vmemmap_free(unsigned long start, unsigned long end,
for (; start < end; start += page_size) {
unsigned long nr_pages, addr;
- struct page *section_base;
struct page *page;
/*
@@ -290,7 +289,6 @@ void __ref vmemmap_free(unsigned long start, unsigned long end,
continue;
page = pfn_to_page(addr >> PAGE_SHIFT);
- section_base = pfn_to_page(vmemmap_section_start(start));
nr_pages = 1 << page_order;
base_pfn = PHYS_PFN(addr);
--
2.17.2 (Apple Git-113)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [v2] powerpc/mm: fix "section_base" set but not used
2019-03-01 14:20 [PATCH v2] powerpc/mm: fix "section_base" set but not used Qian Cai
@ 2019-03-04 0:48 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2019-03-04 0:48 UTC (permalink / raw)
To: Qian Cai, benh, paulus; +Cc: Qian Cai, linuxppc-dev, hch, linux-kernel
On Fri, 2019-03-01 at 14:20:40 UTC, Qian Cai wrote:
> The commit 24b6d4164348 ("mm: pass the vmem_altmap to vmemmap_free")
> removed a line in vmemmap_free(),
>
> altmap = to_vmem_altmap((unsigned long) section_base);
>
> but left a variable no longer used.
>
> arch/powerpc/mm/init_64.c: In function 'vmemmap_free':
> arch/powerpc/mm/init_64.c:277:16: error: variable 'section_base' set but
> not used [-Werror=unused-but-set-variable]
>
> Signed-off-by: Qian Cai <cai@lca.pw>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/c38ca265525a00d635219450e8fcc858
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-04 0:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-01 14:20 [PATCH v2] powerpc/mm: fix "section_base" set but not used Qian Cai
2019-03-04 0:48 ` [v2] " Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).