* [PATCH v2] pinctrl: rockchip: add support the get_direction
@ 2016-03-15 7:55 Caesar Wang
2016-04-01 0:21 ` Heiko Stuebner
2016-04-13 13:26 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Caesar Wang @ 2016-03-15 7:55 UTC (permalink / raw)
To: linus.walleij, heiko
Cc: linux-gpio, linux-kernel, Caesar Wang, linux-rockchip
This patch adds the get_direction to support the gpio
interface.
The gpio direction is not used on rockchip platform when use the gpio
debugfs.
Tested on kylin board. (RK3036 SoCs)
The repro steps:
$/sys/class/gpio/
echo 53 > export
$/sys/class/gpio/gpio53# cat direction
in
In general, the gpio53 should be out value, but the direction is the
default value 'in', since the get_direction didn't supported in rockchip
pinctrl.
So, we should add this patch to support it.
Reported-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-gpio@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
---
Changes in v2:
- As Heiko comments on (https://patchwork.kernel.org/patch/8576661/),
fixes the wrong offset from original patch.
drivers/pinctrl/pinctrl-rockchip.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index bf032b9..0b3fd02 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -1208,6 +1208,16 @@ static int rockchip_pmx_set(struct pinctrl_dev *pctldev, unsigned selector,
return 0;
}
+static int rockchip_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
+{
+ struct rockchip_pin_bank *bank = gpiochip_get_data(chip);
+ u32 data;
+
+ data = readl_relaxed(bank->reg_base + GPIO_SWPORT_DDR);
+
+ return !(data & BIT(offset));
+}
+
/*
* The calls to gpio_direction_output() and gpio_direction_input()
* leads to this function call (via the pinctrl_gpio_direction_{input|output}()
@@ -1741,6 +1751,7 @@ static const struct gpio_chip rockchip_gpiolib_chip = {
.free = gpiochip_generic_free,
.set = rockchip_gpio_set,
.get = rockchip_gpio_get,
+ .get_direction = rockchip_gpio_get_direction,
.direction_input = rockchip_gpio_direction_input,
.direction_output = rockchip_gpio_direction_output,
.to_irq = rockchip_gpio_to_irq,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] pinctrl: rockchip: add support the get_direction
2016-03-15 7:55 [PATCH v2] pinctrl: rockchip: add support the get_direction Caesar Wang
@ 2016-04-01 0:21 ` Heiko Stuebner
2016-04-13 13:26 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2016-04-01 0:21 UTC (permalink / raw)
To: Caesar Wang; +Cc: linus.walleij, linux-gpio, linux-kernel, linux-rockchip
Am Dienstag, 15. März 2016, 15:55:45 schrieb Caesar Wang:
> This patch adds the get_direction to support the gpio
> interface.
>
> The gpio direction is not used on rockchip platform when use the gpio
> debugfs.
>
> Tested on kylin board. (RK3036 SoCs)
> The repro steps:
> $/sys/class/gpio/
> echo 53 > export
> $/sys/class/gpio/gpio53# cat direction
> in
> In general, the gpio53 should be out value, but the direction is the
> default value 'in', since the get_direction didn't supported in rockchip
> pinctrl.
>
> So, we should add this patch to support it.
>
> Reported-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] pinctrl: rockchip: add support the get_direction
2016-03-15 7:55 [PATCH v2] pinctrl: rockchip: add support the get_direction Caesar Wang
2016-04-01 0:21 ` Heiko Stuebner
@ 2016-04-13 13:26 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-04-13 13:26 UTC (permalink / raw)
To: Caesar Wang
Cc: Heiko Stübner, linux-gpio, linux-kernel,
open list:ARM/Rockchip SoC...
On Tue, Mar 15, 2016 at 8:55 AM, Caesar Wang <wxt@rock-chips.com> wrote:
> This patch adds the get_direction to support the gpio
> interface.
>
> The gpio direction is not used on rockchip platform when use the gpio
> debugfs.
>
> Tested on kylin board. (RK3036 SoCs)
> The repro steps:
> $/sys/class/gpio/
> echo 53 > export
> $/sys/class/gpio/gpio53# cat direction
> in
> In general, the gpio53 should be out value, but the direction is the
> default value 'in', since the get_direction didn't supported in rockchip
> pinctrl.
>
> So, we should add this patch to support it.
>
> Reported-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-rockchip@lists.infradead.org
>
> ---
>
> Changes in v2:
> - As Heiko comments on (https://patchwork.kernel.org/patch/8576661/),
> fixes the wrong offset from original patch.
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-13 13:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-15 7:55 [PATCH v2] pinctrl: rockchip: add support the get_direction Caesar Wang
2016-04-01 0:21 ` Heiko Stuebner
2016-04-13 13:26 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).