* [PATCH v2] cpufreq: nforce2: Remove meaningless return
@ 2018-12-05 15:57 Yangtao Li
2018-12-06 4:20 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Yangtao Li @ 2018-12-05 15:57 UTC (permalink / raw)
To: rjw, viresh.kumar; +Cc: linux-pm, linux-kernel, Yangtao Li
Delete a line of meaningless return and some useless blank lines. In a function
whose return type is void, returning on the last line is not required.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
Changes in v2:
-revert modify of MODULE_
-delete some blank lines
---
drivers/cpufreq/cpufreq-nforce2.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/cpufreq/cpufreq-nforce2.c b/drivers/cpufreq/cpufreq-nforce2.c
index dbf82f36d270..33c309a08c64 100644
--- a/drivers/cpufreq/cpufreq-nforce2.c
+++ b/drivers/cpufreq/cpufreq-nforce2.c
@@ -123,8 +123,6 @@ static void nforce2_write_pll(int pll)
/* Now write the value in all 64 registers */
for (temp = 0; temp <= 0x3f; temp++)
pci_write_config_dword(nforce2_dev, NFORCE2_PLLREG, pll);
-
- return;
}
/**
@@ -438,4 +436,3 @@ static void __exit nforce2_exit(void)
module_init(nforce2_init);
module_exit(nforce2_exit);
-
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] cpufreq: nforce2: Remove meaningless return
2018-12-05 15:57 [PATCH v2] cpufreq: nforce2: Remove meaningless return Yangtao Li
@ 2018-12-06 4:20 ` Viresh Kumar
2018-12-17 11:44 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2018-12-06 4:20 UTC (permalink / raw)
To: Yangtao Li; +Cc: rjw, linux-pm, linux-kernel
On 05-12-18, 10:57, Yangtao Li wrote:
> Delete a line of meaningless return and some useless blank lines. In a function
> whose return type is void, returning on the last line is not required.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> Changes in v2:
> -revert modify of MODULE_
> -delete some blank lines
> ---
> drivers/cpufreq/cpufreq-nforce2.c | 3 ---
> 1 file changed, 3 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] cpufreq: nforce2: Remove meaningless return
2018-12-06 4:20 ` Viresh Kumar
@ 2018-12-17 11:44 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-12-17 11:44 UTC (permalink / raw)
To: Viresh Kumar, Yangtao Li; +Cc: linux-pm, linux-kernel
On Thursday, December 6, 2018 5:20:25 AM CET Viresh Kumar wrote:
> On 05-12-18, 10:57, Yangtao Li wrote:
> > Delete a line of meaningless return and some useless blank lines. In a function
> > whose return type is void, returning on the last line is not required.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > Changes in v2:
> > -revert modify of MODULE_
> > -delete some blank lines
> > ---
> > drivers/cpufreq/cpufreq-nforce2.c | 3 ---
> > 1 file changed, 3 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Patch applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-17 11:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-05 15:57 [PATCH v2] cpufreq: nforce2: Remove meaningless return Yangtao Li
2018-12-06 4:20 ` Viresh Kumar
2018-12-17 11:44 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).