* [PATCH] genirq: fix irq flow handler uninstall
@ 2006-12-15 11:21 Thomas Gleixner
2006-12-15 20:12 ` Sylvain Munaut
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Gleixner @ 2006-12-15 11:21 UTC (permalink / raw)
To: LKML; +Cc: Sylvain Munaut, Andrew Morton, Benjamin Herrenschmidt, Ingo Molnar
The sanity check for no_irq_chip in __set_irq_hander() is unconditional
on both install and uninstall of an handler. This triggers false
warnings and replaces no_irq_chip by dummy_irq_chip in the uninstall
case.
Check only, when a real handler is installed.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Index: 2.6.19-git19/kernel/irq/chip.c
===================================================================
--- 2.6.19-git19.orig/kernel/irq/chip.c
+++ 2.6.19-git19/kernel/irq/chip.c
@@ -517,8 +517,7 @@ __set_irq_handler(unsigned int irq, irq_
if (!handle)
handle = handle_bad_irq;
-
- if (desc->chip == &no_irq_chip) {
+ else if (desc->chip == &no_irq_chip) {
printk(KERN_WARNING "Trying to install %sinterrupt handler "
"for IRQ%d\n", is_chained ? "chained " : " ", irq);
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] genirq: fix irq flow handler uninstall
2006-12-15 11:21 [PATCH] genirq: fix irq flow handler uninstall Thomas Gleixner
@ 2006-12-15 20:12 ` Sylvain Munaut
0 siblings, 0 replies; 2+ messages in thread
From: Sylvain Munaut @ 2006-12-15 20:12 UTC (permalink / raw)
To: tglx; +Cc: LKML, Andrew Morton, Benjamin Herrenschmidt, Ingo Molnar
Thomas Gleixner wrote:
> The sanity check for no_irq_chip in __set_irq_hander() is unconditional
> on both install and uninstall of an handler. This triggers false
> warnings and replaces no_irq_chip by dummy_irq_chip in the uninstall
> case.
>
> Check only, when a real handler is installed.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
Acked-by: Sylvain Munaut <tnt@246tNt.com>
Definitly fixed the spurious warning.
Sylvain
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-15 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-15 11:21 [PATCH] genirq: fix irq flow handler uninstall Thomas Gleixner
2006-12-15 20:12 ` Sylvain Munaut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).