* [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info
@ 2020-03-30 2:44 Zhiqiang Liu
2020-03-30 8:46 ` Oleg Nesterov
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Zhiqiang Liu @ 2020-03-30 2:44 UTC (permalink / raw)
To: ebiederm, oleg, christian.brauner, tj, akpm, guro, joel, linux-kernel
Cc: Mingfangsen, linfeilong, liuzhiqiang26
signal.c provides kill_proc_info, we can use it instead of kill_pid_info
in kill_something_info func gracefully.
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
---
kernel/signal.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index 9ad8dea93dbb..33c70f9f1728 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1552,12 +1552,8 @@ static int kill_something_info(int sig, struct kernel_siginfo *info, pid_t pid)
{
int ret;
- if (pid > 0) {
- rcu_read_lock();
- ret = kill_pid_info(sig, info, find_vpid(pid));
- rcu_read_unlock();
- return ret;
- }
+ if (pid > 0)
+ return kill_proc_info(sig, info, pid);
/* -INT_MIN is undefined. Exclude this case to avoid a UBSAN warning */
if (pid == INT_MIN)
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info
2020-03-30 2:44 [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info Zhiqiang Liu
@ 2020-03-30 8:46 ` Oleg Nesterov
2020-03-30 8:48 ` Christian Brauner
2020-04-12 20:59 ` Christian Brauner
2 siblings, 0 replies; 6+ messages in thread
From: Oleg Nesterov @ 2020-03-30 8:46 UTC (permalink / raw)
To: Zhiqiang Liu
Cc: ebiederm, christian.brauner, tj, akpm, guro, joel, linux-kernel,
Mingfangsen, linfeilong
On 03/30, Zhiqiang Liu wrote:
>
> @@ -1552,12 +1552,8 @@ static int kill_something_info(int sig, struct kernel_siginfo *info, pid_t pid)
> {
> int ret;
>
> - if (pid > 0) {
> - rcu_read_lock();
> - ret = kill_pid_info(sig, info, find_vpid(pid));
> - rcu_read_unlock();
> - return ret;
> - }
> + if (pid > 0)
> + return kill_proc_info(sig, info, pid);
>
Acked-by: Oleg Nesterov <oleg@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info
2020-03-30 2:44 [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info Zhiqiang Liu
2020-03-30 8:46 ` Oleg Nesterov
@ 2020-03-30 8:48 ` Christian Brauner
2020-04-09 3:26 ` Zhiqiang Liu
2020-04-12 20:59 ` Christian Brauner
2 siblings, 1 reply; 6+ messages in thread
From: Christian Brauner @ 2020-03-30 8:48 UTC (permalink / raw)
To: Zhiqiang Liu
Cc: ebiederm, oleg, tj, akpm, guro, joel, linux-kernel, Mingfangsen,
linfeilong
On Mon, Mar 30, 2020 at 10:44:43AM +0800, Zhiqiang Liu wrote:
>
> signal.c provides kill_proc_info, we can use it instead of kill_pid_info
> in kill_something_info func gracefully.
>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Thanks! I'll shorten the commit message header a little when picking
this up otherwise:
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info
2020-03-30 8:48 ` Christian Brauner
@ 2020-04-09 3:26 ` Zhiqiang Liu
2020-04-09 6:53 ` Christian Brauner
0 siblings, 1 reply; 6+ messages in thread
From: Zhiqiang Liu @ 2020-04-09 3:26 UTC (permalink / raw)
To: Christian Brauner
Cc: ebiederm, oleg, tj, akpm, guro, joel, linux-kernel, Mingfangsen,
linfeilong
Friendly ping...
On 2020/3/30 16:48, Christian Brauner wrote:
> On Mon, Mar 30, 2020 at 10:44:43AM +0800, Zhiqiang Liu wrote:
>>
>> signal.c provides kill_proc_info, we can use it instead of kill_pid_info
>> in kill_something_info func gracefully.
>>
>> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>
> Thanks! I'll shorten the commit message header a little when picking
> this up otherwise:
>
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info
2020-04-09 3:26 ` Zhiqiang Liu
@ 2020-04-09 6:53 ` Christian Brauner
0 siblings, 0 replies; 6+ messages in thread
From: Christian Brauner @ 2020-04-09 6:53 UTC (permalink / raw)
To: Zhiqiang Liu
Cc: ebiederm, oleg, tj, akpm, guro, joel, linux-kernel, Mingfangsen,
linfeilong
On April 9, 2020 5:26:30 AM GMT+02:00, Zhiqiang Liu <liuzhiqiang26@huawei.com> wrote:
>Friendly ping...
>
>On 2020/3/30 16:48, Christian Brauner wrote:
>> On Mon, Mar 30, 2020 at 10:44:43AM +0800, Zhiqiang Liu wrote:
>>>
>>> signal.c provides kill_proc_info, we can use it instead of
>kill_pid_info
>>> in kill_something_info func gracefully.
>>>
>>> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>>
>> Thanks! I'll shorten the commit message header a little when picking
>> this up otherwise:
>>
>> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
>>
>> .
>>
The patches are queued for after rc1. So around next week.
They came too late to make it into the merge window.
Christian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info
2020-03-30 2:44 [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info Zhiqiang Liu
2020-03-30 8:46 ` Oleg Nesterov
2020-03-30 8:48 ` Christian Brauner
@ 2020-04-12 20:59 ` Christian Brauner
2 siblings, 0 replies; 6+ messages in thread
From: Christian Brauner @ 2020-04-12 20:59 UTC (permalink / raw)
To: Zhiqiang Liu
Cc: ebiederm, oleg, tj, akpm, guro, joel, linux-kernel, Mingfangsen,
linfeilong
On Mon, Mar 30, 2020 at 10:44:43AM +0800, Zhiqiang Liu wrote:
>
> signal.c provides kill_proc_info, we can use it instead of kill_pid_info
> in kill_something_info func gracefully.
>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> Acked-by: Oleg Nesterov <oleg@redhat.com>
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Applied, thanks!
Christian
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-12 21:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 2:44 [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info Zhiqiang Liu
2020-03-30 8:46 ` Oleg Nesterov
2020-03-30 8:48 ` Christian Brauner
2020-04-09 3:26 ` Zhiqiang Liu
2020-04-09 6:53 ` Christian Brauner
2020-04-12 20:59 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).